Github user daserge commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-110401243
Closing this - decided to rewrite the scripts in node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user daserge closed the pull request at:
https://github.com/apache/cordova-ios/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-109396714
It'd be a great idea to convert the scripts from 'shell' to 'node'.
bash is hard to follow and make sense of.
---
If your project is set up for it, you can
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-109396260
Does it make sense to convert any of these scripts to node instead of
'shell'?
---
If your project is set up for it, you can reply to this email and have your
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/144#discussion_r31741687
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -87,6 +87,13 @@ module.exports.run = function (argv) {
}
return
Github user daserge commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-108975191
@omefire I don't have Android environment on Mac now, but as far as I can
see there are no shell scripts in Android platform.
---
If your project is set up for
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-108966698
@daserge , does this behavior show up if for example, I add android from
windows, then check it into git ?
---
If your project is set up for it, you can reply to
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-108911479
LGTM !
- what causes file permissions to change when the platform is added on a
non-OSX system ?
---
If your project is set up for it, you can reply to this
Github user daserge commented on the pull request:
https://github.com/apache/cordova-ios/pull/144#issuecomment-108915724
@omefire I think that it is because git does not include exec permission
for these files.
---
If your project is set up for it, you can reply to this email and
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-ios/pull/144
CB-9116 Ensure platform scripts are executable as the platform could be
added on non-OSX environment
Corresponding [Jira issue](https://issues.apache.org/jira/browse/CB-9116)
You can merge
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/144#discussion_r31713805
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -87,6 +87,13 @@ module.exports.run = function (argv) {
}
return
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/144#discussion_r31719008
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -87,6 +87,13 @@ module.exports.run = function (argv) {
}
return
12 matches
Mail list logo
