Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r74154432
--- Diff: tests/spec/unit/podMod.spec.js ---
@@ -0,0 +1,107 @@
+var fs = require('fs'),
+ path = require('path'),
+ cordova = require(
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r73970701
--- Diff: tests/spec/unit/podMod.spec.js ---
@@ -0,0 +1,107 @@
+var fs = require('fs'),
+ path = require('path'),
+ cordova = require(path
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r73970418
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs'),
+path = require('path'),
+util =
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r73966499
--- Diff: tests/spec/unit/podMod.spec.js ---
@@ -0,0 +1,107 @@
+var fs = require('fs'),
+ path = require('path'),
+ cordova = require(path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r72683673
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +94,31 @@ var handlers = {
}
},
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70545166
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var eve
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70541974
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var eve
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70541767
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var eve
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70534998
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -66,17 +66,19 @@ var handlers = {
install:function(obj, plug
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70534885
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70526583
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var eve
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70507754
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70507813
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* Cord
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70496395
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
Github user juliascript commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r70491773
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69511105
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505602
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505429
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaE
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505374
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69505064
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504887
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504867
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504824
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504742
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -66,17 +66,19 @@ var handlers = {
install:function(obj, plugin,
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504623
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaE
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504527
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
retu
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504555
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
retu
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69504477
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
retu
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r69364995
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
}
},
GitHub user juliascript opened a pull request:
https://github.com/apache/cordova-ios/pull/234
CB-9825 cocoapod integration for plugins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juliascript/cordova-ios CB-9825
Alternatively
31 matches
Mail list logo