[GitHub] cordova-lib pull request #563: Cb 11713 11961

2017-06-13 Thread goya
GitHub user goya opened a pull request: https://github.com/apache/cordova-lib/pull/563 Cb 11713 11961 ### Platforms affected N/A ### What does this PR do? Fixes for the following issues: CB-11961 do a shallow clone if git_ref is a remote ref

[GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...

2017-06-12 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-lib/pull/562 Removing lazy load, platform command refactor, start of finer-grained unit tests. ### Platforms affected all / node ? ### What does this PR do? A lot! 1.

[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...

2017-06-05 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/561 Cb 12870 - Check that all use cases are caught in Api.js Not ready for review yet, still updating tests. Thanks! ### Platforms affected ### What does this PR do?

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

2017-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

2017-06-05 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r120073277 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -

[GitHub] cordova-lib pull request #533: CB-12250 CB-12409 iOS: Fix bug with escaping ...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

2017-06-02 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r119971709 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -//If

[GitHub] cordova-lib pull request #560: CB-12762 : point package.json repo items to g...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #556: CB-12777 : Removed unneeded fixtures in cordo...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #559: Display deprecation message when installing a...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #557: CB-12787: Fix plugin installation with --link...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

2017-06-02 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r119950730 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -//If

[GitHub] cordova-lib pull request #554: CB-12738: Cordova ignores plugin dependency v...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #558: CB-12766 Consistently write JSON with 2 space...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #560: CB-12762 : point package.json repo items to g...

2017-06-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/560 CB-12762 : point package.json repo items to github mirrors instead of… … apache repos site ### Platforms affected ### What does this PR do? Point

[GitHub] cordova-lib pull request #559: Display deprecation message when installing a...

2017-05-17 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/559 Display deprecation message when installing a platform with version lower than api compatible ### Platforms affected all ### What does this PR do? Repro

[GitHub] cordova-lib pull request #558: CB-12766 Consistently write JSON with 2 space...

2017-05-16 Thread remcohaszing
GitHub user remcohaszing opened a pull request: https://github.com/apache/cordova-lib/pull/558 CB-12766 Consistently write JSON with 2 spaces indentation ### Platforms affected None really. ### What does this PR do? JSON was written with 4 spaces indentation and

[GitHub] cordova-lib pull request #557: CB-12787: Fix plugin installation with --link...

2017-05-12 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/557 CB-12787: Fix plugin installation with --link option ### Platforms affected all ### What does this PR do? Fix logic for installation plugins with `--link`

[GitHub] cordova-lib pull request #556: CB-12777 : Removed unneeded fixtures in cordo...

2017-05-10 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/556 CB-12777 : Removed unneeded fixtures in cordova-lib ### Platforms affected ### What does this PR do? Removed unneeded fixtures in cordova-lib. ### What

[GitHub] cordova-lib pull request #555: Improve logic for searching plugin id in case...

2017-05-10 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/555 Improve logic for searching plugin id in case of module already exists in node_modules ### Platforms affected all ### What does this PR do? Steps

[GitHub] cordova-lib pull request #554: CB-12738: Cordova ignores plugin dependency v...

2017-05-10 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/554 CB-12738: Cordova ignores plugin dependency version on windows platform ### Platforms affected windows ### What does this PR do? Steps to reproduce w\

[GitHub] cordova-lib pull request #553: CB-12773: fixed incorrect plugin version fetc...

2017-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #553: CB-12773: fixed incorrect plugin version fetc...

2017-05-09 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/553 CB-12773: fixed incorrect plugin version fetching issue ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

[GitHub] cordova-lib pull request #552: CB-12757 : Was previously saving wrong spec i...

2017-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #552: CB-12757 : Was previously saving wrong spec i...

2017-05-05 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/552#discussion_r115030625 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -205,8 +205,29 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request #552: CB-12757 : Was previously saving wrong spec i...

2017-05-05 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/552#discussion_r114960540 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -205,8 +205,29 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request #552: CB-12757 : Was previously saving wrong spec i...

2017-05-04 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/552 CB-12757 : Was previously saving wrong spec in config.xml for git plugins. ### Platforms affected ### What does this PR do? Was previously saving wrong

[GitHub] cordova-lib pull request #549: CB-12705: Pass plugin info to project-level p...

2017-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #550: CB-11242

2017-05-01 Thread audreyso
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...

2017-05-01 Thread audreyso
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #551: CB-11242: dropped support for older android, ...

2017-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #551: CB-11242: dropped support for older android, ...

2017-04-29 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/551 CB-11242: dropped support for older android, windows, osx, ios platforms Older android, windows, osx & ios platforms that don't have API.js won't work with the next version of cordova.

[GitHub] cordova-lib pull request #550: CB-11242

2017-04-27 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/550 CB-11242 Not ready for review yet. :) ### Platforms affected ### What does this PR do? The platform-specific code for platforms w/ PlatformApi implemented

[GitHub] cordova-lib pull request #549: CB-12705: Pass plugin info to project-level p...

2017-04-26 Thread feichngr
Github user feichngr commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/549#discussion_r113615881 --- Diff: cordova-lib/src/hooks/HooksRunner.js --- @@ -178,7 +178,9 @@ function runScriptViaModuleLoader(script, context) { } var

[GitHub] cordova-lib pull request #549: CB-12705: Pass plugin info to project-level p...

2017-04-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/549#discussion_r113586243 --- Diff: cordova-lib/src/hooks/HooksRunner.js --- @@ -178,7 +178,9 @@ function runScriptViaModuleLoader(script, context) { } var

[GitHub] cordova-lib pull request #545: CB-12361: starting to seperate integration te...

2017-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #549: CB-12705: Pass plugin info to project-level p...

2017-04-26 Thread feichngr
GitHub user feichngr opened a pull request: https://github.com/apache/cordova-lib/pull/549 CB-12705: Pass plugin info to project-level plugin hooks ### Platforms affected Cordova-cli and maybe plugman ### What does this PR do? Makes sure plugin information is passed

[GitHub] cordova-lib pull request #547: CB-8978: Add option to get resource-file from...

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #542: CB-12663: Install latest version of plugin in...

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #548: CB-12683: improved error messaging for when a...

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #548: CB-12683: improved error messaging for when a...

2017-04-21 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/548 CB-12683: improved error messaging for when a plugin doesn't have pac… …kage.json ### Platforms affected ### What does this PR do? ### What

[GitHub] cordova-lib pull request #547: CB-8978: Add option to get resource-file from...

2017-04-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/547 CB-8978: Add option to get resource-file from root Step 1 of resolving the first issue mentioned in https://github.com/apache/cordova-android/pull/321#issuecomment-294985346 Step 2 will be

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

2017-04-20 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/538#discussion_r112554925 --- Diff: cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js --- @@ -39,14 +39,14 @@ module.exports.createProject =

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

2017-04-20 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/538#discussion_r112542525 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -408,6 +409,8 @@ function getPlatformDetailsFromDir(dir, platformIfKnown){ var

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

2017-04-20 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/538#discussion_r112542652 --- Diff: cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js --- @@ -39,14 +39,14 @@ module.exports.createProject =

[GitHub] cordova-lib pull request #541: Exit with exitCode:1 if a plugin could not be...

2017-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #546: CB-12674 : Added deprecation notice for black...

2017-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #546: CB-12674 : Added deprecation notice for black...

2017-04-19 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/546 CB-12674 : Added deprecation notice for blackberry10 and ubuntu ### Platforms affected ### What does this PR do? Added deprecation notice for blackberry10 and

[GitHub] cordova-lib pull request #537: CB-11908: Add tests for edit-config in config...

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #508: CB-11908 Add tests for edit-config in config....

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #487: CB-11777: Restore plugins before preparing

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #539: CB-12643 : removed references to wp8

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #540: CB-12645 : removed references to firefoxos

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #544: CB-12665 : removed engineStrict as it is no l...

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #545: CB-12361: starting to seperate integration te...

2017-04-19 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/545 CB-12361: starting to seperate integration tests, writing new unit te… …sts for platform.js Still need to add more unit tests before replacing platform.spec.js. ###

[GitHub] cordova-lib pull request #544: CB-12665 : removed engineStrict as it is no l...

2017-04-17 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/544 CB-12665 : removed engineStrict as it is no longer supported ### Platforms affected ### What does this PR do? Removed engineStrict as it is no longer

[GitHub] cordova-lib pull request #543: CB-12662 - update cordova-common dependency t...

2017-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #543: CB-12662 - update cordova-common dependency t...

2017-04-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/543 CB-12662 - update cordova-common dependency to 2.0.2 ### Platforms affected All. ### What does this PR do? Update the cordova-common dep in cordova-lib and

[GitHub] cordova-lib pull request #542: Install latest version of plugin in case of u...

2017-04-17 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/542 Install latest version of plugin in case of using dev cordova version ### What does this PR do? Semver couldn't verify if cordova version with prerelease tag

[GitHub] cordova-lib pull request #541: Exit with exitCode:1 if a plugin could not be...

2017-04-11 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/541 Exit with exitCode:1 if a plugin could not be restored from config.xml ### Platforms affected lib ### What does this PR do? see description ### What

[GitHub] cordova-lib pull request #540: CB-12645 : removed references to firefoxos

2017-04-07 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/540 CB-12645 : removed references to firefoxos ### Platforms affected ### What does this PR do? Removed references to firefoxos. ### What testing has been done

[GitHub] cordova-lib pull request #539: CB-12643 : removed references to wp8

2017-04-06 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/539 CB-12643 : removed references to wp8 ### Platforms affected ### What does this PR do? Removed references to wp8. ### What testing has been done on

[GitHub] cordova-lib pull request #538: Emit platformAPI loading error, remove Gradle...

2017-04-05 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/538 Emit platformAPI loading error, remove GradleBuilder and Browser crea… …te console logs ### Platforms affected ### What does this PR do?

[GitHub] cordova-lib pull request #537: CB-11908: Add tests for edit-config in config...

2017-04-05 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/537 CB-11908: Add tests for edit-config in config.xml, fix typo, and rebased. Add one more test case ### Platforms affected ### What does this PR do? Rebased

[GitHub] cordova-lib pull request #532: CB-12612 : removing amazon-fireos code

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/536#discussion_r109758738 --- Diff: cordova-lib/src/cordova/platform_metadata.js --- @@ -8,7 +8,7 @@ with the License. You may obtain a copy of the License at

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/536#discussion_r109752953 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -154,8 +154,9 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts) {

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/536#discussion_r109752493 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -125,7 +125,7 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts) {

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/536#discussion_r109757692 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -410,11 +409,10 @@ function getPlatformDetailsFromDir(dir, platformIfKnown){ try

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/536#discussion_r109752110 --- Diff: cordova-lib/src/cordova/package_manager.js --- @@ -0,0 +1,37 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-03 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/536#discussion_r109532730 --- Diff: cordova-lib/src/cordova/metadata/ubuntu_parser.js --- @@ -109,8 +110,8 @@ ubuntu_parser.prototype.update_manifest = function() {

[GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete require.ca...

2017-04-03 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/536 CB-12592 : Refactor and add delete require.cache to cordova_util and create packageManager to load and save files. ### Platforms affected ### What does this PR do?

[GitHub] cordova-lib pull request #:

2017-04-03 Thread audreyso
Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/f8bce61c99c8c57bd3ba3ca348587d0edd962dfe#commitcomment-21610563 In cordova-lib/src/cordova/metadata/ubuntu_parser.js: In cordova-lib/src/cordova/metadata/ubuntu_parser.js on line 113:

[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...

2017-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...

2017-03-31 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...

2017-03-31 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-lib/pull/535 CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-31 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support the

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-29 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108751887 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108737235 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #533: CB-12250 CB-12409 iOS: Fix bug with escaping ...

2017-03-29 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/533 CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file ### Platforms affected iOS ### What does this PR do? This PR fixes some bugs with

[GitHub] cordova-lib pull request #532: CB-12612 : removing amazon-fireos code

2017-03-28 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/532 CB-12612 : removing amazon-fireos code Not ready for review yet :) ### Platforms affected ### What does this PR do? Removing amazon-fireos code

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-28 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108492723 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-28 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108489174 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-28 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108485285 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #531: CB-12606 Fix plugin dependency installation

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-27 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108229542 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #531: CB-12606 Fix plugin dependency installation

2017-03-27 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-lib/pull/531 CB-12606 Fix plugin dependency installation ### Platforms affected all ### What does this PR do? Fixes a problem described here:

[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...

2017-03-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/526#discussion_r108041118 --- Diff: cordova-lib/spec-cordova/fixtures/projects/platformApi/platforms/android/.gitignore --- @@ -0,0 +1,14 @@ +# Non-project-specific

[GitHub] cordova-lib pull request #526: CB-11242 - Removed platform-specific code for...

2017-03-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/526#discussion_r108041377 --- Diff: cordova-lib/src/platforms/platformsConfig.json --- @@ -11,15 +9,12 @@ "osx": { "hostos": ["darwin"],

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #514: CB-12337 Resolve symbolic links in project ro...

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-24 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108009704 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-24 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108009309 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {

<    1   2   3   4   5   6   7   8   9   10   >