[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-10 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95499196 --- Diff: cordova-common/spec/CordovaCheck.spec.js --- @@ -30,71 +30,62 @@ describe('findProjectRoot method', function() {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-10 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95500742 --- Diff: cordova-lib/spec-cordova/plugin.spec.js --- @@ -178,11 +185,14 @@ describe('plugin end-to-end', function() { .then(function ()

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-10 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95501615 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -206,134 +178,136 @@ describe('install', function() { beforeEach(function() {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-10 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95500695 --- Diff: cordova-lib/spec-cordova/plugin.spec.js --- @@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-10 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95502042 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -121,7 +131,8 @@ beforeEach(function () { });

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-10 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95500869 --- Diff: cordova-lib/spec-cordova/plugin.spec.js --- @@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {

[GitHub] cordova-lib pull request #514: CB-12337 Resolve symbolic links in project ro...

2017-01-09 Thread sryze
GitHub user sryze opened a pull request: https://github.com/apache/cordova-lib/pull/514 CB-12337 Resolve symbolic links in project root ### Platforms affected All? ### What does this PR do? If project path had symlinks its absolute value was different from that

[GitHub] cordova-lib pull request #509: CB-12163 Add reference attrib to resource-fil...

2017-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #505: Move windows-specific logic to cordova-window...

2017-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/505 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #511: CB-12261: Fix subdirectories deprecated warni...

2017-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...

2017-01-03 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-lib/pull/469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #399: CB-10034 Addresses Embedded/Linked/Signed Cus...

2016-12-29 Thread cusspvz
Github user cusspvz commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/399#discussion_r94165725 --- Diff: cordova-lib/package.json --- @@ -40,7 +40,7 @@ "underscore": "1.7.0", "unorm": "1.3.3",

[GitHub] cordova-lib pull request #513: CB-12189 windows: Add `implementation` attrib...

2016-12-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #512: CB-12284 Include project root as additional r...

2016-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93506823 --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js --- @@ -301,14 +301,8 @@ describe('ios project handler', function() { });

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93502548 --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js --- @@ -301,14 +301,8 @@ describe('ios project handler', function() { });

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93493946 --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js --- @@ -301,14 +301,8 @@ describe('ios project handler', function() { });

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93490653 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -50,18 +50,30 @@ function copyArray(arr) { } beforeEach(function

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93492375 --- Diff: cordova-lib/spec-plugman/platforms/wp8.spec.js --- @@ -113,22 +113,21 @@ describe('wp8 project handler', function() {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93492132 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -50,18 +50,30 @@ function copyArray(arr) { } beforeEach(function

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93490510 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -50,18 +50,30 @@ function copyArray(arr) { } beforeEach(function

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93490083 --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js --- @@ -301,14 +301,8 @@ describe('ios project handler', function() { });

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93492030 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -50,18 +50,30 @@ function copyArray(arr) { } beforeEach(function

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93491307 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -50,18 +50,30 @@ function copyArray(arr) { } beforeEach(function

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r93491264 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -50,18 +50,30 @@ function copyArray(arr) { } beforeEach(function

[GitHub] cordova-lib pull request #513: CB-12189 windows: Add `implementation` attrib...

2016-12-21 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/513 CB-12189 windows: Add `implementation` attribute to frameworks The attribute is windows-specific and allows to specify implementation for WinMD components, written in C++

[GitHub] cordova-lib pull request #512: CB-12284 Include project root as additional r...

2016-12-20 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/512 CB-12284 Include project root as additional root for static router ### Platforms affected All ### What does this PR do? With this change, cordova-serve includes the project

[GitHub] cordova-lib pull request #511: CB-12261: Fix subdirectories deprecated warni...

2016-12-16 Thread yyfearth
GitHub user yyfearth opened a pull request: https://github.com/apache/cordova-lib/pull/511 CB-12261: Fix subdirectories deprecated warning always shows and stop fetch for… ### Platforms affected All ### What does this PR do? Fix the issue created by CB-11979, the

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-16 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92903756 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -345,13 +344,14 @@ describe('install', function() { it('should not check

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-16 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92901285 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -345,13 +344,14 @@ describe('install', function() { it('should not check

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-16 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92901030 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -345,13 +344,14 @@ describe('install', function() { it('should not check

[GitHub] cordova-lib pull request #:

2016-12-16 Thread yyfearth
Github user yyfearth commented on the pull request: https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20221128 In cordova-lib/src/plugman/fetch.js: In cordova-lib/src/plugman/fetch.js on line 72: it will always trigger since

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92756760 --- Diff: cordova-lib/spec-cordova/helpers.js --- @@ -148,7 +148,7 @@ module.exports.writeConfigContent = function (appPath, configContent) {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92713582 --- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js --- @@ -472,7 +472,7 @@ describe('HooksRunner', function() {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92707789 --- Diff: cordova-lib/package.json --- @@ -20,15 +20,16 @@ "dependencies": { "aliasify": "^1.7.2", "cordova-common": "1.5.x",

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92707699 --- Diff: cordova-common/package.json --- @@ -28,6 +28,7 @@ "cordova-registry-mapper": "^1.1.8", "elementtree": "^0.1.6",

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-15 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92707427 --- Diff: cordova-lib/spec-cordova/build.spec.js --- @@ -67,7 +67,7 @@ describe('build command', function() { describe('success', function() {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-14 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92480797 --- Diff: cordova-lib/spec-cordova/lazy_load.spec.js --- @@ -34,8 +34,8 @@ var lazy_load = require('../src/cordova/lazy_load'), describe('lazy_load

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-14 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92480348 --- Diff: cordova-common/spec/CordovaCheck.spec.js --- @@ -30,11 +30,12 @@ describe('findProjectRoot method', function() { process.env.PWD

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/510 Fixjasmine : CB:12018 - updating tests in cordova-lib to use jasmine instead of jasmine-node ### Platforms affected ### What does this PR do? ### What

[GitHub] cordova-lib pull request #507: CB-12197 : replaced/removed multiple occuranc...

2016-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #509: CB-12163 Add reference attrib to resource-fil...

2016-12-13 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/509 CB-12163 Add reference attrib to resource-file for Windows ### Platforms affected cordova-common for Windows ### What does this PR do? Adds a new attribute to the

[GitHub] cordova-lib pull request #508: CB-11908 Add tests for edit-config in config....

2016-12-13 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/508 CB-11908 Add tests for edit-config in config.xml and fix typo ### Platforms affected cordova-common ### What does this PR do? I had this commit ready to go, but forgot

[GitHub] cordova-lib pull request #:

2016-12-09 Thread luissilvaos
Github user luissilvaos commented on the pull request: https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20134722 Hi, This is preventing me from install a plugin with a git-ref without subdirectories. Example:

[GitHub] cordova-lib pull request #507: CB-12197 : replaced/removed multiple occuranc...

2016-12-02 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/507 CB-12197 : replaced/removed multiple occurances of Anis and Brett ### Platforms affected cordova-common and cordova-lib ### What does this PR do? Removed multiple

[GitHub] cordova-lib pull request #:

2016-11-28 Thread audreyso
Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/fbedd9e67f5a631404079b28e3def489cd07b129#commitcomment-19987410 In cordova-lib/src/cordova/platform.js: In cordova-lib/src/cordova/platform.js on line 121: hey @stevengill ... can

[GitHub] cordova-lib pull request #:

2016-11-28 Thread audreyso
Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/fbedd9e67f5a631404079b28e3def489cd07b129#commitcomment-19987344 In cordova-lib/spec-cordova/pkgJson.spec.js: In cordova-lib/spec-cordova/pkgJson.spec.js on line 28: fixed this typo

[GitHub] cordova-lib pull request #:

2016-11-28 Thread audreyso
Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/fbedd9e67f5a631404079b28e3def489cd07b129#commitcomment-19987342 In cordova-lib/spec-cordova/pkgJson.spec.js: In cordova-lib/spec-cordova/pkgJson.spec.js on line 228: fixed this

[GitHub] cordova-lib pull request #499: Cb 11960

2016-11-18 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r88704297 --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js --- @@ -414,6 +414,80 @@ describe('tests platform/spec restore with --save', function () {

[GitHub] cordova-lib pull request #506: CB-12088 Fix misleading warning when adding p...

2016-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #:

2016-11-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19645027 Yup, thanks for confirmation. Sent a PR to fix this warning, see #506 --- If your project is set up for it, you

[GitHub] cordova-lib pull request #506: CB-12088 Fix misleading warning when adding p...

2016-11-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/506 CB-12088 Fix misleading warning when adding platform without Api.js ### Platforms affected All ### What does this PR do? Changes the logic that emits warning when

[GitHub] cordova-lib pull request #:

2016-11-01 Thread imhotep
Github user imhotep commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19644659 @vladimir-kotikov I think you got that right. There should be an error message when api is incompatible and a different

[GitHub] cordova-lib pull request #:

2016-10-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19630108 I'm not sure but there might be a logical error - we probably should not tell user that there was an error when

[GitHub] cordova-lib pull request #:

2016-10-31 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19629338 Ah, thanks, so I can close the issue and say that this is only a warning? --- If your project is set up for it, you

[GitHub] cordova-lib pull request #:

2016-10-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19628472 > Is this a bug or browser platform always went to the catch before? Yep, the latter. `catch` here is to

[GitHub] cordova-lib pull request #:

2016-10-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19625463 I'm seeing this warning when adding browser platform on CLI 6.4.0, but browser platform seems to work fine. An user

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85018233 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999160 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85015269 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012246 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85014503 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012170 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010504 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85013772 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85018072 --- Diff: cordova-lib/spec-cordova/pkgJson.spec.js --- @@ -0,0 +1,348 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011439 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r8503 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011190 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010911 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85015289 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012879 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010828 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85012532 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011010 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999093 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85015369 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011274 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010510 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010529 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85001497 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85010730 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85011104 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84996266 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84996343 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84994538 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84994925 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85001631 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85000290 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999753 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84995508 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85002184 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999589 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85002357 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85001447 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997203 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84999210 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84995973 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r85002140 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84995444 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

<    1   2   3   4   5   6   7   8   9   10   >