[GitHub] cordova-lib pull request: Improving prepare and build output

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218911859 @stevengill done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218910842 Passed! Lets merge this in @riknoll :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218906307 Travis taking forever On Thu, May 12, 2016 at 2:34 PM, Richard Knoll wrote: > I'll merge whenever the Travis

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218892839 I'll merge whenever the Travis build finishes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218892010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218885704 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/439#discussion_r63097000 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -286,7 +286,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/439#discussion_r63092520 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -286,7 +286,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-218824969 @stevengill it was working pretty good last I checked. With the config.xml stuff in it should be ready to go. I've earmarked some time tomorrow to do my testing.

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218672448 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-10621 fix for amazon-fireos

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/390#issuecomment-218649503 Amazon-fireos has actually been deprecated. It is recommended to target the android platform instead when releasing for amazon --- If your project is set up

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/236#issuecomment-218633214 I'd like to revive this PR. Hooks should run when using create scripts + plugman. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/236#discussion_r62952050 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -283,7 +283,7 @@ function runUninstallPlatform(actions, platform, project_dir, plugin_dir,

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218624176 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Improving prepare and build output

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/439#discussion_r62946762 --- Diff: cordova-lib/src/hooks/HooksRunner.js --- @@ -141,6 +144,23 @@ function runScript(script, context) { // we assume we should use

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-218623029 How close is this to being able to merge in? @macdonst --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: Improving prepare and build output

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/439 Improving prepare and build output The purpose of this PR is to improve the quality and clarity of our logging (including verbose). Some things I tried to improve: * Consistency of

[GitHub] cordova-lib pull request: CB-11200 Bump xcode dependency and updat...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request:

Github user qkdreyer commented on the pull request: https://github.com/apache/cordova-lib/commit/0c61fb097d5f6a317560adbb2165ff916642c5c7#commitcomment-17433959 In cordova-lib/src/cordova/restore-util.js: In cordova-lib/src/cordova/restore-util.js on line 117:

[GitHub] cordova-lib pull request:

Github user qkdreyer commented on the pull request: https://github.com/apache/cordova-lib/commit/0c61fb097d5f6a317560adbb2165ff916642c5c7#commitcomment-17433806 In cordova-lib/src/cordova/restore-util.js: In cordova-lib/src/cordova/restore-util.js on line 117: If pluginSpec

[GitHub] cordova-lib pull request: CB-11200 Bump xcode dependency and updat...

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/437#issuecomment-218113832 ## [Current coverage][cc-pull] is **80.59%** > Merging [#437][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-lib pull request: CB-10034 Addresses Embedded/Linked/Signe...

Github user robertoandrade commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/399#discussion_r62616494 --- Diff: cordova-lib/package.json --- @@ -40,7 +40,7 @@ "underscore": "1.7.0", "unorm": "1.3.3",

[GitHub] cordova-lib pull request: CB-10034 Addresses Embedded/Linked/Signe...

Github user robertoandrade commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/399#discussion_r62616280 --- Diff: cordova-lib/package.json --- @@ -40,7 +40,7 @@ "underscore": "1.7.0", "unorm": "1.3.3",

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/407 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-21866 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/438 Fix plugin platform_www & cordova_plugins.json copy You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-11200 Bump xcode dependency and updat...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/437 CB-11200 Bump xcode dependency and update tests to pass You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217521367 Ok. I've created an issue to track it here: https://issues.apache.org/jira/browse/CB-11219 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217513174 @omefire you are correct. That flag seems to be totally broken --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217510255 (Though not related to this change) it seems like the ```--force``` flag wouldn't work as advertised ? --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217510027 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217507586 ## [Current coverage][cc-pull] is **80.71%** > Merging [#436][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/436 CB-11134: Removing duplicated warning You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-11134 Alternatively you

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-217283363 Great! Thanks @jasongin! Merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-217281613 As discussed, I tested this with symbolic links both at the root and in a subdirectory. It works fine without any special symlink handling in the code. --- If

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62252220 --- Diff: cordova-common/src/superspawn.js --- @@ -22,20 +22,20 @@ var fs = require('fs'); var path = require('path'); var _ =

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/434#issuecomment-217265794 Looking to merge this by EOD today if there are no other concerns. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62247519 --- Diff: cordova-lib/cordova-lib.js --- @@ -18,19 +18,35 @@ */ // For now expose plugman and cordova just as they were in the old repos

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-217236642 @nikhilkh waiting on you. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-217228255 @ktop thanks for the hint about running `cordova-coho/coho npm-link`. Once I did I was able to get your code to run. It seems to be working pretty good to me. So

[GitHub] cordova-lib pull request: Disable e2e to decrease coverage

Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: Disable e2e to decrease coverage

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/435 Disable e2e to decrease coverage You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-lib disable_e2e

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-217091665 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-217087853 Made the changes. LMK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62104877 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- Hmm. Maybe just name it differently. My

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62101897 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- I just copy it into temporary tests folder so I can

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100822 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100600 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/434#issuecomment-216933920 ## [Current coverage][cc-pull] is **80.71%** > Merging [#434][cc-pull] into [master][cc-base-branch] will increase coverage by **+1.09%** ```diff

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62068625 --- Diff: cordova-lib/cordova-lib.js --- @@ -18,19 +18,35 @@ */ // For now expose plugman and cordova just as they were in the old repos

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62000656 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r61999817 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- Do we need a separate `package.json` for

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r61998473 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r61998292 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-216691951 Hey Everyone, I think the first implementation of this is ready to hit master behind the --fetch flag. It includes platform and plugin fetching +

[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216629805 @macdonst @purplecabbage On my other machine (Mac), I see the same behavior that you both were seeing. I was able to fix it by doing a `cordova-coho/coho

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216628696 Okay, thanks for clarifying. I rescind my objection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216624907 If you're talking about a source file, then that would change the last-modified timestamp of the source file, causing it to be newer than the target file so it

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216619728 Is it possible that a change to a file without affecting file size could go undetected? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216618237 BTW, I didn't mention above the reason I had to abandon the approach of checking for exactly-equal modified times. The problem is the OS X filesystem doesn't

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216617718 @purplecabbage If a hook fails because it expected a file would be refreshed but it wasn't, then I'd expect the hook to print an error (or stack trace), so that

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216611405 All right, I think this is the best we can do. The latest logic copies the file if the source's last-modified time is >= the target's last-modified time, or if

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216614096 I would not consider that contrived. This would be an extremely tough issue to find if it happened. --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61922956 --- Diff: cordova-common/src/ConfigChanges/ConfigFile.js --- @@ -17,13 +17,30 @@ var fs = require('fs'); var path = require('path');

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61917593 --- Diff: cordova-common/cordova-common.js --- @@ -17,26 +17,40 @@ under the License. */ -exports = module.exports = { -

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61917144 --- Diff: cordova-common/src/superspawn.js --- @@ -22,7 +22,7 @@ var fs = require('fs'); var path = require('path'); var _ =

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61915826 --- Diff: cordova-common/src/superspawn.js --- @@ -22,7 +22,7 @@ var fs = require('fs'); var path = require('path'); var _ =

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61915398 --- Diff: cordova-lib/src/platforms/PlatformApiPoly.js --- @@ -474,7 +473,12 @@ function getCreateArgs(destinationDir, projectConfig, options) {

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61914375 --- Diff: cordova-common/src/ConfigChanges/ConfigFile.js --- @@ -17,13 +17,30 @@ var fs = require('fs'); var path = require('path');

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61913509 --- Diff: cordova-common/src/superspawn.js --- @@ -22,7 +22,7 @@ var fs = require('fs'); var path = require('path'); var _ =

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61913318 --- Diff: cordova-common/src/ConfigChanges/ConfigFile.js --- @@ -17,13 +17,30 @@ var fs = require('fs'); var path = require('path');

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61913141 --- Diff: cordova-common/cordova-common.js --- @@ -17,26 +17,40 @@ under the License. */ -exports = module.exports = { -

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61912923 --- Diff: cordova-common/cordova-common.js --- @@ -17,26 +17,40 @@ under the License. */ -exports = module.exports = { -

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61912394 --- Diff: cordova-common/cordova-common.js --- @@ -17,26 +17,40 @@ under the License. */ -exports = module.exports = { -

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61912274 --- Diff: cordova-common/cordova-common.js --- @@ -3,7 +3,7 @@ or more contributor license agreements. See the NOTICE file

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216585668 Well, after further testing I found creation dates don't work reliably due to some strange behavior on Windows:

[GitHub] cordova-lib pull request: CB-11194 Improve cordova load time

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-lib/pull/434 CB-11194 Improve cordova load time I instrumented module load and this change improves our load time by ~50% (300+ ms) for `cordova build android` on a hello world project. Biggest gains are

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216543951 @purplecabbage My workspace is working off of the master branches with the tools npm linked. I modified the plugin.xml of cordova-plugin-device and

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216424469 @ktop Can you provide the steps you used to verify that this is working please? What I did was create a new project, and added the

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216386608 I too am seeing @macdonst 's issue. ``` ... ``` --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216319068 I updated the PR to use target creation times instead of modified-times. It works much better: it doesn't require the messy workaround on Windows and doesn't have

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/429#discussion_r61665459 --- Diff: cordova-common/src/FileUpdater.js --- @@ -0,0 +1,499 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/433#issuecomment-215922979 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-215918679 ## [Current coverage][cc-pull] is **13.19%** > Merging [#407][cc-pull] into [master][cc-base-branch] will increase coverage by **-86.81%** ```diff

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464 @ktop @riknoll yeah, config.xml should be part of this. Anything in config.xml should trump whatever is specified in the plugin.xml. If we do modes then default

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/429#discussion_r61659743 --- Diff: cordova-common/src/FileUpdater.js --- @@ -0,0 +1,499 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215911697 @nikhilkh As we discussed, this workaround was the best I could find. The command script approach has similar performance to just copying files via the node fs

[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/433#discussion_r61655336 --- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js --- @@ -17,19 +17,25 @@ under the License. */ +var fs =

[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/433#issuecomment-215898416 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/433#discussion_r61653369 --- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js --- @@ -17,19 +17,25 @@ under the License. */ +var fs =

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215892244 I would put the mode flag as out-of-scope for now, we can re-asses later if need be. I could not get this to work, can you please post instructions

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215866756 @ktop config-file wasn't in config.xml before, but we wanted to add it because the number of config.xml attributes that just edit various native xml files is

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823 @macdonst I had Edna test the first time around before I opened the PR and she was able to get it working, so that is weird that it is adding a new element for

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215817627 Simultaneously, lets ask libuv to make the fix for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on

<    3   4   5   6   7   8   9   10   11   12   >