GitHub user kamrik opened a pull request:
https://github.com/apache/cordova-lib/pull/183
CB-8595 Merge platforms.js from cordova & plugman CB-8595
Till now we had two separate places for platform specific code
cordova/metadata exposed via cordova/platforms.js
plugman/platform
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26213790
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214063
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214642
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215186
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215310
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215219
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -293,58 +293,25 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215211
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26218471
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -293,58 +293,25 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26218885
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26224327
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26233744
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214059
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/183#issuecomment-78635997
Addressed the comments and merged as a single squashed commit.
Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have yo
15 matches
Mail list logo
