Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/194#issuecomment-86971194
Thanks, merging.
Tests pass ok. Appveyor or GitHub were flaky for the last couple of days.
---
If your project is set up for it, you can reply to this email and h
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/194#issuecomment-86962408
Thanks Andrew. Changes made!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/194#discussion_r27299568
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -0,0 +1,76 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or mor
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/194#discussion_r27298469
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -223,11 +211,13 @@ module.exports = {
* @param {Boolean} determines if we are using
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/194#issuecomment-86956650
Nice clean-up! Let me know when comments are addressed and I'll merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/194#discussion_r27298165
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -223,11 +211,13 @@ module.exports = {
* @param {Boolean} determines if we are using th
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/194#discussion_r27298069
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -0,0 +1,76 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/194#issuecomment-86940734
AppVeyor failed because it couldn't connect to github (a problem I was
having today too) - is there a way to kickstart it going again?
---
If your project is set
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/194
CB-8754 Auto-restoring a plugin fails when adding a platform.
Start with a blank Cordova app, then enter the following:
cordova plugin add org.apache.cordova.camera --save
10 matches
Mail list logo
