Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-lib/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-114060806
Closing this since the PlatformApi needs for more detailed design. The
discussion is moved to cordova/cordova-discuss#9
---
If your project is set up for
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-58775
Since you've already ported the android implementation from cordova-lib to
cordova-android, shouldn't you delete the android parser file from the metadata
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32236650
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,414 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-84250
cool. (ref: android_parser backward compatibility).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32236936
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,414 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-111213610
Ah, I see. (ref: android_parser backward compatibility).
However, in case a platform is implemented via the new way, shouldn't we be
actually using that ?
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32246260
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,414 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32198647
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-70935
`android_parser` is left for backward compatibility, since user can install
older version of cordova-android, which doesn't provides own `PlatformAPI`. In
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32148857
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32169661
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-110955660
It will help to generate API docs for the public API surface now. Reviewing
the implementation guts and the API in code is not easy. In any case, the
platform API
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32181585
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32181523
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-110155367
I don't have strong opinion here, but a bit more inclined towards
dependency injection. For some modules like ConfigParser having different
versions imported by
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r31924092
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-110038030
@kamrik, thanks for feedback.
Dependency injection of cordova logic to platform was our very first idea,
but in addition to limitations, you
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r31840378
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-109401910
Looks great! The need to duplicate common code like ConfgiParser in
cordova-android is a bit annoying and is bound to generate some versioning
confusion. But
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/235
Implementation for Unified platform API
An mplementation of Unified Platform API for cordova, that inspired by
[this thread](http://markmail.org/thread/3dw4mis4qo5d4ecz) in
21 matches
Mail list logo
