[GitHub] cordova-lib pull request #600: CB-13478 : Fix CRLF line endings and lint int...

2017-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/600 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #603: CB-12361 : added unit tests for check.js

2017-10-27 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/603 CB-12361 : added unit tests for check.js ### Platforms affected ### What does this PR do? Added unit tests for check.js to increase coverage ### What

[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/602#discussion_r147014589 --- Diff: src/cordova/util.js --- @@ -255,11 +255,20 @@ function findPlugins (pluginDir) { var plugins = []; if

[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread akdor1154
Github user akdor1154 commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/602#discussion_r147012928 --- Diff: src/cordova/util.js --- @@ -255,11 +255,20 @@ function findPlugins (pluginDir) { var plugins = []; if

[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/602#discussion_r147012615 --- Diff: src/cordova/util.js --- @@ -255,11 +255,20 @@ function findPlugins (pluginDir) { var plugins = []; if

[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/599 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-23 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/602 CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. In order to get plugins that are under an npm scope (e.g. `@akdor1154/some-plugin`) to install, a previous change from

[GitHub] cordova-lib pull request #601: CB-13485: Test with Node8

2017-10-23 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/601 CB-13485: Test with Node8 ### What does this PR do? Enables testing on Node 8 with Travis, and fixes the failing tests (no behaviour changes seem necessary). ### What testing

[GitHub] cordova-lib pull request #600: CB-13478 : Fix CRLF line endings and lint int...

2017-10-20 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/600 CB-13478 : Fix CRLF line endings and lint integration tests. ### Platforms affected N/A ### What does this PR do? - Change CRLFs to LFs - Configures eslint to

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/597 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...

2017-10-20 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/599 CB-13463 : prevent package.json update with --nosave (for plugins) ### Platforms affected ### What does this PR do? Prevent package.json update with --nosave

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-20 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/597#discussion_r146039059 --- Diff: src/plugman/init-defaults.js --- @@ -55,25 +55,26 @@ function readDeps (test) { }; } -var name = pkg.name ||

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-20 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/597#discussion_r146038992 --- Diff: .eslintignore --- @@ -1,4 +1 @@ -spec/cordova/fixtures/** -spec/plugman/projects/** -spec/plugman/plugins/**

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-20 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/597#discussion_r146039159 --- Diff: src/plugman/init-defaults.js --- @@ -149,10 +149,11 @@ if (!pkg.author) { } : prompt('author'); } -/*

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-20 Thread OminousWater
GitHub user OminousWater reopened a pull request: https://github.com/apache/cordova-lib/pull/597 CB-13451 (all platforms) "pkg not defined" exception when running plugman with createpackagejson command-line A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused

[GitHub] cordova-lib pull request #598: CB-13123 : plugin add should use cordovaDepen...

2017-10-19 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/598 CB-13123 : plugin add should use cordovaDependency instead of plugin.xml engine tag ### Platforms affected ### What does this PR do? plugin add/ install

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-16 Thread OminousWater
Github user OminousWater closed the pull request at: https://github.com/apache/cordova-lib/pull/597 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

2017-10-16 Thread OminousWater
GitHub user OminousWater opened a pull request: https://github.com/apache/cordova-lib/pull/597 CB-13451 (all platforms) "pkg not defined" exception when running plugman with createpackagejson command-line A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused

[GitHub] cordova-lib pull request #595: CB-12361 : updated and added unit tests for a...

2017-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/595 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #593: CB-12361 : added plugin unit tests for plugin...

2017-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/593 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #596: CB-13303 : added save_exact and production op...

2017-10-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/596 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #596: CB-13303 : added save_exact and production op...

2017-10-03 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/596 CB-13303 : added save_exact and production opts ### Platforms affected ### What does this PR do? Added save-exact and production opts ### What testing

[GitHub] cordova-lib pull request #591: CB-13274 : updated readme.md & removed refere...

2017-10-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/591 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/584 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

2017-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/594 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #595: CB-12361 : updated and added unit tests for a...

2017-09-19 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/595 CB-12361 : updated and added unit tests for add.spec.js ### Platforms affected ### What does this PR do? Updated and added "to-do" unit tests for add.spec.js

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

2017-09-15 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/594 CB-13288 : updated index.js and test to fix cordova plugin search ### Platforms affected ### What does this PR do? Updated index.js and test to fix cordova

[GitHub] cordova-lib pull request #592: CB-12361 : added some unit tests for plugman

2017-09-15 Thread audreyso
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/592 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #593: CB-12361 : added plugin unit tests for plugin...

2017-09-15 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/593 CB-12361 : added plugin unit tests for plugin list ### Platforms affected ### What does this PR do? Added plugin unit tests for plugin list ### What

[GitHub] cordova-lib pull request #592: CB-12361 : added some unit tests for plugman

2017-09-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/592 CB-12361 : added some unit tests for plugman ### Platforms affected ### What does this PR do? Added some unit tests for plugman ### What testing has

[GitHub] cordova-lib pull request #591: CB-13274 : updated readme.md & removed refere...

2017-09-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/591 CB-13274 : updated readme.md & removed references to jshint ### Platforms affected ### What does this PR do? Updated readme.md & removed references to jshint

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-09-06 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r137442765 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +62,131 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-09-06 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r137442686 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +62,131 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-09-06 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r137442253 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +62,131 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-09-06 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r137442083 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +62,131 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/569 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136486774 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136490386 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136489451 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136488898 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136490187 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136487019 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-08-31 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136487749 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-31 Thread audreyso
Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #589: removed .jscs.json

2017-08-29 Thread remcohaszing
Github user remcohaszing closed the pull request at: https://github.com/apache/cordova-lib/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-28 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/590#discussion_r135664127 --- Diff: src/cordova/plugin/util.js --- @@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) { var autosave =

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-28 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/590#discussion_r135664112 --- Diff: src/cordova/plugin/util.js --- @@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) { var autosave =

[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...

2017-08-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/569#discussion_r135331136 --- Diff: spec/cordova/plugin/add.spec.js --- @@ -21,16 +21,82 @@ /* globals fail */ var Q = require('q'); -var add =

[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...

2017-08-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/569#discussion_r135308470 --- Diff: spec/cordova/plugin/add.spec.js --- @@ -21,16 +21,82 @@ /* globals fail */ var Q = require('q'); -var add =

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-24 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/590 CB-13145: Create playservices version preference in config.xml Still need to add in tests ### Platforms affected ### What does this PR do? CB-13145:

[GitHub] cordova-lib pull request #565: CB-12944: Platform's spec is ignored in confi...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132795105 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132781446 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132780726 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132780476 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/581#discussion_r132758854 --- Diff: spec/cordova/plugin/remove.spec.js --- @@ -32,18 +66,123 @@ describe('cordova/plugin/remove', function () {

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r132738598 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,75 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r132742737 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,75 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/582#discussion_r132736159 --- Diff: spec/cordova/plugin/search.spec.js --- @@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/582#discussion_r132736117 --- Diff: spec/cordova/plugin/search.spec.js --- @@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {

[GitHub] cordova-lib pull request #575: CB-13020: (plugman) install filters out nohoo...

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #589: removed .jscs.json

2017-08-07 Thread remcohaszing
GitHub user remcohaszing opened a pull request: https://github.com/apache/cordova-lib/pull/589 removed .jscs.json ### Platforms affected none ### What does this PR do? Cleanup an unused file. ### What testing has been done on this change? None

[GitHub] cordova-lib pull request #587: CB-13056 : added deprecation notice for webos

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #585: CB-13057 : added deprecation warning for cord...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #588: CB-13056 : Removed parsers & platformApi poly...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/588 CB-13056 : Removed parsers & platformApi polyfill for webos, blackberry, & ubuntu ### Platforms affected ### What does this PR do? Removed parsers &

[GitHub] cordova-lib pull request #587: CB-13056 : added deprecation notice for webos

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/587 CB-13056 : added deprecation notice for webos ### Platforms affected ### What does this PR do? Added deprecation notice for webos ### What testing has

[GitHub] cordova-lib pull request #586: CB-13057 : Remove cordova platform save comma...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/586 CB-13057 : Remove cordova platform save command ### Platforms affected ### What does this PR do? Remove cordova platform save command ### What testing

[GitHub] cordova-lib pull request #585: CB-13057 : added deprecation warning for cord...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/585 CB-13057 : added deprecation warning for cordova platform save ### Platforms affected ### What does this PR do? Added deprecation warning for cordova platform

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/578#discussion_r129996355 --- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js --- @@ -0,0 +1,79 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

2017-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/579#discussion_r129981636 --- Diff: spec/cordova/platform/save.spec.js --- @@ -0,0 +1,71 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

2017-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/579#discussion_r129981726 --- Diff: spec/cordova/platform/save.spec.js --- @@ -0,0 +1,71 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-27 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/578#discussion_r129969368 --- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js --- @@ -0,0 +1,79 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/578#discussion_r129926425 --- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js --- @@ -0,0 +1,79 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

2017-07-27 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/584 CB-12361 : added tests for plugin/save.js ### Platforms affected ### What does this PR do? added tests for plugin/save.js ### What testing has been

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r129730654 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,66 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r129730691 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,66 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

2017-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/576#discussion_r129713116 --- Diff: spec/cordova/platform/remove.spec.js --- @@ -0,0 +1,160 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

2017-07-26 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/583 CB-12361 : added tests for plugin/index.js ### Platforms affected ### What does this PR do? Added tests for plugin/index.js ### What testing has been

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-07-21 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/582 CB-12361 : added tests for plugin/search.js ### Platforms affected ### What does this PR do? Added tests for plugin/search.js. ### What testing has

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-07-21 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/581 CB-12361 : added plugin remove tests ### Platforms affected ### What does this PR do? Added plugin remove tests. ### What testing has been done on

[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint

2017-07-20 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/580 CB-12895 : Replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

2017-07-20 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/579 CB-12361 : added tests for save.js ### Platforms affected ### What does this PR do? ### What testing has been done on this change? added tests for

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-18 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/578 CB-12361 : added unit-tests for getPlatformDetailsFromDir ### Platforms affected ### What does this PR do? added unit-tests for getPlatformDetailsFromDir

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-07-18 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/577 CB-12361 : added tests for platform/list.js ### Platforms affected ### What does this PR do? Added tests for platform/list.js ### What testing has

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

2017-07-17 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/576 CB-12361 : added unit tests for remove platform ### Platforms affected ### What does this PR do? Added unit tests for remove platform ### What testing has

[GitHub] cordova-lib pull request #575: CB-13020: (plugman) install filters out nohoo...

2017-07-13 Thread wildabeast
GitHub user wildabeast opened a pull request: https://github.com/apache/cordova-lib/pull/575 CB-13020: (plugman) install filters out nohooks ### Platforms affected n/a ### What does this PR do? fixes CB-13020: plugman filters out nohooks opt

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-07-13 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/574 CB-12838 : prevented sorting and alphabetizing platforms and plugins i… …n pkgJson and config ### Platforms affected ### What does this PR do?

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

2017-07-12 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r127110528 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,439 @@ */ /* eslint-env jasmine */ +var path = require('path');

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

2017-07-12 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r127066391 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,439 @@ */ /* eslint-env jasmine */ +var path = require('path');

[GitHub] cordova-lib pull request #573: CB-12361 : updated addHelper tests

2017-07-12 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/573#discussion_r127055093 --- Diff: spec/cordova/platform/addHelper.spec.js --- @@ -16,34 +16,439 @@ */ /* eslint-env jasmine */ +var path =

  1   2   3   4   5   6   7   8   9   10   >