[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-27 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r14300639 --- Diff: plugin.xml --- @@ -33,6 +33,9 @@ js-module src=www/CameraConstants.js name=Camera clobbers target=Camera /

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-20 Thread javierbb31
Github user javierbb31 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r14040361 --- Diff: plugin.xml --- @@ -202,6 +205,7 @@ !-- windows8 -- platform name=windows8 +dependency

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-19 Thread javierbb31
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/34 CB- 6958. Port camera test to plugin-test-framework Ported tests from mobile-spec (which are written in jasmine 1.3) in jasmine 2.0. Added: New js-module named tests to

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-19 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13982226 --- Diff: plugin.xml --- @@ -33,6 +33,9 @@ js-module src=www/CameraConstants.js name=Camera clobbers target=Camera /

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-19 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13982279 --- Diff: plugin.xml --- @@ -202,6 +205,7 @@ !-- windows8 -- platform name=windows8 +dependency

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-19 Thread javierbb31
Github user javierbb31 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13983869 --- Diff: plugin.xml --- @@ -202,6 +205,7 @@ !-- windows8 -- platform name=windows8 +dependency

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-19 Thread javierbb31
Github user javierbb31 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13984170 --- Diff: plugin.xml --- @@ -33,6 +33,9 @@ js-module src=www/CameraConstants.js name=Camera clobbers target=Camera /

[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/34#issuecomment-46609974 I've started a conversation on this, before we go and create `test` branches for all ~20ish plugins. http://markmail.org/message/576yxsj6xvg6rycw