Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-19461
Alright, I'm going to merge this in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194599948
@riknoll what's the final conclusion for the plugin release?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194598293
I think that fixing (or removing) `getRealPath()` might be a large
undertaking, so it shouldn't block the release. This permission request at
least makes
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194593508
@macdonst Not with the current implementation of `getRealPath()`
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194592028
@riknoll yeah, we shouldn't let people into the gallery if we can't read
the file later.
If we can't tell which gallery they will use is there a
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194588633
I guess it does make more sense for us to request the permission before we
select the photo because the developer of a Cordova app doesn't really have a
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194582918
@riknoll if you call getPicture() to read from the gallery shouldn't it
request READ permission before opening the gallery?
---
If your project is set
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194567940
@riknoll I'm not too familiar with android permission would be up to
@infil00p @jcesarmobile or maybe @macdonst
---
If your project is set up for it
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/191
CB-10825 android: Always request READ permission for gallery source
I am unhappy with this change, but this issue is blocking a release and a
proper fix could end up being a major rew
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194491881
@infil00p @csantanapr @jcesarmobile please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
11 matches
Mail list logo
