Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-150526428
@purplecabbage On Android, the strings were previously
[hardcoded](https://github.com/apache/cordova-plugin-camera/pull/104/files#diff-f2e83abdaf34884df7e
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149986619
I agree with @purplecabbage, and I'm still -1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149985578
-1
This should probably be 3 plugins
1. camera plugin
2. image picker plugin
3. image src chooser plugin
We can revisit this
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149044779
@jcesarmobile Is this a quirk just because it's only implemented on iOS,
Android, and WP?
@infil00p Actually, it is consistent on Android, and ha
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149027648
-1 to this as well. This wouldn't be consistent on Android, since we're
using Intents to launch a camera, and it's possible some devices wouldn't have
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149005887
-1 to adding new quirks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-126746379
@infil00p @shazron @nikhilkh @stevengill Any thoughts on this discussion or
possibility of a CR?
---
If your project is set up for it, you can reply to
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-120476371
Ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-119015527
@muratsu Valid question, thanks for starting the discussion. The Android
implementation is more like the Messages/Slack experience you highlight above.
I
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-119003640
I would like to hear everyone's opinion on this before going with the code
review.
Showing the photo gallery on bottom left seems like a custom v
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/104
CB-9193: Add 'showLibraryButton' to allow choosing source
A new camera option, `showLibraryButton`, is added which allows the user
to easily switch from the camera to the photo lib
12 matches
Mail list logo
