Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36225312
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, arg
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36199186
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
Github user rgecy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#issuecomment-127426047
How do I unsubscribe from this plugin list. I do not want to get emails on
every update.
On Aug 3, 2015 6:48 PM, "asfgit" wrote:
> Closed #
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#issuecomment-127409849
Sorry didn't see your comment earlier.
In terms of perf, I think this the usage of `if/else` vs `switch` is not
really important here. Since we're on
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130954
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, arg
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130435
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130273
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36129853
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/111
CB-9443 Pick correct maxResolution
According to MSDN docs we're currently not picking the correct
maxResolution for images:
https://msdn.microsoft.com/en-us/library/windows/apps/
10 matches
Mail list logo
