Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-203324738
Related PR to Medic: https://github.com/apache/cordova-medic/pull/85
---
If your project is set up for it, you can reply to this email and have your
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57571624
--- Diff: appium-tests/common/common.spec.js ---
@@ -0,0 +1,321 @@
+/*jshint node: true, jasmine: true, browser: true */
+/*global
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57245776
--- Diff: appium-tests/common/common.spec.js ---
@@ -0,0 +1,321 @@
+/*jshint node: true, jasmine: true, browser: true */
+/*global C
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57226720
--- Diff: appium-tests/common/common.spec.js ---
@@ -0,0 +1,321 @@
+/*jshint node: true, jasmine: true, browser: true */
+/*global C
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57225303
--- Diff: appium-tests/common/common.spec.js ---
@@ -0,0 +1,321 @@
+/*jshint node: true, jasmine: true, browser: true */
+/*global C
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57225224
--- Diff: appium-tests/common/common.spec.js ---
@@ -0,0 +1,321 @@
+/*jshint node: true, jasmine: true, browser: true */
+/*global C
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-200499861
@riknoll @dblotsky Can you please review again? This seems to be converging
to a good design now.
---
If your project is set up for it, you can reply
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197445134
@sgrebnov `fn.toString` is also a pretty nasty pattern. Adding buttons for
manual tests is literally what manual tests are. We control both the tests a
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197526519
@dblotsky We don't have manual tests - we have buttons demonstrating api
calls (for both api classes - with and without user interaction), there are n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197586990
@sgrebnov pure code tests that don't need UI interaction should not be in
Appium tests. Pure code tests that need UI interaction (like taking a picture
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r56317001
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r56311100
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r5602
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-196242692
I'm going to merge it in soon. @dblotsky @riknoll @nikhilkh
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55976166
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55895708
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55824201
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lic
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803966
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803719
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lic
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803572
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lic
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803473
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lic
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55803047
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55781014
--- Diff: appium-tests/helpers/wdHelper.js ---
@@ -0,0 +1,68 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780934
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780861
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780842
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lice
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780731
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lice
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780673
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lice
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780654
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lice
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780482
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lice
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780424
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Lice
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780306
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780286
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-193442451
@dblotsky @riknoll to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101
CB-10399 Added Appium tests
https://issues.apache.org/jira/browse/CB-10399
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSO
36 matches
Mail list logo
