Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94611365
finally solved~
really thanks everybody's help !!!
I will waiting the new version release
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94505096
I've just added the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94396822
Don't merge it yet, I've just noticed that I'm comparing [[UIApplication
sharedApplication] statusBarOrientation] with UIDeviceOrientation, and it
sh
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94391292
Looks good to me. I'll pull it in in the morning, but this block could have
been tightened up a bit:
https://github.com/shazron/CB-7734/blob/882882c5fd03d
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94176996
Actually the test project was just to repro the failing case. I haven't
evaluated your full landscape fix yet.
On Saturday, April 18, 2015, Jul
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94154670
If been looking into your test project and the last commented line should
be alertController.view.frame = alertFrame; not alertController.view.frame =
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94106987
In preparing my test project: https://github.com/shazron/CB-7734
I had to remove the build artifacts folder, and I did a re-test. Now I can
repro your
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94105276
I'm testing on Xcode 6.3 too, that's strange, can you test on a real device
with 8.1 or 8.2? can you test on a 8.1 simulator?
can you repo the bug
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94089798
My assertion is, I can't repro the failing bug at all. I'm using Xcode 6.3,
deploying to iOS 8.2 and 7.1 Simulators.
---
If your project is set up for it
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087506
This: "with the code on my pull request removing this line:
alertController.view.frame = [[UIScreen mainScreen] applicationFrame];"
---
If your projec
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087108
You mean without all the code on my pull request or with the code on my
pull request removing this line:
alertController.view.frame = [[UIScreen m
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94049313
Starting over again.
On iOS 8.2, and 7.1 Simulators -- I'm trying to make this "fail". Without
your fix:
``` alertController.view.frame = [[UI
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93894696
No, I've just tried and doesn't work if I do it that way
(alertController.view.frame = [self invertFrameIfNeeded:[UIScreen
mainScreen].applicationFra
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93868240
I think for the landscape problem, you should do this instead:
https://github.com/apache/cordova-plugin-statusbar/blob/2b3935af315034fdf6626a1010e91d3d8f44
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91827953
really thanks for @jcesarmobile and @shazron work hard !!!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91827499
I've just found that the fix isn't working on iPhone/iPod touch when the
device is in landscape, I'm going to update the code again
---
If your pro
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91824100
@shazron iOS 8.3 already fix the too many words issue, so, not sure how to
proceed here. Should we just expect everybody update their device and mark
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91795786
hi @jcesarmobile
thanks a lot
hope one day can solve this bug ~
---
If your project is set up for it, you can reply to this email and have your
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91790210
That line fixes the too many words issue, but if it crashes on iOS 8.3 I'll
try to find another fix
---
If your project is set up for it, you can re
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91768688
hi @shazron and @ginamdar
so...
what the next step about this bug fix progress
---
If your project is set up for it, you can reply to this emai
Github user ginamdar commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91729644
sorry for replying so late i never submitted PR for this and i have been
using my own implementation and not updated the plugin so far
---
If your proje
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91721145
Remove this line, and prompt works on iOS 8:
https://github.com/jcesarmobile/cordova-plugin-dialogs/blob/6b59babafeb8f1e7313ed99ea1625f839898e4ed/src/ios/C
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91715637
Probably related:
http://stackoverflow.com/questions/29571502/ios-8-3-uialertcontroller-crashes-when-trying-to-add-a-textfield
---
If your project is set
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91715099
Unfortunately after testing, it crashes on a prompt test on iOS 8. iOS 7 it
passes alert, confirm, and prompt tests.
I used from the README:
`
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-87159454
hi @shazron
according to this
https://github.com/doggy8088/Learn-Git-in-30-days
seem everything fix done
so...please help...how long will
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-76313015
hi @jcesarmobile @shazron @ginamdar
two months passed and new years come
so...
is this bug will merge into the official repository recently ?
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-68116655
thanks @shazron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-68110398
Prob after the holidays :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-67732478
hi @jcesarmobile @shazron @ginamdar
is there any specific time about this bug that merge into the official
repository ?
---
If your project is set
Github user ginamdar commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-65650770
im not using text fields inside my projects but this works with dialogboxes
on iOS8 without inputs fields
if (![self isAlertViewSupported]) {
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63158994
I am the original post
https://issues.apache.org/jira/browse/CB-7734
well...
really thanks for @jcesarmobile and @shazron help
---
If y
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63145889
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63145321
In any case, NSClassFromString is the safest thing you can do, and is the
best practice for supporting iOS 8-6.
---
If your project is set up for it, you
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63144935
[UIAlertController class] doesn't crash on iOS 7 devices if you compile it
on xcode 6 using iOS 8 SDK.
I'm making the changes for Xcode 5 rig
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63123720
Hi Julio,
I'm sure you will have followed the dev@ discussion by now.
Two changes are required, since you are using iOS 8 API code.
1.
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39
Fix CB-7734. Changed plugin to use UIAlertController on iOS 8
Changed plugin to use UIAlertController on iOS 8 and greater instead of
the UIAlertView as UIAlertView is depreca
37 matches
Mail list logo
