Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-207525949
@tommy1688 could you please file a JIRA ticket to track the recording issue
you're facing ? also, make sure to reference the PR which you said fixes
thing
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-201359813
@ThunderTech-Avisolve I'm not sure what the exact limitations are with
avplayer but you could look it up in apples docs, they do have documentation of
the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user ThunderTech-Avisolve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-200395570
@ghenry22, I've been trying to follow all of this -- but, I'm having an
issue where my app is correctly using [avPlayer play] to stream a MP3 f
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-199568786
@tommy1688 that change will completely break streaming audio support. All
it is doing is reverting to using avaudioplayer for everything and assuming
tha
Github user tommy1688 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-199324271
I applied this PR and it can play local audio file. But all the sound
recording function fails after apply this PR.
I tried the following PR:
h
Github user hdsnet commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-199232066
+1 How is this going guys?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-196450607
You can use cordova-paramedic like this:
https://github.com/daserge/cordova-plugin-device/commits/paramedic
---
If your project is set up for it, you can
Github user gaelenh commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-196428478
I agree with the need for a test case, however I am at a loss on where to
start. After doing ```npm install``` and ```npm test```, nothing appears to
happ
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194492899
This is a base case that was broken. I think it'd be great if you were to
add a test case to prevent that from ever happening again.
Also, the way the
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194492790
This is a base case that was broken. I think it'd be great if you were to
add a test case to prevent that from ever happening again.
Also, the way the
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55581042
--- Diff: src/ios/CDVSound.m ---
@@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command
NSString* mediaId = [command argumen
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55579371
--- Diff: src/ios/CDVSound.m ---
@@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command
NSString* mediaId = [command argumen
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55578144
--- Diff: src/ios/CDVSound.m ---
@@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command
NSString* mediaId = [command argumen
Github user gaelenh commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194458433
@omefire yes my ICLA has been signed and filed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194455097
@gaelenh have you signed an ICLA ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user FlossyWeb commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-193845735
Hi there,
Thanks @gaelenh this definitely fixes the issue, please merge guys !
---
If your project is set up for it, you can reply to this email and
Github user MikelArnaiz commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-193184301
I changed those two lines and now it works, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-192183151
cool I'll test this out when I have a chance and see if it still behaves as
expected in my app as it uses a mix of local and streaming content
---
If yo
Github user gaelenh commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191897320
Based on @ghenry22's comment, I took a different approach to fixing the
bug. I changed the url validation to happen earlier (in create) so that the
audioF
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191648550
The avPlayer.play code is there for playing from remote sources as a
stream, it will only be triggered if the source starts with http or https.
If
GitHub user gaelenh opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/85
CB-10723: iOS audio should use audioFile player
avPlayer.play does not play the requested audio file. Use the player on the
audioFile object to play instead. I checked out stop and pau
22 matches
Mail list logo
