Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-127279861
@dblotsky, rebased and tested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-126634941
Ping. Please rebase atop latest master changes, and verify that it still
works. Then we can merge.
---
If your project is set up for it, you can reply to
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121547583
@robpaveza, thanks for review,
I have addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121324570
Pending my other comments, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950380
--- Diff: src/windows/MediaProxy.js ---
@@ -159,7 +176,21 @@ module.exports = {
var id = args[0];
var src = args[1];
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950096
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
create:function(win, lose, args) {
var id = ar
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950043
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
create:function(win, lose, args) {
var id = ar
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482157
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
var id = args[0];
var thisM = Media.g
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482725
--- Diff: src/windows/MediaProxy.js ---
@@ -226,6 +301,10 @@ module.exports = {
try {
if (thisM.node) {
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482618
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
var id = args[0];
var thisM = Media.get
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482303
--- Diff: src/windows/MediaProxy.js ---
@@ -91,6 +106,8 @@ module.exports = {
var thisM = Media.get(id);
// if Media was
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482258
--- Diff: src/windows/MediaProxy.js ---
@@ -226,6 +301,10 @@ module.exports = {
try {
if (thisM.node) {
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482032
--- Diff: src/windows/MediaProxy.js ---
@@ -26,6 +26,15 @@ var MediaError =
require('cordova-plugin-media.MediaError');
var recordedFi
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482012
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
var id = args[0];
var thisM = Media.g
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481751
--- Diff: src/windows/MediaProxy.js ---
@@ -159,7 +176,21 @@ module.exports = {
var id = args[0];
var src = args[1];
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481357
--- Diff: src/windows/MediaProxy.js ---
@@ -91,6 +106,8 @@ module.exports = {
var thisM = Media.get(id);
// if Media w
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481074
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
create:function(win, lose, args) {
var id =
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480928
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
create:function(win, lose, args) {
var id =
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480844
--- Diff: src/windows/MediaProxy.js ---
@@ -26,6 +26,15 @@ var MediaError =
require('cordova-plugin-media.MediaError');
var recorded
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/58
CB-9238 Media plugin cannot record audio on windows
Reworked Windows proxy to support ms-appdata file paths (temporaryFolder
and localFolder) instead of app package' folders (ms-appx) a
21 matches
Mail list logo
