[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...

2015-07-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125734549 Send a pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...

2015-07-28 Thread SidFerreira
Github user SidFerreira commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125732348 Why not make the toLowerCase on the line #236 and saving all the conversion and tests on the other lines? --- If your project is set up

[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...

2015-07-26 Thread cantecim
GitHub user cantecim opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/29 Solved toLowerCase issue with Locale.US There was an issue with toLowerCase method which causes if conditions to fail because of user locale For example: In turk