Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-174647257
Another scenario where we need more test coverage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-173503621
Thanks @bso-intel, and @vladimir-kotikov for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-173475729
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-173474167
Hi @purplecabbage,
Would you review this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-173476489
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-windows/pull/140
CB-10381 fix the bug when removing a plugin with a tag
I fixed a simple bug that caused an exception EISDIR when removing a plugin
that includes a tag.
PluginHandler.js should have
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172676250
Thanks! And your change of to has made this issue make
infinitely more sense!
---
If your project is set up for it, you can reply to this email and
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172667498
Hi @vladimir-kotikov
Could you review this pull request?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172667998
Thanks for the fix!
Can you please provide a failing test that now passes, or at least a
specific list of repro steps?
I am unclear on what
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172675243
Hi @purplecabbage,
Here is how you can reproduce the issue:
1. cordova platform add windows
2. cordova plugin add cordova-sqlite-storage
11 matches
Mail list logo
