Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-125482377
This was merged in 9be50cd43a893f6af532b585baa7fa00e71772c9 but not
auto-closed. Closing it now.
---
If your project is set up for it, you can reply to
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-125480333
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-124020906
> AppVeyor tests was failing because AppVeyor machines has UAC disabled (I
already mentioned that in one of my PRs, can't find it now)
Found it:
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123712167
> When I run this branch on my local, I get an npm test failure for
check_reqs.spec.js, failing to find config.xml in cordova-windows root.
Sorr
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123432180
I'm supposing build.spec.js spec.13 fails because it doesn't mock
`findAllAvailableVersions` (or was also `findAvailableVersions` in your code).
I wrote a use
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123430303
build.spec.js spec.13 fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123413927
When I run this branch on my local, I get an npm test failure for
check_reqs.spec.js, failing to find config.xml in cordova-windows root.
---
If your project
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123412166
I'm checking out how it works with #102 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r34036020
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q =
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r34035987
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q =
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r34019903
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q =
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998489
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = requir
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998435
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = requir
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998401
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = requir
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998339
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = requir
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-118113194
@robpaveza Can you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-117930344
I've slightly changed `Version` module to allow to accept incomplete
version strings, but forgot ro check test results :( However, if the test for
inco
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-117830645
Why are there AppVeyor failures
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/92
CB-9235 Adds more checks based on the windows-target-version
This is an implementation for
[CB-9235](https://issues.apache.org/jira/browse/CB-9235)
The logic of `check_all`
20 matches
Mail list logo
