The vote has now closed. The results are:
Positive Binding Votes: 4
Steve Gill
Andrew Grieve
Ian Clelland
Mark Koudritsky
The vote has passed. I will publish these to dist and npm.
On Tue, Mar 31, 2015 at 2:42 PM, Steven Gill stevengil...@gmail.com wrote:
That is good rationale for that use
+1
* Verified package contents against public repo at the correct tags
* Verified checksums and signatures
* Built and verified functionality on android (4.0.0-dev/0669edd) and ios
(no functionality, no issues either)
On Tue, Mar 31, 2015 at 1:10 AM, Steven Gill stevengil...@gmail.com wrote:
I
+1
* built and ran a hello world app on Nexus 7 and iOS simulator
Also pinned app-hello-world version to 3.8.0 in cordova-lib:
https://github.com/apache/cordova-lib/commit/c154d527a5b52a5b1fd139f437c83f455cf92e10
This should be changed back once we pin cordova-android version to 4.0.
On Tue, Mar
Ian, instead of adding a version tag in plugin.xml, why don't we use the
engine tag in plugins package.json?
Something like:
{
engines : {
cordova-android : 4.0.0,
cordova-ios : =3.0.0 4.0
}
}
If the user doesn't have the specified platform versions installed, user
gets a warning
My thinking was that some plugins are going to need to have two very
different designs, say for cordova-android 3.7.0 vs 4.0.0, or cordova-ios
3.8.0 vs 4.0.0. In that case, you could do something like this;
platform name=ios
version match==4.0.0
!-- tags for the new version --
/version
That is good rationale for that use case. Not sure how much our users would
run into it. Do we have any plugins currently that we would want to install
different files for older versions. Managing all of that code in a plugin
will get ugly.
In NPM land, I think the answer would be to install an
Looks like this breaks on cordova-android 3.7.1 (currently latest released)
cordova-app-hello-world requires the whitelist plugin
whitelist plugin depends on cordova-android 4.0 via the engine tag
engine name=cordova-android version==4.0.0-dev /
The resulting error message is
Plugin doesn't
So this isn't a -1, unless we can't fix the problem in cordova-lib. And
it's okay, I think, to fix it in cordova-lib/master and release that as
well. Nothing is actually broken by publishing either app-hello-world or
plugin-whitelist until we release a version of tools that is pinned to the
new
Another quick option for now: we can pin hello-world version in
cordova-lib's package.json to 3.8.0 which doesn't use the whitelist
plugin. Later, when we release the tools pinned to cordova-android 4.0 we
will have to change the hello-world dep to ^3.9.0.
This way it's a minimal change to
Mark - I like that idea as well.
On Mon, Mar 30, 2015 at 6:33 PM, Ian Clelland iclell...@chromium.org
wrote:
On 30 Mar 2015 4:52 pm, Mark Koudritsky kam...@google.com wrote:
Another quick option for now: we can pin hello-world version in
cordova-lib's package.json to 3.8.0 which doesn't
I like the sound of both ideas.
Marks idea to make the default hello world app not install whitelist until
android 4.0 (use 3.8.0 for app hello world)
Ian, that looks like a good proposal. We are definitely overdo for
something to properly track versions. Users should get a warning when a
plugin
+1
* Tested that both plugins compile on Android
* Tested that the non-legacy plugin does what its supposed to on Android
On Thu, Mar 26, 2015 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote:
Please review and vote on the releases of cordova-plugin-whitelist and
Please review and vote on the releases of cordova-plugin-whitelist and
cordova-plugin-legacy-whitelist plugins.
Release issue: https://issues.apache.org/jira/browse/CB-8739
The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8739/
The packages were
13 matches
Mail list logo
