Re: [cordova-js] replaceNavigator

2014-10-27 Thread Shazron
Yup, we could use those functions. I'll check them out. On Mon, Oct 27, 2014 at 12:51 PM, Ian Clelland wrote: > On Mon Oct 27 2014 at 3:41:48 PM Shazron wrote: > > > Ouch, sorry about this :( > > > > Don't be -- you did the right thing, and nobody actually tried it out on > the devices it's fai

Re: [cordova-js] replaceNavigator

2014-10-27 Thread Ian Clelland
On Mon Oct 27 2014 at 3:41:48 PM Shazron wrote: > Ouch, sorry about this :( > Don't be -- you did the right thing, and nobody actually tried it out on the devices it's failing on. I was talking to Andrew about it earlier, and he reminded me of the utility functions we have for this in cordova.j

Re: [cordova-js] replaceNavigator

2014-10-27 Thread Shazron
Ouch, sorry about this :( On Fri, Oct 24, 2014 at 8:41 AM, Ian Clelland wrote: > I'm sorry that I missed this, and that it never got the review that it > deserved -- thanks for at least taking the right step and giving the whole > dev community the chance to review it first, though. > > Accordin

Re: [cordova-js] replaceNavigator

2014-10-24 Thread Ian Clelland
I'm sorry that I missed this, and that it never got the review that it deserved -- thanks for at least taking the right step and giving the whole dev community the chance to review it first, though. According to a bug report this morning ( https://issues.apache.org/jira/browse/CB-7868), it looks l

[cordova-js] replaceNavigator

2014-09-10 Thread Shazron
PR: https://github.com/apache/cordova-js/pull/80 Issue: https://issues.apache.org/jira/browse/CB-6911 May I humbly request a review of the pull request above. Since it affects all platforms, I thought it would be prudent. Note the deprecation "error" is just a warning (not sure why Safari Web Ins