Re: Browserify JS is in

2014-12-17 Thread Darryl Pogue
On 11 December 2014 at 11:37, Steven Gill stevengil...@gmail.com wrote: I also would like to see this shipped! If you have questions about it, LMK I was trying this out today, and overall I love the idea. I found one issue though when building for multiple platforms: cordova platform add ios

Re: Browserify JS is in

2014-12-17 Thread Steven Gill
Sounds like a bug. Can you file an issue for it? On Wed, Dec 17, 2014 at 12:53 PM, Darryl Pogue dvpdin...@gmail.com wrote: On 11 December 2014 at 11:37, Steven Gill stevengil...@gmail.com wrote: I also would like to see this shipped! If you have questions about it, LMK I was trying this

Re: Browserify JS is in

2014-12-17 Thread Darryl Pogue
On 17 December 2014 at 15:26, Steven Gill stevengil...@gmail.com wrote: Sounds like a bug. Can you file an issue for it? https://issues.apache.org/jira/browse/CB-8183 - To unsubscribe, e-mail:

Re: Browserify JS is in

2014-12-15 Thread Michal Mocny
Thanks Steven. On Mon, Dec 15, 2014 at 12:15 AM, Steven Gill stevengil...@gmail.com wrote: For the lazy: cordova_plugins.js discussion https://issues.apache.org/jira/plugins/servlet/mobile#issue/CB-8153 On Dec 14, 2014 6:58 PM, Michal Mocny mmo...@chromium.org wrote: Lets discuss the

Re: Browserify JS is in

2014-12-15 Thread Andrew Grieve
Maybe most other companies are not in the same boat, but at Google we can't add any software to our build process without it all being checked into source control (and reviewed). Currently NPM is our biggest dependency, but thankfully we use that only for fetching (and so don't need it if we

Re: Browserify JS is in

2014-12-15 Thread Josh Soref
) To: dev dev@cordova.apache.orgmailto:dev@cordova.apache.org Subject: Re: Browserify JS is in Maybe most other companies are not in the same boat, but at Google we can't add any software to our build process without it all being checked into source control (and reviewed). Currently NPM is our

Re: Browserify JS is in

2014-12-14 Thread Carlos Santana
This is the part that I like the most: and start writing plugins as proper node modules. Maybe even push them to npm and manage dependencies that way. Agree with having less XHR, and concatenate cordova + plugins. Not in love with cordova_plugins.js to know what plugins are included in the app,

Re: Browserify JS is in

2014-12-14 Thread Michal Mocny
Lets discuss the cordova_plugins.js thing elsewhere, this thread has forked a lot already. On Sun, Dec 14, 2014 at 6:22 PM, Carlos Santana csantan...@gmail.com wrote: This is the part that I like the most: and start writing plugins as proper node modules. Maybe even push them to npm and

Re: Browserify JS is in

2014-12-14 Thread Steven Gill
For the lazy: cordova_plugins.js discussion https://issues.apache.org/jira/plugins/servlet/mobile#issue/CB-8153 On Dec 14, 2014 6:58 PM, Michal Mocny mmo...@chromium.org wrote: Lets discuss the cordova_plugins.js thing elsewhere, this thread has forked a lot already. On Sun, Dec 14, 2014 at

Re: Browserify JS is in

2014-12-12 Thread Michal Mocny
Okay, well we've got some tests to do and can come back here with results. One feature I would like to not lose: cordova_plugins.js is bad for many reasons, but I have found it useful on several occasions to get a full list of plugins versions that shipped with an app. One reason is for the

Re: Browserify JS is in

2014-12-12 Thread Andrew Grieve
On Thu, Dec 11, 2014 at 2:38 PM, Andrew Grieve agri...@chromium.org wrote: I'd really like to get it fully spelled out *why* browserify is the right tool for this. Some thoughts below: On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux b...@brian.io wrote: we should move browserify to main and

Re: Browserify JS is in

2014-12-12 Thread Joe Bowser
On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve agri...@chromium.org wrote: I'm not actually worried about my disk filling up. Dependencies must be vetted for appropriate licenses, so now there's more overhead here. If we need to make a change to the module system now we need to poor through

Re: Browserify JS is in

2014-12-12 Thread Andrew Grieve
On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser bows...@gmail.com wrote: On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve agri...@chromium.org wrote: I'm not actually worried about my disk filling up. Dependencies must be vetted for appropriate licenses, so now there's more overhead here. If

Re: Browserify JS is in

2014-12-12 Thread Joe Bowser
What are we actually distributing? On Fri Dec 12 2014 at 12:36:03 PM Andrew Grieve agri...@chromium.org wrote: On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser bows...@gmail.com wrote: On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve agri...@chromium.org wrote: I'm not actually worried

Re: Browserify JS is in

2014-12-12 Thread Brian LeRoux
yeah we are *not* proposing to distribute browserify or its deps On Fri, Dec 12, 2014 at 1:38 PM, Joe Bowser bows...@gmail.com wrote: What are we actually distributing? On Fri Dec 12 2014 at 12:36:03 PM Andrew Grieve agri...@chromium.org wrote: On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser

Re: Browserify JS is in

2014-12-11 Thread Brian LeRoux
so I think this has baked long enough! lets make it the default and suss the bugs. On Thu, Jul 10, 2014 at 3:36 AM, Ally Ogilvie aogil...@wizcorp.jp wrote: Ace, look forward to browser/web as platform. Combined Web and Native API plugin for Cordova! Yay! Thanks for the clarification Michal.

Re: Browserify JS is in

2014-12-11 Thread Joe Bowser
This should be a major, but yeah, I'm fine with making this the default. On Thu, Dec 11, 2014, 11:08 AM Brian LeRoux b...@brian.io wrote: so I think this has baked long enough! lets make it the default and suss the bugs. On Thu, Jul 10, 2014 at 3:36 AM, Ally Ogilvie aogil...@wizcorp.jp

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
I also would like to see this shipped! If you have questions about it, LMK On Thu, Dec 11, 2014 at 11:10 AM, Joe Bowser bows...@gmail.com wrote: This should be a major, but yeah, I'm fine with making this the default. On Thu, Dec 11, 2014, 11:08 AM Brian LeRoux b...@brian.io wrote: so I

Re: Browserify JS is in

2014-12-11 Thread Andrew Grieve
I'd really like to get it fully spelled out *why* browserify is the right tool for this. Some thoughts below: On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux b...@brian.io wrote: we should move browserify to main and drop that insane concat code its not heavyweight at all. it creates a hash in

Re: Browserify JS is in

2014-12-11 Thread Michal Mocny
25MB is for the one-time cordova-cli install, and not overhead for the app. Its not perfect but not a blocker imho. There are more troubling things about the change than the size overhead: - I don't think browserify has baked at all. It was landed behind a flag, but is it actually used

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
Answers inline based on my understanding. Current system vs Browserify system (which exists behind a flag currently) On Thu, Dec 11, 2014 at 11:38 AM, Andrew Grieve agri...@chromium.org wrote: I'd really like to get it fully spelled out *why* browserify is the right tool for this. Some

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny mmo...@chromium.org wrote: 25MB is for the one-time cordova-cli install, and not overhead for the app. Its not perfect but not a blocker imho. Agreed There are more troubling things about the change than the size overhead: - I don't think

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
Realized I wasn't clear, but startup/run time is definitely faster. One of the benefits of switching to a system like this. Build time is a few ms slower. On Thu, Dec 11, 2014 at 2:06 PM, Steven Gill stevengil...@gmail.com wrote: On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny

Re: Browserify JS is in

2014-12-11 Thread Josh Soref
Steven Gill wrote: Android and IOS had same success rate on mobile spec for browserify system last time I tested. Need to do more tests with other platforms. Last I checked, mobile spec was just plain broken. Someone added a mandatory flag for building cordova-js and didn't teach mobile-spec

Re: Browserify JS is in

2014-12-11 Thread Brian LeRoux
I've vetted webpack (and the rest) extensively. Less ecosystem. More complex config. No transforms. Here's a thing I wrote on the modules front. Not directly applicable but possibly relevant and at worst geek entertaining. ;)

Re: Browserify JS is in

2014-12-11 Thread Anis KADRI
On Thu, Dec 11, 2014 at 11:38 AM, Andrew Grieve agri...@chromium.org wrote: I'd really like to get it fully spelled out *why* browserify is the right tool for this. Some thoughts below: On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux b...@brian.io wrote: we should move browserify to main and

Re: Browserify JS is in

2014-12-11 Thread Anis KADRI
On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny mmo...@chromium.org wrote: 25MB is for the one-time cordova-cli install, and not overhead for the app. Its not perfect but not a blocker imho. There are more troubling things about the change than the size overhead: - I don't think browserify

Re: Browserify JS is in

2014-12-11 Thread Ian Clelland
On Thu Dec 11 2014 at 9:29:08 PM Anis KADRI anis.ka...@gmail.com wrote: On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny mmo...@chromium.org wrote: 25MB is for the one-time cordova-cli install, and not overhead for the app. Its not perfect but not a blocker imho. Agreed. In terms of size

Re: Browserify JS is in

2014-07-10 Thread Ally Ogilvie
Ace, look forward to browser/web as platform. Combined Web and Native API plugin for Cordova! Yay! Thanks for the clarification Michal. On Tue, Jul 8, 2014 at 6:07 AM, Anis KADRI anis.ka...@gmail.com wrote: Right, browserify is just a way to package cordova.js that should make it easier to

Re: Browserify JS is in

2014-07-07 Thread Anis KADRI
On Sun, Jun 29, 2014 at 9:54 PM, Ally Ogilvie aogil...@wizcorp.jp wrote: Anis that is really sweet. If this hits CLI, plugin.xml will have sections for plugins to do web actions? Not sure I understand what you mean by web actions. TBH.. i've always wanted a cordova platform add web... but

Re: Browserify JS is in

2014-07-07 Thread Michal Mocny
I think Ally may be confusing what this does?: This browserify work is not a way to get cordova to run in a desktop browser, its just a means for packaging cordova.js. I think there should be no visible change to end users. There is a separate effort to target the browser as a platform, and it

Re: Browserify JS is in

2014-07-07 Thread Anis KADRI
Right, browserify is just a way to package cordova.js that should make it easier to add the browser as a platform so might not be directly related but is somewhat related :-} On Mon, Jul 7, 2014 at 4:45 PM, Michal Mocny mmo...@chromium.org wrote: I think Ally may be confusing what this does?:

Re: Browserify JS is in

2014-06-29 Thread Ally Ogilvie
Anis that is really sweet. If this hits CLI, plugin.xml will have sections for plugins to do web actions? TBH.. i've always wanted a cordova platform add web... but i'd be happy enough with a prepare for browser only mode. Seeing a lot of use cases (e.g. Facebook plugin etc.) where there are JS,

Re: Browserify JS is in

2014-06-20 Thread Anis KADRI
Ok cool. I can look at adding a --browserify option for run and prepare. I logged an issue for it [1] [1] https://issues.apache.org/jira/browse/CB-7001 On Thu, Jun 19, 2014 at 5:57 PM, Andrew Grieve agri...@chromium.org wrote: Thanks Anis! Tougher for CLI since it's actually the prepare

Re: Browserify JS is in

2014-06-19 Thread Andrew Grieve
bump On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve agri...@chromium.org wrote: Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org wrote: Awesome

Re: Browserify JS is in

2014-06-19 Thread Anis KADRI
Sorry. I forgot you asked the question. There was no issue but there is one now. https://issues.apache.org/jira/browse/CB-6990 This feature is plugman only for now. How important is it to wire it to CLI ? Have you guys had time to test it out yet ? How would it work with CLI ? Add another flag

Re: Browserify JS is in

2014-06-19 Thread Andrew Grieve
Thanks Anis! Tougher for CLI since it's actually the prepare step that creates cordova_plugins.js, but longer term (medium term?) I don't see why we shouldn't just turn it on always anyways. So... Maybe cordova prepare --browserify? Build prepares first, so will also need: cordova run android

Re: Browserify JS is in

2014-06-16 Thread Michal Mocny
Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks for landing this this way, and for the useful report. -Michal On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI anis.ka...@gmail.com wrote: Yo, Just wanted to let everyone know that I added browserify

Re: Browserify JS is in

2014-06-16 Thread Andrew Grieve
Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org wrote: Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks

Browserify JS is in

2014-06-13 Thread Anis KADRI
Yo, Just wanted to let everyone know that I added browserify support to plugman (behind a flag for now). CLI is not hooked to this yet. Here is how it works: plugman install --browserify --plugin [PLUGIN] --platform [PLATFORM] --project [PROJECT_PATH] will generate a browserify version of