[GitHub] cordova-android issue #354: CB-12099 (android) SplashScreen Screen Flicker

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-android/pull/354 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move splashscreen

Re: CB-12099 (android) SplashScreen Screen Flicker

2017-01-12 Thread Sergey Shakhnazarov
Hi guys, I've found an issue with proposed solution related to SplashMaintainAspectRatio=true option - it seems that there's no straightforward way to support this option for Activity background drawable. So for SplashMaintainAspectRatio=true there will be a subtle size change on start up.

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-27 Thread Sergey Shakhnazarov
Hi Joe, guys, happy holidays everyone! Regarding "this is not a problem unique to PhoneGap/Cordova" - I've attached short videos to the Jira [1] with the flicker issue clearly visible for a blank Cordova app (build with latest published versions of cordova, cordova-android and

[GitHub] cordova-android issue #354: CB-12099 (android) SplashScreen Screen Flicker

2016-12-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/354 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/354?src=pr) is 35.58% (diff: 100%) > Merging

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-20 Thread Joe Bowser
Comments are inline On Tue, Dec 20, 2016 at 1:19 PM, Sergey Shakhnazarov wrote: > > > > 3. I'm not sure why we need the prepare step and why the drawable's > colour can't be changed programmatically in Java instead of pulling it from > the config.xml in prepare.js, which

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-20 Thread Sergey Shakhnazarov
Hi Joe, > 2. The bug refers to the flicker, which I haven't seen in quite a while, but can be attributed to the splashscreen disappearing at the wrong time and the WebView not being made visible or not rendering properly. CB-12099 explicitly refers to the weird behaviour of the SplashScreenDelay

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Joe Bowser
OK, I read the PR, and I'll admit that I misunderstood part of the problem. I have a few concerns about this change: 1. Why does Android need to have a PR at all? The splashscreen plugin can use edit-config tag to change the manifest to add the theme, which it really should anyway and the XML

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Sergey Shakhnazarov
Hello Joe, Could you please elaborate - is there a Jira item corresponding to that duration issue? Thanks, Sergey. 16 Дек 2016 г. 23:38 пользователь "Joe Bowser" написал: I think we should figure out why the duration of the Splashscreen is messed up before we start messing

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Joe Bowser
I think we should figure out why the duration of the Splashscreen is messed up before we start messing with the background colour of the application, especially since the last time we did that, we broke Hello World! On Fri, Dec 16, 2016 at 11:32 AM, Sergey Shakhnazarov wrote:

CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Sergey Shakhnazarov
Hi guys! There’s an issue with Android splashscreen that every app has a black flash on start [1]. I propose to fix this using the android:windowBackground composed as splash image (which we use in splashscreen plugin) laid on top of SplashScreenBackgroundColor [2] (this preference is