Filed an INFRA ticket for ReviewBoard:
https://issues.apache.org/jira/browse/INFRA-5889
On Tue, Jan 22, 2013 at 10:59 AM, Andrew Grieve agri...@chromium.orgwrote:
ReviewBoard seems like a great fit to me! Let's try it out!
On Mon, Jan 21, 2013 at 8:43 PM, Brian M Dube bd...@apache.org
ReviewBoard seems like a great fit to me! Let's try it out!
On Mon, Jan 21, 2013 at 8:43 PM, Brian M Dube bd...@apache.org wrote:
On 01/21/2013 01:24 PM, Joe Bowser wrote:
On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org
wrote:
As for code reviews:
I'd certainly be
Code reviews will generally sound good to Googlers, so long as we can keep
the turnaround down. It definitely keeps our code quality high on internal
projects, even if it is sometimes a pain to have to wait for a response and
do your own reviews. I've asked Michal and Andrew for over-the-shoulder
Here's a draft for a new Committing Your Own Changes: section on
http://wiki.apache.org/cordova/CommitterWorkflow
Step 1: Mail the Mailing-list
- This is required if:
- Your change will add/remove/change any public Cordova APIs.
- You suspect that your change has a chance of being
Not a bad idea, noted
On 1/22/13 10:57 AM, Andrew Lunny alu...@gmail.com wrote:
Outsider observation/note: probably useful for step 4 to tie into the CI -
getting the pull request to notify Fil's CI project.
On 22 January 2013 10:53, Andrew Grieve agri...@chromium.org wrote:
Here's a draft
Here's a draft for a new Committing Your Own Changes: section on
http://wiki.apache.org/cordova/CommitterWorkflow
Great draft Andrew. It reads well.
Outsider observation/note: probably useful for step 4 to tie into the CI -
getting the pull request to notify Fil's CI project.
It would be
Recently we've been noticing that there's been a lot of new features
going into Cordova this release, especially in Android. Now, I know
that I've been guilty of this in the past, which is partly why I'm
saying this now.
I think that we need to talk about features and make sure they work
before
Agree, but this should be just the regular flow rather than a formal
check in. Anything big should be in a branch and ideally ppl should
socialize branches on the list before the merge.
On Mon, Jan 21, 2013 at 12:41 PM, Joe Bowser bows...@gmail.com wrote:
Recently we've been noticing that
Agree with both of you. Also of note is the ripple effect of adding a
feature to one platform, see the slice() discussion for an example.
Any new feature should be explored and discussed further than just
ios/android.
Cheers,
Jesse
Sent from my iPhone5
On 2013-01-21, at 10:50 AM, Brian
One tough thing about this is knowing when you have agreement or not. E.g.
for adding File.slice(), Braden sent out an email on the 7th saying that
he'd like to add it for iOS Android. Simon gave it a +1, and no one else
responded. He then implemented the feature in a feature branch and then
I always thought silence is assent, especially if the ML was given enough
notice. Per the Apache Voting Process:
http://www.apache.org/foundation/voting.html (Consensus Gauging through
Silence -- since we don't have a review then commit policy like WebKit)
On Mon, Jan 21, 2013 at 1:06 PM,
On Mon, Jan 21, 2013 at 4:24 PM, Joe Bowser bows...@gmail.com wrote:
On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org
wrote:
One tough thing about this is knowing when you have agreement or not.
E.g.
for adding File.slice(), Braden sent out an email on the 7th saying
In my opinion the last few omfg shit's broken emails comes mainly from
lack of testing. If a committer puts something into master, they need to
do due diligence for it, and that boils down to one question: do tests
pass on devices+platforms affected by the commit?
iOS this is easier (per se) than
Braden just used a private branch and didn't ask for review. Maybe the
take-away from this is that we it would be good to have the chance for a
review for anything that was big enough to warrant a branch? I'll add this
to the committer's wiki page.
Yeah let's summarize our discussion points /
On 01/21/2013 01:24 PM, Joe Bowser wrote:
On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org wrote:
As for code reviews:
I'd certainly be interested in more code-reviews. I think it's really
useful to get feedback on changes. The only time when it becomes a burden
is when
15 matches
Mail list logo
