[ANNOUNCEMENT] cordova-eslint@4.0.0 & cordova-app-hello-world@6.0.0 Release

2021-10-30 Thread Bryan Ellis
We have just released an update to our eslint config & default template! - cordova-eslint@4.0.0 - cordova-app-hello-world@6.0.0 You can view the release blog post at https://cordova.apache.org/news/2021/10/31/template-release.html <https://cordova.apache.org/news/2021/10/31/t

Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release

2021-10-30 Thread Bryan Ellis
gt;> On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: >> >>> Please review and vote on the following packages for release by >> replying >>> to this email (and keep discussion on the DISCUSS thread): >>> >>> - cordova-eslint v4.0.0 >&g

Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release

2021-10-28 Thread Niklas Merz
55 AM Bryan Ellis wrote: > > > Please review and vote on the following packages for release by > replying > > to this email (and keep discussion on the DISCUSS thread): > > > > - cordova-eslint v4.0.0 > > - cordova-app-hello-world v6.0.0 > > > > The archiv

Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release

2021-10-28 Thread Jesse
; - cordova-app-hello-world v6.0.0 > > The archives has been published to the dist/dev: > > - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < > https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> > - https://dist.apache.org/repos/dist/dev/c

[VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release

2021-10-27 Thread Bryan Ellis
Please review and vote on the following packages for release by replying to this email (and keep discussion on the DISCUSS thread): - cordova-eslint v4.0.0 - cordova-app-hello-world v6.0.0 The archives has been published to the dist/dev: - https://dist.apache.org/repos/dist/dev/cordova/eslint

[DISCUSS] cordova-eslint 4.0.0 major & cordova-app-hello-world 6.0.0 major Release

2021-10-25 Thread Bryan Ellis
Does anyone have any reason to delay a major release for the following packages? - cordova-eslint@4.0.0 - cordova-app-hello-world@6.0.0 Any additional outstanding changes to land? If not, I will proceed with the release by tomorrow. == Changes == - https://github.com/apache/cordova-eslint

Re: [VOTE] cordova-app-hello-world 5.0.0 Release

2020-04-12 Thread Bryan Ellis
sense > ✅ NOTICE and LICENSE file are present > > On Wed, Apr 8, 2020 at 2:29 AM Bryan Ellis wrote: > > > Please review and vote on this cordova-app-hello-world Major Release > v5.0.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > >

Re: [VOTE] cordova-app-hello-world 5.0.0 Release

2020-04-09 Thread Tim Brust
I vote +1: ✅ coho verify-archive ✅ Changes make sense ✅ NOTICE and LICENSE file are present On Wed, Apr 8, 2020 at 2:29 AM Bryan Ellis wrote: > Please review and vote on this cordova-app-hello-world Major Release v5.0.0 > by replying to this email (and keep discussion on the DISCUSS

Re: [VOTE] cordova-app-hello-world 5.0.0 Release

2020-04-09 Thread Jesse
+1 - coho verify-archive - reviewed code On Tue, Apr 7, 2020 at 7:28 PM Bryan Ellis wrote: > Please review and vote on this cordova-app-hello-world Major Release v5.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published

[VOTE] cordova-app-hello-world 5.0.0 Release

2020-04-07 Thread Bryan Ellis
Please review and vote on this cordova-app-hello-world Major Release v5.0.0 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-5.0.0 The package was published from its

[DISCUSS] cordova-app-hello-world 5.0.0 Major Release

2020-04-06 Thread Bryan Ellis
Does anyone have any reason to delay a cordova-app-hello-world major release (5.0.0)? Any additional outstanding changes to land? If not, I will start the release process tomorrow.

[GitHub] cordova-app-hello-world pull request #19: CB-12397 fix .gitignore for plugin...

2017-05-10 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/19 CB-12397 fix .gitignore for plugins & platforms ### Platforms affected All ### What does this PR do? Add `plugins` and `platforms

[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...

2017-04-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...

2017-04-24 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/18#discussion_r113055741 --- Diff: template_src/package.json --- @@ -0,0 +1,11 @@ +{ + "name": "hellocordova", --- End diff --

[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...

2017-04-21 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/18 CB-12684 : added package.json to default hello world app ### Platforms affected ### What does this PR do? Added package.json to default hello world

[ANNOUNCE] cordova-plugin-geolocation, cordova-create, cordova-app-hello-world released!

2016-10-05 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/783739548962390016 Blog: http://cordova.apache.org/news/2016/10/04/small-releases.html

[DRAFT] release blog post for create, app-hello-world and geolocation plugin.

2016-10-04 Thread Steven Gill
https://github.com/apache/cordova-docs/pull/647

Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-10-04 Thread Steven Gill
Sent: Monday, October 3, 2016 9:22 PM > To: dev@cordova.apache.org > Subject: Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release! > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and sub

RE: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-10-04 Thread Vladimir Kotikov (Akvelon)
...@gmail.com] Sent: Monday, October 3, 2016 9:22 PM To: dev@cordova.apache.org Subject: Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release! I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Ap

Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-10-03 Thread Shazron
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create (with new cordova-app-hello-world linked) * Built hello world app and ran on iOS

[VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-09-29 Thread Steven Gill
published from their corresponding git tags: cordova-app-hello-world: 3.11.0 (eb20135263) cordova-create: 1.0.1 (a1c3ecda8b) Upon a successful vote I will upload the archives to dist/, publish them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache

[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...

2016-09-29 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/17 CB-11938 updated csp to include content: for img-src You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-app

Re: [DISCUSS] cordova-app-hello-world@3.11.0

2016-09-28 Thread Shazron
+1 On Tue, Sep 27, 2016 at 3:27 PM, Steven Gill wrote: > Wanted to do a quick release for this. Just updated it to follow the > template docs a bit closer. > http://cordova.apache.org/docs/en/latest/guide/cli/template.html#create-a- > template >

[DISCUSS] cordova-app-hello-world@3.11.0

2016-09-27 Thread Steven Gill
Wanted to do a quick release for this. Just updated it to follow the template docs a bit closer. http://cordova.apache.org/docs/en/latest/guide/cli/template.html#create-a-template

[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...

2016-07-17 Thread brianleroux
Github user brianleroux closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...

2016-07-17 Thread brianleroux
Github user brianleroux closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...

2016-07-17 Thread brianleroux
GitHub user brianleroux reopened a pull request: https://github.com/apache/cordova-app-hello-world/pull/5 updated with feedback from cordova crew You can merge this pull request into a Git repository by running: $ git pull https://github.com/brianleroux/cordova-app-hello

[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...

2016-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread carynbear
Github user carynbear commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 @stevengill removed package.json from template_src, changed config.xml version to 1.0.0 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 LGTM otherwise :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets not add a `package.json` to template_src for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets update version in the default config.xml to be 1.0.0 instead of 0.0.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...

2016-06-15 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/16 CB-11412 Update templates to designate template source dir You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184885794 Cool, seems like we've reached a consensus. Merging! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-16 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184856505 LGTM. That third layer of binding always seemed confusing. :+1: --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-183448308 @axemclion Can you check now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52271030 --- Diff: www/js/index.js --- @@ -19,22 +19,20 @@ var app = { // Application Constructor initialize: function

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread axemclion
Github user axemclion commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52264119 --- Diff: www/js/index.js --- @@ -19,22 +19,20 @@ var app = { // Application Constructor initialize: function

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181674386 @dblotsky yes. Definitely needs dev list approval. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181673845 Will this also be going out as an email to the dev@ list? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181659458 @axemclion Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181630866 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-08 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/15 CB-10522: Event binding in Hello World is misleading The current event binding in the Hello World example is slightly misleading. So, fixing it. @nikhilkh @dblotsky

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-12-04 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror

2015-12-04 Thread BBosman
Github user BBosman closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[ANNOUNCEMENT] Cordova-app-hello-world@3.10.0 has been released!

2015-10-29 Thread Steven Gill
:D Also updated Android, iOS and Windows templates with this released version (for non cli usecases).

[GitHub] cordova-coho pull request: Update app-hello-world-release-process....

2015-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Update app-hello-world-release-process....

2015-10-29 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/99 Update app-hello-world-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-38

Re: [Vote] 3.10.0 Cordova App Hello World Release

2015-10-29 Thread Steven Gill
Thu, Oct 29, 2015 at 10:08 AM Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > I vote +1 > > > > * Ran coho verify-archive successfully > > * Created blank application using cordova-app-hello-world@3.10.0, build > > and ran successfull

Re: [Vote] 3.10.0 Cordova App Hello World Release

2015-10-29 Thread Carlos Santana
choo choo !! On Thu, Oct 29, 2015 at 10:08 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I vote +1 > > * Ran coho verify-archive successfully > * Created blank application using cordova-app-hello-world@3.10.0, build > and ran successfully > >

RE: [Vote] 3.10.0 Cordova App Hello World Release

2015-10-29 Thread Vladimir Kotikov (Akvelon)
I vote +1 * Ran coho verify-archive successfully * Created blank application using cordova-app-hello-world@3.10.0, build and ran successfully - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, October 29, 2015 5:20 AM To: dev

Re: [Vote] 3.10.0 Cordova App Hello World Release

2015-10-28 Thread Carlos Santana
+1 Review the new commits for release Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05) Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0 --dest test-hello/ and compare with dist

[Vote] 3.10.0 Cordova App Hello World Release

2015-10-26 Thread Steven Gill
Please review and vote on this 3.10.0 Cordova App Hello World Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9870 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist

Re: [DISCUSS] Cordova App Hello World Release

2015-10-26 Thread Steven Gill
RELEASE NOTES: https://github.com/apache/cordova-app-hello-world/blob/master/RELEASENOTES.md On Mon, Oct 26, 2015 at 4:36 PM, Steven Gill wrote: > Issue: https://issues.apache.org/jira/browse/CB-9870 > > On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill > wrote: > >> Does anyo

Re: [DISCUSS] Cordova App Hello World Release

2015-10-26 Thread Steven Gill
Issue: https://issues.apache.org/jira/browse/CB-9870 On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill wrote: > Does anyone have any reason to delay a cordova-app-hello-world release? > Any outstanding patches to land? > > >

[DISCUSS] Cordova App Hello World Release

2015-10-26 Thread Steven Gill
Does anyone have any reason to delay a cordova-app-hello-world release? Any outstanding patches to land?

[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...

2015-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...

2015-10-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146967713 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...

2015-10-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146869382 LGTM :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...

2015-10-09 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146835675 @omefire, thank you for review, I've addressed it. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...

2015-10-08 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146660710 I think we should also update package.json to explicitly mention the entry point (index.js) --- If your project is set up for it, you can reply to

[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...

2015-10-06 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/14 CB-9712 CLI 5.3 breaks with node 3.3.3 Added `index.js` so that the module can be required and resolved. [Jira issue](https://issues.apache.org/jira/browse/CB-9712) You can

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-12 Thread timwindsor
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-130459377 Thanks everyone - I've got a potential solution that we're testing here. We can close this request. --- If your project is set up for i

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-07 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128885973 Adding this to index.html should be a blackberry build step, I would expect this to only exist in the platform's www folder --- If your pr

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-07 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128835312 @jengee you don't have to get tired of update the template every time, you can implement a user land cordova hook after_prepare [1] [2]

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-07 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128833712 -1 hum this looks very ugly in the template. I don't like to have this in the default template. people might think that is a security

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-03 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/12#issuecomment-108547543 It's unclear what the intent of this PR is. Can you please close it? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-03 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/13#issuecomment-108547570 It's unclear what the intent of this PR is. Can you please close it? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
GitHub user Yamini-Sontakke opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/13 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
GitHub user Yamini-Sontakke opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/12 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
GitHub user Yamini-Sontakke reopened a pull request: https://github.com/apache/cordova-app-hello-world/pull/12 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
Github user Yamini-Sontakke closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
Github user Yamini-Sontakke commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/12#issuecomment-106285245 hell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
Github user Yamini-Sontakke commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/11#issuecomment-106284959 hello demo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
Github user Yamini-Sontakke closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-app-hello-world pull request: Useless change

2015-05-28 Thread Yamini-Sontakke
GitHub user Yamini-Sontakke opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/11 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514 Is this required for development time experience or every app needs access to localhost port 8472 to run on the phone? --- If your project is set up

Re: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread Jesse
Can we use a plugin hook to modify the csp in the bb10 start html page? localhost is not defined on most platforms afaik, so it may be less of an issue. @purplecabbage risingj.com On Wed, May 13, 2015 at 1:00 PM, Josh Soref wrote: > > https://github.com/apache/cordova-app-hello-world/p

RE: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread Josh Soref
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782 As long as this doesn't negatively impact other platforms, merge away. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread timwindsor
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101032363 Works for me - required for use of any plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/10 CB-9009 default CSP needs to include 8472 for blackberry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-app

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101026209 @timwindsor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [Vote] 3.9.0 Cordova App Hello World Release

2015-03-26 Thread Steven Gill
t; On Tue, Mar 24, 2015 at 9:29 AM, Ian Clelland > wrote: > > > +1 > > > > * Checked signatures and checksums > > * Verified contents against Git repo at 3.9.0 tag > > * Successfully built and ran hello world with Cordova-Android 3.7.1 and > > 4.0.0-dev (mast

Re: [Vote] 3.9.0 Cordova App Hello World Release

2015-03-25 Thread Andrew Grieve
+1 On Tue, Mar 24, 2015 at 9:29 AM, Ian Clelland wrote: > +1 > > * Checked signatures and checksums > * Verified contents against Git repo at 3.9.0 tag > * Successfully built and ran hello world with Cordova-Android 3.7.1 and > 4.0.0-dev (master) > > On Mon, Mar 23, 2015

[Vote] 3.9.0 Cordova App Hello World Release

2015-03-23 Thread Steven Gill
Please review and vote on this 3.9.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8731 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8731 The package was published from its corresponding

Re: [DISCUSS] Cordova App Hello World Release 3.9.0

2015-03-23 Thread Steven Gill
yes! On Mon, Mar 23, 2015 at 1:16 PM, Mark Koudritsky wrote: > +1 > > The code that uses NPM version of cordova-app-hello-world in cordova-lib is > currently on a branch > < > https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json >

Re: [DISCUSS] Cordova App Hello World Release 3.9.0

2015-03-23 Thread Mark Koudritsky
+1 The code that uses NPM version of cordova-app-hello-world in cordova-lib is currently on a branch <https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json>. Should we merge it now to start using the npm version of hello world? On Mon, Mar 23, 2015 a

Re: [DISCUSS] Cordova App Hello World Release 3.9.0

2015-03-23 Thread Steven Gill
Yup On Mar 23, 2015 11:50 AM, "Ian Clelland" wrote: > This includes > > https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f > , > right? > > If so, +1 for releasing! > > On Mon, Mar 23, 2015 at 1:54 PM, Steven

Re: [DISCUSS] Cordova App Hello World Release 3.9.0

2015-03-23 Thread Ian Clelland
This includes https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f, right? If so, +1 for releasing! On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill wrote: > Does anyone have any reason to delay a cordova-app-hello-world release? > Any outst

[DISCUSS] Cordova App Hello World Release 3.9.0

2015-03-23 Thread Steven Gill
Does anyone have any reason to delay a cordova-app-hello-world release? Any outstanding patches to land? If not, I will start the release this afternoon.

Re: App Hello World with default plugin (plus status update)

2015-03-23 Thread Gorkem Ercan
projects don't use iOS / Android, but I'm not sure there's a good alternative. Second: Seems there were some started tasks that have fallen silent: - Publishing app-hello-world to NPM (Steve - vote passed?) - CLI (so that it obeys within config.xml, and so that it can get plugins f

Re: App Hello World with default plugin (plus status update)

2015-03-20 Thread Steven Gill
I closed app hello world vote and published. Agree will need another release. On Mar 20, 2015 11:48 AM, "Andrew Grieve" wrote: > First: just committed a change to add the whitelist plugin to the default > app template: > > > https://git1-us-west.apache.org/repos/asf?p=co

App Hello World with default plugin (plus status update)

2015-03-20 Thread Andrew Grieve
re there's a good alternative. Second: Seems there were some started tasks that have fallen silent: - Publishing app-hello-world to NPM (Steve - vote passed?) - CLI (so that it obeys within config.xml, and so that it can get plugins from npm) Would like both of these things to happen (p

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)

2015-03-17 Thread Steven Gill
5 at 3:01 PM, Mark Koudritsky > wrote: > > > +1 > > Built and ran on > > - Android 5.0.2 on Nexus 7 > > - iOS simulator > > > > On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill > > wrote: > > > > > Please review and vot

  1   2   3   >