Re: I've fixed an issue. What's next?

2014-11-15 Thread Michal Mocny
plugman info org.apache.cordova.inappbrowser Returns a list of published plugin versions, a set of supported platforms, and a set of engine requirements for the current version plugman info org.apache.cordova.inappbrowser@0.5.3 Returns info for a particular older version. With these tools,

Re: I've fixed an issue. What's next?

2014-11-15 Thread julio cesar sanchez
I updated the pull request yesterday to add the iOS 8 macro code (and other change proposed by Shazron), so it can work on Xcode 5

Re: I've fixed an issue. What's next?

2014-11-14 Thread Ian Clelland
Well, I think what you've just done (pinging the list) is pretty close to the right next step. You should probably assign the issue back to Shaz with a note directed to him asking him to take a look and merge it in. (I'd merge it, but I haven't been following iOS 8 development closely enough to

Re: I've fixed an issue. What's next?

2014-11-14 Thread Shazron
Thanks Julio! I'll comment on the PR itself. Shaz On Fri, Nov 14, 2014 at 8:42 AM, Ian Clelland iclell...@chromium.org wrote: Well, I think what you've just done (pinging the list) is pretty close to the right next step. You should probably assign the issue back to Shaz with a note directed

Re: I've fixed an issue. What's next?

2014-11-14 Thread Shazron
General question to everybody: The patch requires the iOS 8 SDK (i.e. Xcode 6). We require Xcode 6 in cordova-ios 3.7.0 and there was consensus on it. However, the plugin.xml itself does not have an engine tag to specify what it supports. Question: Do we have engine tag support in the CLI,

Re: I've fixed an issue. What's next?

2014-11-14 Thread Ian Clelland
On Fri Nov 14 2014 at 2:24:41 PM Shazron shaz...@gmail.com wrote: General question to everybody: The patch requires the iOS 8 SDK (i.e. Xcode 6). We require Xcode 6 in cordova-ios 3.7.0 and there was consensus on it. However, the plugin.xml itself does not have an engine tag to specify what

Re: I've fixed an issue. What's next?

2014-11-14 Thread Jesse
Nope, just wait patiently. Someone will get to it soon. @purplecabbage risingj.com On Thu, Nov 13, 2014 at 11:31 PM, julio cesar sanchez jcesarmob...@gmail.com wrote: CB-7734 (https://issues.apache.org/jira/browse/CB-7734) was reported and I asked if it could be assigned to me. Shazron

Re: I've fixed an issue. What's next?

2014-11-14 Thread Steven Gill
Maybe we should have it auto grab an older version of the plugin that is supported? Or at least a better error message telling them to try older versions of the plugin with cordova plugin add org.apache.cordova.file@VERSION On Fri, Nov 14, 2014 at 11:49 AM, Michal Mocny mmo...@chromium.org wrote:

Re: I've fixed an issue. What's next?

2014-11-14 Thread Josh Soref
Michal Mocny wrote: I just added this to org.apache.cordova.file's plugin.xml as a test: engines engine name=cordova-ios version==4.0.0 / /engines Then tried to install that version locally in a project, and got: Installing org.apache.cordova.file for ios Failed to install

Re: I've fixed an issue. What's next?

2014-11-14 Thread Shazron
I know that it is unfortunate that's why I think the macro solution instead of the engine solution is best for core plugins (I discovered from the spec I could use 'apple-xcode' and 'apple-ios' to further differentiate, but never mind). We can take care of this as committers for the core plugins

Re: I've fixed an issue. What's next?

2014-11-14 Thread Josh Soref
Steven Gill wrote: Maybe we should have it auto grab an older version of the plugin that is supported? Or at least a better error message telling them to try older versions of the plugin with cordova plugin add org.apache.cordova.file@VERSION Ian Clelland wrote: I'd love to have the plugin

I've fixed an issue. What's next?

2014-11-13 Thread julio cesar sanchez
CB-7734 (https://issues.apache.org/jira/browse/CB-7734) was reported and I asked if it could be assigned to me. Shazron assigned to me and I fixed it with this pull request https://github.com/apache/cordova-plugin-dialogs/pull/39 It's been 3 weeks and it hasn't been merged, so I don't know if I