Re: Plugin Post Install Script

2015-03-10 Thread Michal Mocny
Thanks Steve! On Tue, Mar 10, 2015 at 12:18 PM, Steven Gill wrote: > Alright. Punted for now. Too early to talk about this. > On Mar 10, 2015 8:56 AM, "Michal Mocny" wrote: > > > I don't think this is a good idea, but I'm open to be convinced. > > > > However, cannot we punt this discussion for

Re: Plugin Post Install Script

2015-03-10 Thread Michal Mocny
I don't think this is a good idea, but I'm open to be convinced. However, cannot we punt this discussion for now? The current phase 1 rollout does not actually have us installing plugins to node_modules, so really this is an independant feature request to create a new workflow. I don't see the b

Re: Plugin Post Install Script

2015-03-10 Thread Steven Gill
Alright. Punted for now. Too early to talk about this. On Mar 10, 2015 8:56 AM, "Michal Mocny" wrote: > I don't think this is a good idea, but I'm open to be convinced. > > However, cannot we punt this discussion for now? The current phase 1 > rollout does not actually have us installing plugins

Re: Plugin Post Install Script

2015-03-09 Thread Steven Gill
On Mon, Mar 9, 2015 at 6:20 PM, Jesse wrote: > What does `npm i -g cordova-plugin-device` do? Just because things are > similar does not mean you should force them to be the same. I don't really > see a benefit in doing this though, and I think we are going to end up with > circular unresolvable

Re: Plugin Post Install Script

2015-03-09 Thread Jesse
What does `npm i -g cordova-plugin-device` do? Just because things are similar does not mean you should force them to be the same. I don't really see a benefit in doing this though, and I think we are going to end up with circular unresolvable dependencies. or at least greatly increased complexity

Plugin Post Install Script

2015-03-09 Thread Steven Gill
I think it is worth exploring a generic post install script plugin authors could include that would install the plugin into a cordova project after a npm install. I haven't had any time to actually explore this yet though. My initial reaction was that it would be hard to get right. After some thou