Re: Plugin Search

2022-10-24 Thread Norman Breau
Thanks for your input everybody. #2 is the clear winner. Erisu I guess already made a PR that follows this path at https://github.com/apache/cordova-docs/pull/1269 Cheers, Norman On 2022-10-23 5:36 p.m., Tim Brust wrote: +1 to #2 On Fri, Oct 21, 2022 at 5:48 PM Jesse wrote: #2 makes the

Re: Plugin Search

2022-10-23 Thread Tim Brust
+1 to #2 On Fri, Oct 21, 2022 at 5:48 PM Jesse wrote: > #2 makes the most sense to me too, easiest to support long term > > > On Oct 21, 2022, at 8:17 AM, julio cesar sanchez > wrote: > > > > +1 to option #2 > > > > Niklas, option 2 already mentions having a link to the npm search with > >

Re: Plugin Search

2022-10-21 Thread Jesse
#2 makes the most sense to me too, easiest to support long term > On Oct 21, 2022, at 8:17 AM, julio cesar sanchez > wrote: > > +1 to option #2 > > Niklas, option 2 already mentions having a link to the npm search with > cordova ecosystem prefilled for easier searching of other 3rd party

Re: Plugin Search

2022-10-21 Thread julio cesar sanchez
+1 to option #2 Niklas, option 2 already mentions having a link to the npm search with cordova ecosystem prefilled for easier searching of other 3rd party plugins El El vie, 21 oct 2022 a las 16:39, Niklas Merz escribió: > I'm +1 on #2, too. Making clear which plugins are Official and

Re: Plugin Search

2022-10-21 Thread Niklas Merz
I'm +1 on #2, too. Making clear which plugins are Official and supported actively is a good idea. And just a simple note on how to find more on npm is enough IMHO.  On October 21, 2022, Norman Breau wrote: > Hi Team, > > I want to reach a final verdict on how deal with the broken search > page 

Re: Plugin Search

2022-10-21 Thread George Henne
I agree with Norm: +1 on #2. The npmjs.com search works fairly well - it wouldn’t be worth trying to make something better. George Henne VoltBuilder Support > On Oct 21, 2022, at 10:23 AM, Norman Breau wrote: > > Hi Team, > > I want to reach a final verdict on how deal with the broken

Plugin Search

2022-10-21 Thread Norman Breau
Hi Team, I want to reach a final verdict on how deal with the broken search page at https://cordova.apache.org/plugins/ We have an active issue being tracked at https://github.com/apache/cordova-docs/issues/1128 but in summary, the rest service used to power the search has gone offline and

Re: Documentation and plugin search is not working

2018-08-20 Thread Chris Brody
probably > will migrate it to a Github Issue first and link it. > On Tue, Aug 14, 2018 at 11:56 AM Shazron wrote: > > > > Doc search issue: > > https://issues.apache.org/jira/browse/CB-14266 > > > > Plugin search issue: >

Re: Documentation and plugin search is not working

2018-08-20 Thread Shazron
wrote: > > Doc search issue: > https://issues.apache.org/jira/browse/CB-14266 > > Plugin search issue: > https://issues.apache.org/jira/browse/CB-14265 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.

Documentation and plugin search is not working

2018-08-13 Thread Shazron
Doc search issue: https://issues.apache.org/jira/browse/CB-14266 Plugin search issue: https://issues.apache.org/jira/browse/CB-14265 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail

Re: [DISCUSS] Plugin search is broken

2017-03-24 Thread Kerri Shotts
errisho...@gmail.com> wrote: > >> +1 to moving off npmsearch. >> >> While I’m thinking of it — where does the code for the plugin search live? >> I found variations on it, but not sure I ever came across the canonical >> version. >> >> ~

Re: [DISCUSS] Plugin search is broken

2017-03-24 Thread Shazron
Here: https://github.com/apache/cordova-docs/blob/a3589ce66336821f2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js On Fri, Mar 24, 2017 at 5:36 AM, Kerri Shotts <kerrisho...@gmail.com> wrote: > +1 to moving off npmsearch. > > While I’m thinking of it — where does the code for th

Re: [DISCUSS] Plugin search is broken

2017-03-24 Thread Kerri Shotts
+1 to moving off npmsearch. While I’m thinking of it — where does the code for the plugin search live? I found variations on it, but not sure I ever came across the canonical version. ~ Kerri > On Mar 23, 2017, at 16:04, Shazron <shaz...@apache.org> wrote: > > I'm going to

Re: [DISCUSS] Plugin search is broken

2017-03-23 Thread Shazron
I'm going to assume by lazy consensus that moving off npmsearch is a 'go'. Filed: https://issues.apache.org/jira/browse/CB-12602 Currently our plugin search works after I filed those two issues in their repo and they were was fixed, thus fixing our search. On Sun, Mar 19, 2017 at 4:36 PM

Re: [DISCUSS] Plugin search is broken

2017-03-19 Thread Shazron
; can't find plugins, and I don't think they know of a search alternative. >>>> >>>> In the near term, I think we should tweet how to search for plugins >>>> using npmjs.com >>>> >>>> [1] https://twitter.com/edeortuzar/status/84331057610114

Re: [DISCUSS] Plugin search is broken

2017-03-19 Thread Shazron
now of a search alternative. >>> >>> In the near term, I think we should tweet how to search for plugins >>> using npmjs.com >>> >>> [1] https://twitter.com/edeortuzar/status/843310576101146625 >>> [2] https://twitter.com/kumakumadev/sta

Re: [DISCUSS] Plugin search is broken

2017-03-19 Thread Jesse
t; In the near term, I think we should tweet how to search for plugins using >>> npmjs.com >>> >>> [1] https://twitter.com/edeortuzar/status/843310576101146625 >>> [2] https://twitter.com/kumakumadev/status/843149557127155712 >>> [3] https://twitt

Re: [DISCUSS] Plugin search is broken

2017-03-19 Thread Shazron
gt; >> [1] https://twitter.com/edeortuzar/status/843310576101146625 >> [2] https://twitter.com/kumakumadev/status/843149557127155712 >> [3] https://twitter.com/quangv/status/842925319254360064 >> [4] https://twitter.com/skumarSDsoft/status/842677001433497600 >> >

Re: [DISCUSS] Plugin search is broken

2017-03-19 Thread Shazron
tter.com/edeortuzar/status/843310576101146625 > [2] https://twitter.com/kumakumadev/status/843149557127155712 > [3] https://twitter.com/quangv/status/842925319254360064 > [4] https://twitter.com/skumarSDsoft/status/842677001433497600 > > > > > On Sun, Mar 19, 2017 at 1:19 PM, S

Re: [DISCUSS] Plugin search is broken

2017-03-19 Thread Shazron
://twitter.com/kumakumadev/status/843149557127155712 [3] https://twitter.com/quangv/status/842925319254360064 [4] https://twitter.com/skumarSDsoft/status/842677001433497600 On Sun, Mar 19, 2017 at 1:19 PM, Shazron <shaz...@apache.org> wrote: > ### PROBLEM > > Plugin s

[DISCUSS] Plugin search is broken

2017-03-19 Thread Shazron
### PROBLEM Plugin search is broken. ### DESCRIPTION Page: http://cordova.apache.org/plugins/ JIRA: https://issues.apache.org/jira/browse/CB-12579 Q: How does the plugin search work? A: Page Source: http://cordova.apache.org/plugins and the source (this specific line): http://svn.apache.org

[GitHub] cordova-docs issue #642: CB-10929 added OXS filter button to plugin search a...

2016-09-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/642 Send a new pr. I already closed this one :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs issue #642: CB-10929 added OXS filter button to plugin search a...

2016-09-26 Thread audreyso
gt; Date: Monday, September 26, 2016 at 4:46 PM To: apache/cordova-docs <cordova-d...@noreply.github.com> Cc: auso <a...@adobe.com>, Author <aut...@noreply.github.com> Subject: Re: [apache/cordova-docs] CB-10929 added OXS filter button to plugin searc

[GitHub] cordova-docs issue #642: CB-10929 added OXS filter button to plugin search a...

2016-09-26 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-docs/pull/642 With 10.12, Apple rebranded their desktop OS to `macOS`. Maybe we want to say `OSX / macOS`? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-03 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153361722 sounds good. thanks @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-02 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153214572 Lets merge this in after the 5.4.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: CB-9901 cordova plugin search opens in a browser

2015-10-30 Thread Carlos Santana
PL is fine ( > http://www.apache.org/legal/resolved.html#category-a). > > Tim > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Friday, October 30, 2015 12:00 PM > To: dev@cordova.apache.org > Subject: Re: CB-9901 cordova plugin search opens in

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread csantanapr
when they get started to use the CLI. not applicable to unattended. The current form is just a mess of a UI/UX. For scripting or unattended like gulp scripts I guess they can use npmsearh same way we are doing for the website plugin search. --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152566519 LGTM this is a good one to fix. There is a jshint failure though that you might want to fix. --- If your project is set up for it, you can reply to this email

RE: CB-9901 cordova plugin search opens in a browser

2015-10-30 Thread Tim Barham
plugin search opens in a browser I would MUCH rather just remove search functionality from the cli. One less hook to worry about, one less feature to support, and we don't need to add a dependency to do it. Opener is nice because it has zero dependencies, I'm just not sure how compatible we

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152596207 Thanks @nikhilkh! I'll take a look at the jshint failure and fix it --- If your project is set up for it, you can reply to this email and have your reply appear

Re: CB-9901 cordova plugin search opens in a browser

2015-10-30 Thread Jesse
> > > > > > Hi all, > > > > I have made a change to have the cordova plugin search command open the > > browser to 'http://cordova.apache.org/plugins/?q='. Nikhil > > has > > reviewed the changes already and they look good. But I just w

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152610676 What about people who use Cordova-lib from gulp instead of the cli ? Does it make sense to pop open a browser window ? --- If your project is set up for it,

CB-9901 cordova plugin search opens in a browser

2015-10-30 Thread Edna Y Morales
Hi all, I have made a change to have the cordova plugin search command open the browser to 'http://cordova.apache.org/plugins/?q='. Nikhil has reviewed the changes already and they look good. But I just wanted to make sure the community is good with this change before I merge it in. Thanks

Re: CB-9901 cordova plugin search opens in a browser

2015-10-30 Thread Steven Gill
Sounds good to me. I don't think search is used much anyways in its current form. On Fri, Oct 30, 2015 at 11:31 AM, Edna Y Morales <eymor...@us.ibm.com> wrote: > > > Hi all, > > I have made a change to have the cordova plugin search command open the > browser to 'h

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152611628 @omefire I've started a discussion thread for this on the dev list --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152612090 Are people likely to be doing a plugin search from a gulp script? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-29 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-lib/pull/334 CB-9901 cordova plugin search opens in a browser You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-lib CB-9901

[GitHub] cordova-docs pull request: Enabled plugin search over HTTPS

2015-10-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/380#issuecomment-147017715 Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Enabled plugin search over HTTPS

2015-10-09 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/380 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Enabled plugin search over HTTPS

2015-10-09 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/380 Enabled plugin search over HTTPS You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website-plugin-https

[GitHub] cordova-docs pull request: Added plugin search js from cordova-reg...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Added plugin search js from cordova-reg...

2015-08-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/306#issuecomment-132827839 LGTM. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Added plugin search js from cordova-reg...

2015-08-19 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/306 Added plugin search js from cordova-registry-web Adds the React javascript for the NPM plugin search from cordova-registry-web so that it can be integrated into the plugins page. The React

RE: Proposal: Cordova Plugin Search

2015-06-15 Thread Murat Sutunc
- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, June 12, 2015 9:39 PM To: dev@cordova.apache.org Subject: Re: Proposal: Cordova Plugin Search Why we can't re-use some of the web app code that currently uses the cpr I like the UI, just change how to query the data logic

Re: Proposal: Cordova Plugin Search

2015-06-12 Thread Carlos Santana
. It might be nice to turn this search functionality (with the blacklist) into a module others can incorporate into their tools. We could potentially use it in the cordova cli (cordova plugin search) and maybe some of the IDE developers here could use it as well. On Wed, Jun 10, 2015 at 2

Re: Proposal: Cordova Plugin Search

2015-06-11 Thread Steven Gill
Nice list of tasks. I'll try to find some time to look at the PR in the next few days. It might be nice to turn this search functionality (with the blacklist) into a module others can incorporate into their tools. We could potentially use it in the cordova cli (cordova plugin search) and maybe

RE: Proposal: Cordova Plugin Search

2015-06-10 Thread Murat Sutunc
I've updated the cordova-discussion with tasks and bugs, so it's more clear what's planned for search page: https://github.com/cordova/cordova-discuss/issues/7#issuecomment-110893889 1 - Yes, the goal for this page is to eventually replace current plugin search page. CPR will be read-only

Re: Proposal: Cordova Plugin Search

2015-06-10 Thread Victor Sosa
, looks great! On Tue, Jun 9, 2015 at 7:44 PM Murat Sutunc mura...@microsoft.com wrote: I’ve created a PR for the first iteration of plugin search page. You can find the PR at https://github.com/apache/cordova-registry-web/pull/11 Current known issues: - Search should lowercase queries

Re: Proposal: Cordova Plugin Search

2015-06-10 Thread Victor Sosa
://github.com/cordova/cordova-discuss/issues/7#issuecomment-110893889 1 - Yes, the goal for this page is to eventually replace current plugin search page. CPR will be read-only on july 15th and everyone here agreed that using npmjs.com isn't the best experience when it comes to plugin searching. The idea

RE: Proposal: Cordova Plugin Search

2015-06-09 Thread Murat Sutunc
I’ve created a PR for the first iteration of plugin search page. You can find the PR at https://github.com/apache/cordova-registry-web/pull/11 Current known issues: - Search should lowercase queries - Platform tags don't look good on ipad/iphone -Original Message- From: Joerg Holz

Re: Proposal: Cordova Plugin Search

2015-06-06 Thread Joerg Holz
you think! Thanks, Murat -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Wednesday, June 3, 2015 11:41 AM To: dev@cordova.apache.org Subject: Proposal: Cordova Plugin Search Hey everyone, I've seen couple folks mention the idea of turning

RE: Proposal: Cordova Plugin Search

2015-06-05 Thread Murat Sutunc
To: dev@cordova.apache.org Subject: Proposal: Cordova Plugin Search Hey everyone, I've seen couple folks mention the idea of turning plugins.cordova.io into a Gulp Yeoman style search page on dev mailing list. I've gone ahead and created a proposal for how we might potentially tackle this problem

Proposal: Cordova Plugin Search

2015-06-03 Thread Murat Sutunc
Hey everyone, I've seen couple folks mention the idea of turning plugins.cordova.io into a Gulp Yeoman style search page on dev mailing list. I've gone ahead and created a proposal for how we might potentially tackle this problem. Please see the extended discussion at GH:

Re: Review Request 16854: Use plugin search path in cordova-cli

2014-01-14 Thread Michal Mocny
.* *Bugs: * CB-5006 https://issues.apache.org/jira/browse/CB-5006 *Repository: * cordova-cli Description Same diff on github:https://github.com/kamrik/cordova-cli/compare/searchpath cordova plugin add will pass a plugin search path to plugman. The search path is read from .cordova/config.json

Re: Review Request 16854: Use plugin search path in cordova-cli

2014-01-14 Thread Andrew Grieve
request for cordova. Bugs: CB-5006 https://issues.apache.org/jira/browse/CB-5006 Repository: cordova-cli Description --- Same diff on github: https://github.com/kamrik/cordova-cli/compare/searchpath cordova plugin add will pass a plugin search path to plugman. The search

Re: Review Request 16854: Use plugin search path in cordova-cli

2014-01-14 Thread Andrew Grieve
, 5:34 a.m.) Review request for cordova. Bugs: CB-5006 https://issues.apache.org/jira/browse/CB-5006 Repository: cordova-cli Description --- Same diff on github: https://github.com/kamrik/cordova-cli/compare/searchpath cordova plugin add will pass a plugin search

Review Request 16854: Use plugin search path in cordova-cli

2014-01-13 Thread Mark Koudritsky
/browse/CB-5006 Repository: cordova-cli Description --- Same diff on github: https://github.com/kamrik/cordova-cli/compare/searchpath cordova plugin add will pass a plugin search path to plugman. The search path is read from .cordova/config.json and can also be provided on the command line

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-08 Thread Mark Koudritsky
for local plugin search path. The param accepts a colon separated list of dirs that are searched in order for subdirs containing a plugin.xml file with the requested plugin ID. Diffs - doc/help.txt 0c6ad7a main.js 5fa6422 plugman.js a7ff484 src/fetch.js 0d50187 src

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-08 Thread Michal Mocny
here is missing author info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch| git am Add --searchpath option for local plugin search path. The param accepts a colon separated list of dirs

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-08 Thread Andrew Grieve
here is missing author info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch| git am Add --searchpath option for local plugin search path. The param accepts a colon separated list

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-08 Thread Marcel Kinard
On Jan 8, 2014, at 10:17 AM, Andrew Grieve agri...@chromium.org wrote: Yeah, I think we're still as a team doing a bit of a bad job of documenting features. I also think that there are shortcomings in the user-facing documentation. It's definitely better than it used to be, but there is

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-08 Thread Brian LeRoux
--- The diff here is missing author info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch| git am Add --searchpath option for local plugin search path. The param accepts a colon

Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Mark Koudritsky
/browse/CB-5006 Repository: cordova-plugman Description --- The diff here is missing author info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch | git am Add --searchpath option for local plugin

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Braden Shepherdson
info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch | git am Add --searchpath option for local plugin search path. The param accepts a colon separated list of dirs that are searched in order

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Braden Shepherdson
-plugman/compare/searchpath.patch | git am Add --searchpath option for local plugin search path. The param accepts a colon separated list of dirs that are searched in order for subdirs containing a plugin.xml file with the requested plugin ID. Diffs - doc/help.txt 0c6ad7a

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Mark Koudritsky
together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch | git am Add --searchpath option for local plugin search path. The param accepts a colon separated list of dirs that are searched in order for subdirs containing a plugin.xml file

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Josh Soref
Could you *please* provide a sample tar ball or zip file containing a sample plugin or two and an associated command line which would work with it?  If not an actual archive, I'd be more than happy to have a script to create a compatible archive.  Something to actually show what goes into the

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Mark Koudritsky
There is no special structure, the serachpath is expected to contain plugins just as they are in git repo. The typical workflow would be: mkdir local_registry cd local_registry git clone https://github.com/apache/cordova-plugin-file Optionally git clone some other plugins and possibly modify them

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Josh Soref
If I have: /tmp/world/A/b/plugin‎ /tm‎p/world/A/magic-pligin /tmp‎/world/some-plugin And ‎I try: plugman install  --platform android --project /.../myproject/platforms/android --plugin org.apache.cordova.file \                   --searchpath /tmp/world Which directories are searched? It

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Mark Koudritsky
That's right, it will not recourse down the tree and will only look for plugin.xml one level down. It's easy to change it to walk the entire tree, but I'm not sure whether that's needed / wanted, would love some feedback on that. On Tue, Jan 7, 2014 at 6:36 PM, Josh Soref

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Anis KADRI
It doesn't hurt to have findLocalPlugin recursive. Does it? Some might expect it (let's say if plugins are categorized into folders/sub-folders). It doesn't hurt to comment on review board directly either. On Tue, Jan 7, 2014 at 4:56 PM, Mark Koudritsky kam...@google.com wrote: That's right,

Re: Review Request 16701: Add --searchpath option for local plugin search path

2014-01-07 Thread Axel Nennker
Repository: cordova-plugman Description --- The diff here is missing author info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch | git am Add --searchpath option for local plugin search path