RE: Plugman engine check and WP7/8

2013-10-23 Thread Sergey Grebnov (Akvelon)
check and WP7/8 Howdy all, I like Carlos' suggestions in this jira ticket for dealing with Windows scripts:https://issues.apache.org/jira/browse/CB-5187 Appending a .bat or using cmd /c seem pretty easy fixes in this case. I'm +1 either way. I propose to think about 'cordova'

Re: Plugman engine check and WP7/8

2013-10-23 Thread Tim Kim
Howdy all, I like Carlos' suggestions in this jira ticket for dealing with Windows scripts:https://issues.apache.org/jira/browse/CB-5187 Appending a .bat or using cmd /c seem pretty easy fixes in this case. I'm +1 either way. I propose to think about 'cordova' engine settings (in default-engines.

Re: Plugman engine check and WP7/8

2013-10-23 Thread Josh Soref
On 10/23/13 2:23 PM, "Carlos Santana" wrote: >Actually just try it out and see that using spawn with "cmd" >["/c","cordova/build",... >is better option than adding the ".bat" then it covers "build.exe", >"build.bat", and "build.cmd" on windows > >if someone thinks this is bad route, please shime i

RE: Plugman engine check and WP7/8

2013-10-23 Thread Sergey Grebnov (Akvelon)
o same reason Are you ok if I create ticket for this specific bug (plugman + wp78) and fix it as per steps 1 and 2 above? Thx! Sergey -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Wednesday, October 23, 2013 10:23 PM To: dev@cordova.apache.org Subject: Re: Plugma

Re: Plugman engine check and WP7/8

2013-10-23 Thread Carlos Santana
Actually just try it out and see that using spawn with "cmd" ["/c","cordova/build",... is better option than adding the ".bat" then it covers "build.exe", "build.bat", and "build.cmd" on windows if someone thinks this is bad route, please shime in this jira issue [1] [1]: https://issues.apache.or

Re: Plugman engine check and WP7/8

2013-10-23 Thread Carlos Santana
Thanks Bryan for pointing out; I created a jira issue to address the "compile, emualate, run" using spawn and not addressing windows ".bat" https://issues.apache.org/jira/browse/CB-5187 I'm guessing the fix is to detect that node environment is Windows and append ".bat" to cmd for child process s

Re: Plugman engine check and WP7/8

2013-10-23 Thread Bryan Higgins
I know Carlos just changed several CLI commands to use spawn. There doesn't seem to be any specific handling for Windows. https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=01c7ecec7ccf4a3c1423ddf3844e125d24965025 On Wed, Oct 23, 2013 at 10:44 AM, Braden Shepherdson wrote: > I

Re: Plugman engine check and WP7/8

2013-10-23 Thread Braden Shepherdson
I thought we were shelling out that command, not trying to load the file. Then Windows would locate the version.bat file and run it, while Unixy platforms would see the version file with +x, and run it. Are we no longer going through the shell? (This should be using child_process.exec, not .spawn,

Re: Plugman engine check and WP7/8

2013-10-23 Thread Bryan Higgins
This issue has to do with the host system rather than platform. Android and BB10 both have version.bat files. On Wed, Oct 23, 2013 at 9:56 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Hi, > > #1 The problem > Right now the simplest (and also the most correct IMO) way to specif

Plugman engine check and WP7/8

2013-10-23 Thread Sergey Grebnov (Akvelon)
Hi, #1 The problem Right now the simplest (and also the most correct IMO) way to specify plugin restrictions to specific cordova version is the following: plugin.xml: But in this case as per plugman engines definition (plugman/src/util/default-engines.js) plugman will always try to fi