Re: [GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-16 Thread Darryl Pogue
On 16 March 2015 at 22:54, Jesse wrote: > They are independent no? > Is this plugin relying on cordova-android 4.0? Or vice versa The plugin doesn't rely on cordova-android 4.0, but this change fixes a crash on Android 4.0-4.3 when using File Transfer and Crosswalk together (which is the big feat

Re: [GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-16 Thread Jesse
They are independent no? Is this plugin relying on cordova-android 4.0? Or vice versa > On Mar 16, 2015, at 8:39 PM, dpogue wrote: > > Github user dpogue commented on the pull request: > > > https://github.com/apache/cordova-plugin-file-transfer/pull/68#issuecomment-82073797 > >/cc

RE: [GitHub] cordova-windows pull request: Fix for callback invocation with NO_...

2015-03-11 Thread Rob Paveza
Only question is if callback.status might be undefined (stands to reason if it can be null). If so, the present check is insufficient and changes because you test with ===. -Rob -Original Message- From: robpaveza [mailto:g...@git.apache.org] Sent: Wednesday, March 11, 2015 11:14 PM To

RE: [GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because

2015-02-20 Thread Jon Buckley
Hello Apache Cordova devs! I've submitted a patch ( https://github.com/apache/cordova-firefoxos/pull/22 ) to fix https://issues.apache.org/jira/browse/CB-7567 . I've emailed my ICLA in, so I'm wondering what the next step is? Could I get a review from someone? Thanks, Jon

Re: [GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...

2015-02-11 Thread Andrew Grieve
ah, I missed that lstatSync throws an exception for non-string args. I suppose that's fine. Will merge! On Wed, Feb 11, 2015 at 2:54 PM, omefire wrote: > Github user omefire commented on a diff in the pull request: > > https://github.com/apache/cordova-lib/pull/162#discussion_r24527527 > >

Re: [GitHub] cordova-wp8 pull request: CB-8412

2015-02-06 Thread Jesse
http://www.appveyor.com/docs/installed-software @purplecabbage risingj.com On Fri, Feb 6, 2015 at 1:28 AM, muratsu wrote: > Github user muratsu commented on the pull request: > > https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662 > > On build 103 you can see this error

Re: [GitHub] cordova-plugin-device pull request: Fixes a syntax error introduce...

2015-02-04 Thread Jesse
oops, thank you! @purplecabbage risingj.com On Wed, Feb 4, 2015 at 5:47 PM, nikhilkh wrote: > Github user nikhilkh commented on the pull request: > > > https://github.com/apache/cordova-plugin-device/pull/30#issuecomment-72979743 > > @purplecabbage - Can you please commit this? This is bre

RE: [GitHub] cordova-coho pull request: CB-8375 Improve windows support for for...

2015-02-03 Thread Murat Sutunc
Can someone take a look at this PR? Thanks, Murat -Original Message- From: muratsu [mailto:g...@git.apache.org] Sent: Wednesday, January 28, 2015 3:57 PM To: dev@cordova.apache.org Subject: [GitHub] cordova-coho pull request: CB-8375 Improve windows support for for... GitHub user mura

RE: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-29 Thread Tim Barham
ests previously). -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Thursday, January 29, 2015 12:04 PM To: dev@cordova.apache.org Subject: Re: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe... The tests are only failing on Travis, which is ru

Re: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-29 Thread Jesse
The tests are only failing on Travis, which is running MacOS, so it is probably just related to path separators. @purplecabbage risingj.com On Thu, Jan 29, 2015 at 11:27 AM, Tim Barham wrote: > Thanks Jesse. Do you have any thoughts on the test failures? The failures > appear to be related to m

RE: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-01-29 Thread Tim Barham
Thanks Jesse. Do you have any thoughts on the test failures? The failures appear to be related to my directory renaming - but the tests pass locally, and the commits look good (and identical to what I have locally). -Original Message- From: purplecabbage [mailto:g...@git.apache.org] Sen

Re: [GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

2015-01-14 Thread Jesse
Either way is fine. @purplecabbage risingj.com On Wed, Jan 14, 2015 at 6:27 PM, whitecolor wrote: > Github user whitecolor commented on the pull request: > > > https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-70030634 > > Sorry, my bad, would you like me to do a rebase or

RE: [GitHub] cordova-lib pull request: CB-8225: Add Unit Tests for platform.js/...

2014-12-30 Thread Harun Kazaz
I am unable to unsubscribe through automatic means. Can someone help me top stop these e-mails, PLEASE! -Original Message- From: omefire [mailto:g...@git.apache.org] Sent: Tuesday, December 30, 2014 9:17 PM To: dev@cordova.apache.org Subject: [GitHub] cordova-lib pull request: CB-8225: A

Re: [GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...

2014-12-11 Thread Jesse
Sorry James, just realized I called you Jim ... Call me whatever you want. @purplecabbage risingj.com On Thu, Dec 11, 2014 at 1:08 PM, purplecabbage wrote: > Github user purplecabbage commented on the pull request: > > > https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-66688

Re: [GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-12-07 Thread Jesse
It looks like it's just to generate names of days, using a known month/year which starts on a Sunday by the looks of it. > On Dec 7, 2014, at 4:13 AM, sgrebnov wrote: > > Github user sgrebnov commented on a diff in the pull request: > > > https://github.com/apache/cordova-plugin-globaliz

Re: [GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-25 Thread Jesse
What I meant is, just being able to add a single .js and .cs file instead of the overhead of dependent projects. You'll have to wait for the proof of concept though. @purplecabbage risingj.com On Tue, Nov 25, 2014 at 1:10 PM, daserge wrote: > Github user daserge commented on the pull request: >

Re: [GitHub] cordova-plugin-file-transfer pull request: CB-7944 Pending unsuppo...

2014-11-14 Thread Ian Clelland
Looks good, thanks! I've pushed it up to master. On Fri Nov 14 2014 at 8:11:27 AM MariaBukharina wrote: > Github user MariaBukharina commented on the pull request: > > https://github.com/apache/cordova-plugin-file-transfer/ > pull/48#issuecomment-63062423 > > Thaks for you comments! >

Re: [GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread Jesse
Merged, and de-BOM'd @purplecabbage risingj.com On Thu, Nov 13, 2014 at 3:48 PM, asfgit wrote: > Github user asfgit closed the pull request at: > > https://github.com/apache/cordova-plugin-file/pull/88 > > > --- > If your project is set up for it, you can reply to this email and have your >

Re: [GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread Jesse
Next test, one of you commit a project that includes a plugin, + ios + windows platforms, and see if the other can build/run it ... @purplecabbage risingj.com On Wed, Nov 5, 2014 at 2:20 PM, martincgg wrote: > Github user martincgg commented on the pull request: > > https://github.com/apac

Re: [GitHub] cordova-lib pull request: Breaking src into submodules

2014-11-05 Thread Jesse
I was planning on going back and looking at this, essentially just to glean info before the re-do. This will never rebase/merge, so it is essentially dead otherwise. We can close it for the sake of tidiness. @purplecabbage risingj.com On Wed, Nov 5, 2014 at 6:46 AM, mmocny wrote: > Github user

Re: [GitHub] cordova-plugin-file-transfer pull request: CRC downloaded files ov...

2014-11-04 Thread Josh Soref
GitHub user AlBevi opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/47 This needs a JIRA bug report. And for any platforms it isn't fixing, it needs a JIRA bug. ‎ - To unsubscribe, e-mail: dev-u

Re: [GitHub] cordova-coho pull request: Cb-7904: Pull request for nightlys

2014-10-30 Thread Josh Soref
‎Insert a space after "if" here https://github.com/apache/cordova-coho/pull/58#discussion_r19606268 --- Diff: src/repoutil.js --- @@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) { var newPath = isInForEachRepoFunction ? path.join('..', repo.repoName) : repo.repoName; isInForE

Re: [GitHub] cordova-lib pull request: CB-6992 Fix add/prepare/build issues for...

2014-10-24 Thread Josh Soref
I thought we agreed to use fixed directory names to avoid this ‎ Sent from my BlackBerry 10 smartphone. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-lib pull request: Check for a CORDOVA_HOME environment var...

2014-10-11 Thread Josh Soref
https://github.com/apache/cordova-lib/pull/104 > commit 4919a9846c65700a4650a214986e4aff53662579 > Author: System Administrator The author field should be correct...‎

Re: [GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...

2014-10-10 Thread Andrew Grieve
Good call. On Fri, Oct 10, 2014 at 2:14 PM, purplecabbage wrote: > Github user purplecabbage commented on the pull request: > > https://github.com/apache/cordova-coho/pull/52#issuecomment-58695256 > > We should stop closing issues from other repositories, since @asfgit > closing it does

Re: [GitHub] cordova-lib pull request: [CB-5989] - Default to $PROJECT_NAME-Inf...

2014-09-30 Thread Gorkem Ercan
Can you explain? This bug is not related to android, or use of project name Unless iOS name defaults to the lowest order character, there is a chance that a plist file brought in by a custom framework gets precedence and fails the configuration update for plist. On Mon, Sep 29, 2014 at 11:10 PM, J

Re: [GitHub] cordova-browser pull request: Add generic Linux support to 'run' s...

2014-09-30 Thread Josh Soref
‎-1 Use xdg-open or something. Expecting chromium to be in the path seems unreasonable.  ‎ Sent from my BlackBerry 10 smartphone.

Re: [GitHub] cordova-lib pull request: [CB-5989] - Default to $PROJECT_NAME-Inf...

2014-09-29 Thread Josh Soref
-1. ‎We're in the process of fixing Android bugs related to using project names in file system artifacts. 

RE: [GitHub] cordova-windows pull request: CB-7452 Windows. Rewrite ApplyPlatfo...

2014-09-11 Thread Sergey Grebnov (Akvelon)
Hi Jesse, thank you for update and review! Sergey -Original Message- From: purplecabbage [mailto:purplecabb...@gmail.com] Sent: Thursday, September 11, 2014 7:20 AM To: dev@cordova.apache.org Subject: Re: [GitHub] cordova-windows pull request: CB-7452 Windows. Rewrite ApplyPlatfo... Hi

Re: [GitHub] cordova-windows pull request: CB-7452 Windows. Rewrite ApplyPlatfo...

2014-09-10 Thread purplecabbage
Hi Sergey, I am moving, so mobile only until next week. My high level browse of your code seemed fine though. > On Sep 9, 2014, at 1:13 AM, sgrebnov wrote: > > Github user sgrebnov commented on the pull request: > >https://github.com/apache/cordova-windows/pull/42#issuecomment-54937775 >

Re: [GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-01 Thread purplecabbage
We don't need an cla for a 1 line documentation fix. Ultimately this is a defect in the plugin, and should be fixed. Documenting the quirk helps in the meantime, until it is fixed for Android and ios. > On Aug 1, 2014, at 2:22 PM, lorinbeer wrote: > > Github user lorinbeer commented on the pu

Re: [GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...

2014-07-18 Thread Axel Nennker
What do you mean with "blank splash"? Splash without src? If yes then I consider this illegal anyway. I tested these cases on Android: - no splash in config.xml - one default splash. No density. - all densities that exist in project. - one density (xhdpi) All worked. Axel PS: I am traveling and

Re: [GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...

2014-07-16 Thread Axel Nennker
fixed 2014-07-16 20:29 GMT+02:00 VVelda : > Github user VVelda commented on the pull request: > > https://github.com/apache/cordova-lib/pull/58#issuecomment-49206968 > > Changes deletes also icons and splashscreen in new blank project, > which is bad. That should not to be done, until is

Re: [GitHub] cordova-wp8 pull request: CB-5049 Create defaults.xml that contain...

2014-07-15 Thread purplecabbage
Sounds good. Sent from my iPhone > On Jul 15, 2014, at 5:29 AM, sgrebnov wrote: > > Github user sgrebnov commented on the pull request: > >https://github.com/apache/cordova-wp8/pull/46#issuecomment-49024255 > >There is a reference to config.xml in template, but it is automatically >

Re: [GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-14 Thread Josh Soref
I need to sleep Sent from my BlackBerry 10 smartphone. Original Message From: Axel Nennker Sent: Tuesday, July 15, 2014 2:54 AM To: dev Reply To: dev@cordova.apache.org Subject: Re: [GitHub] cordova-docs pull request: CB-3571: update the docs for the splash... I will put it back in although

Re: [GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-14 Thread Axel Nennker
I will put it back in although I do not know how it ever worked in Cordova CLI. Can someone please explain? I thought that the former doc was outdated. There is no support in blackberry10_parser.js I will try the bb10 emulator. Axel Am 15.07.2014 08:38 schrieb "sgrebnov" : > Github user sgrebnov

Re: [GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-14 Thread Axel Nennker
Could you please give a reason for your -1? Am 15.07.2014 08:30 schrieb "jsoref" : > Github user jsoref commented on the pull request: > > https://github.com/apache/cordova-docs/pull/220#issuecomment-48995182 > > -1 don't commit this. > > > --- > If your project is set up for it, you can r

Re: [GitHub] cordova-docs pull request: CB-3571: update the docs for the splash...

2014-07-14 Thread Axel Nennker
Because that content referred to Phonegap Build not Cordova. Am 15.07.2014 08:19 schrieb "jsoref" : > Github user jsoref commented on the pull request: > > https://github.com/apache/cordova-docs/pull/220#issuecomment-48994596 > > Why is the BlackBerry 10 content being removed? > > > --- >

Re: [GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...

2014-07-14 Thread Axel Nennker
Merge artefact. Am 15.07.2014 03:46 schrieb "kamrik" : > Github user kamrik commented on a diff in the pull request: > > https://github.com/apache/cordova-lib/pull/58#discussion_r14914123 > > --- Diff: cordova-lib/src/cordova/metadata/android_parser.js --- > @@ -42,6 +42,12 @@ module.e

Re: [GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread Axel Nennker
s/ettigns/ettings/g Am 10.07.2014 21:02 schrieb "sgrebnov" : > GitHub user sgrebnov opened a pull request: > > https://github.com/apache/cordova-lib/pull/57 > > CB-7118 iOS: add target-device and MinimumOSVersion support to > config.xml > > https://issues.apache.org/jira/browse/CB-7118

Re: GitHub write access

2014-06-25 Thread Lisa Seacat DeLuca
: lisaseacat.com Chat: ldel...@us.ibm.com Find me on: and within IBM on: 100 East Pratt St 21-2212 Baltimore, MD 21202-1009 United States From: Andrew Grieve To: dev Date: 06/25/2014 11:05 AM Subject:Re: GitHub write access Sent by:agri...@google.com Your push to master

Re: GitHub write access

2014-06-25 Thread Marvin Humphrey
On Wed, Jun 25, 2014 at 7:52 AM, Lisa Seacat DeLuca wrote: > Ah, okay. I was hoping I'd be able to use the simple GitHub UX to quickly > push a button to merge in my changes. Background: The reason that we don't do this is that Apache needs the push records to establish code provenance definiti

Re: GitHub write access

2014-06-25 Thread Andrew Grieve
ssh://g...@github.com/ldeluca/cordova-plugin-vibration.git > (push) > > Thanks for your help, > > > Lisa > > Lisa Seacat DeLuca > Mobile Engineer | t: +415.787.4589 | *ldel...@apache.org* > | | *ldel...@us.ibm.com* | > *lisaseacat.com* <http://www.lisase

Re: GitHub write access

2014-06-25 Thread Lisa Seacat DeLuca
/cordova-plugin-vibration.git (fetch) origin ssh://g...@github.com/ldeluca/cordova-plugin-vibration.git (push) Thanks for your help, Lisa Lisa Seacat DeLuca Mobile Engineer | t: +415.787.4589 | ldel...@apache.org | | ldel...@us.ibm.com | lisaseacat.com | | From: Joe Bowser To: dev

Re: GitHub write access

2014-06-25 Thread Ian Clelland
That's right -- we can't (and shouldn't) make changes directly to any of the repos on GitHub. The syncing is one-way-only, so we have to push commits to the Apache repos. Committers should all be getting emails from GitHub with every pull request opened. All of those emails contain the phrase: To

Re: GitHub write access

2014-06-25 Thread Joe Bowser
The Apache repositories on GitHub are read-only. The Apache Git repositories are located here: https://git-wip-us.apache.org/repos/asf I'm pretty sure you have commit access to these, but you'll have to merge in pull requests to here. Does anyone know the new method for closing them? Joe On

Re: [GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread Axel Nennker
I ran jshint manually on the changed files and amended ConfigParser.js which jshint complained about. Axel 2014-06-20 22:06 GMT+02:00 Axel Nennker : > I ran npm test but get a bunch of other errors. No idea what is wrong. > Axel > > > npm run jasmine && npm run jshint > > > > cordova-lib@0.21.4-

Re: [GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread Axel Nennker
I ran npm test but get a bunch of other errors. No idea what is wrong. Axel > npm run jasmine && npm run jshint > cordova-lib@0.21.4-dev jasmine /host/Cordova/cordova-lib/cordova-lib > jasmine-node --color spec-plugman spec-cordova ...

Re: [GitHub] cordova-plugin-file-transfer pull request: Update index.md

2014-06-20 Thread Jesse
Yeah, I am still pulling it in ... @purplecabbage risingj.com On Fri, Jun 20, 2014 at 12:11 PM, cfjedimaster wrote: > Github user cfjedimaster commented on the pull request: > > > https://github.com/apache/cordova-plugin-file-transfer/pull/33#issuecomment-46715751 > > But when people alert

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread Axel Nennker
I want to make clear that splash icons have nothing to do with CB-2606. Splash icons are handled in this issue: https://issues.apache.org/jira/browse/CB-3571 I have a PR for this https://github.com/apache/cordova-lib/pull/30 that implements this for Android. -Axel 2014-06-16 10:46 GMT+02:00 Axe

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread Axel Nennker
Launcher icons are not part of the app. Please do not put them into www. Put them into project_dir. One above www. Use in config.xml and put : > Github user rohitagg28 commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issuecomment-45202523 > > Hi > I am

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-13 Thread Axel Nennker
No Am 13.06.2014 09:13 schrieb "rohitagg28" : > Github user rohitagg28 commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issuecomment-45982246 > > Hi I want to ask that can I add custom splashscreen to my project > without making any changes in platforms fol

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-12 Thread Axel Nennker
Rohit, please ask app developer questions on stackoverflow. http://stackoverflow.com/search?q=cordova+splash Issues and the dev list exist to discuss things related to cordova itself not how to build an app. Unless cordova fails to work as documented. http://cordova.apache.org/docs/en/3.5.0/config

Re: [GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread Jesse
Thanks Mark, I have updated the doc with details for windows8. I will be testing to make sure there is no regression. @purplecabbage risingj.com On Wed, May 28, 2014 at 10:59 AM, Mark Koudritsky wrote: > The plugin.xml spec is here > http://docs.phonegap.com/en/3.4.0/plugin_ref_spec.md.html

Re: [GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread Jesse
Where is the document that outlines all of the tags supported in plugin.xml, the expected meaning of those tags, and what attributes they support. Other than that, I can only assume this doesn't break on iOS + Windows 8. @purplecabbage risingj.com On Wed, May 28, 2014 at 8:34 AM, kamrik wro

Re: [GitHub] cordova-lib pull request: CB-6698: Support library references for ...

2014-05-28 Thread Mark Koudritsky
The plugin.xml spec is here http://docs.phonegap.com/en/3.4.0/plugin_ref_spec.md.html On Wed, May 28, 2014 at 1:56 PM, Jesse wrote: > Where is the document that outlines all of the tags supported in > plugin.xml, the expected meaning of those tags, and what attributes they > support. > > Other

Re: [GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-19 Thread purplecabbage
Mentioning nave and nvm is out of scope IMO. If a user knows about these things, then they also already know that they can use them ... We should stay focused. Sent from my iPhone > On May 19, 2014, at 1:18 PM, cmarcelk wrote: > > Github user cmarcelk commented on the pull request: > >h

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-16 Thread Michal Mocny
So, this patch needs updating now that cordova-lib was split out. I've manually applied the patch locally to test this feature (pasted below, so you don't have to redo the work), but please update the exiting PR to only contain changes to cli.js and submit a new PR to the cordova-lib repo ( https:

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-16 Thread Gorkem Ercan
I have also added a --shrinkwrap flag and if it is not specified it will not save the version information. This will in turn cause the restore to get the latest version from registry. The plan is to keep using the same flag for platforms as well. -- Gorkem On Mon, May 12, 2014 at 11:21 AM, Michal

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-16 Thread Michal Mocny
..also, seems its not warning when I attempt to remove a previously saved plugin. Not sure if that is a bug I introduced in my manual patch or if it existed before. -Michal On Wed, May 7, 2014 at 2:03 PM, Michal Mocny wrote: > So, this patch needs updating now that cordova-lib was split out.

Re: [GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...

2014-05-14 Thread Axel Nennker
- The splash screen icons should not be included into the app if the app does not use them. Please either don't copy them into the project or delete them if they are not needed. - The screen.png s are crunched on Android with significant space savings 90%. The should be crunched in the template p

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-13 Thread Gorkem Ercan
New PRs created https://github.com/apache/cordova-lib/pull/6 https://github.com/apache/cordova-cli/pull/176 On Tue, May 13, 2014 at 9:07 PM, gorkem wrote: > Github user gorkem closed the pull request at: > > https://github.com/apache/cordova-cli/pull/165 > > > --- > If your project is set

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-12 Thread Michal Mocny
(poke, due to email) On Wed, May 7, 2014 at 2:45 PM, Michal Mocny wrote: > Added experimental flag to CLI ("--experimental"). Please wrap your > handling of save & restore commands with "if (opts.experimental)" > > > On Wed, May 7, 2014 at 2:05 PM, Michal Mocny wrote: > >> ..also, seems its n

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-11 Thread Michal Mocny
Added experimental flag to CLI ("--experimental"). Please wrap your handling of save & restore commands with "if (opts.experimental)" On Wed, May 7, 2014 at 2:05 PM, Michal Mocny wrote: > ..also, seems its not warning when I attempt to remove a previously saved > plugin. Not sure if that is a

Re: github replication of cordova-lib

2014-05-06 Thread Shazron
Apparently re-opening the issue is clicking on the "WaitingForInfra" button: https://issues.apache.org/jira/browse/INFRA-7596 On Tue, May 6, 2014 at 12:40 PM, Marcel Kinard wrote: > Although > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=summary has > number of commits, https://g

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-06 Thread Gorkem Ercan
Any updates for me? -- Gorkem On Fri, Apr 18, 2014 at 10:21 PM, Michal Mocny wrote: > On Fri, Apr 18, 2014 at 4:11 PM, Gorkem Ercan >wrote: > > > On Thu, Apr 17, 2014 at 3:46 PM, Michal Mocny > wrote: > > > > > Took a quick glance. General questions: > > > - why the need for save? Why not j

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-01 Thread Michal Mocny
I'll take a look again today and land/comment. On Thu, May 1, 2014 at 8:28 AM, Gorkem Ercan wrote: > I would appreciate it if someone can have a final look and get this in.. I > have doc updates to follow. > Thanks > -- > Gorkem > > > On Fri, Apr 25, 2014 at 4:37 PM, Gorkem Ercan >wrote: > > >

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-05-01 Thread Gorkem Ercan
I would appreciate it if someone can have a final look and get this in.. I have doc updates to follow. Thanks -- Gorkem On Fri, Apr 25, 2014 at 4:37 PM, Gorkem Ercan wrote: > FYI. Just updated the PR with separated save & restore commands. > -- > Gorkem > > > On Thu, Apr 24, 2014 at 7:21 PM, Gor

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-29 Thread Sergey Grebnov (Akvelon)
@cordova.apache.org Subject: RE: [GitHub] cordova-cli pull request: CB-2606 add icon support Wanted to ping you folks on this PR - https://github.com/apache/cordova-cli/pull/166 -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Friday, April 18, 2014 12:05 AM To: dev Subject: Re

Re: [GitHub] cordova-cli pull request: CB-2606 Icons support for iOS, Android, ...

2014-04-29 Thread Axel Nennker
I closed PR #126 too. https://github.com/apache/cordova-cli/pull/126 2014-04-29 19:30 GMT+02:00 sgrebnov : > Github user sgrebnov commented on the pull request: > > https://github.com/apache/cordova-cli/pull/166#issuecomment-41706403 > > Merged here, closing.. > > https://github.com/apac

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-29 Thread Parashuram Narasimhan (MS OPEN TECH)
Wanted to ping you folks on this PR - https://github.com/apache/cordova-cli/pull/166 -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Friday, April 18, 2014 12:05 AM To: dev Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support Thanks Sergey

Re: [GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread Jesse
I have deleted the root VERSION file, however, the tag will remain where it is. @purplecabbage risingj.com On Mon, Apr 28, 2014 at 2:14 PM, Jesse wrote: > It probably makes more sense to delete the one I just added, as > consistency with iOS is probably the first priority. > > @purplecabbage >

Re: [GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread Jesse
It probably makes more sense to delete the one I just added, as consistency with iOS is probably the first priority. @purplecabbage risingj.com On Mon, Apr 28, 2014 at 2:08 PM, tripodsan wrote: > Github user tripodsan commented on the pull request: > > https://github.com/apache/cordova-cli

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-25 Thread Gorkem Ercan
FYI. Just updated the PR with separated save & restore commands. -- Gorkem On Thu, Apr 24, 2014 at 7:21 PM, Gorkem Ercan wrote: > I guess this is essentially moving save command as a flag to cordova > plugin * commands and restore becomes harder to discover. We need to > consider the platforms t

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-24 Thread Gorkem Ercan
I guess this is essentially moving save command as a flag to cordova plugin * commands and restore becomes harder to discover. We need to consider the platforms too since next stop is implementing "cordova save/restore platforms" -- Gorkem On Thu, Apr 24, 2014 at 5:05 PM, Michal Mocny wrote: >

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-24 Thread Gorkem Ercan
My plan is to add a warning to "cordova plugin rm" that will remind to explicitly call "cordova save plugins" to refresh the plugin dependencies. In a future iteration we can add a "keep my dependencies always restorable" flag so that cordova plugin rm/add also do the save. (and prepare does the a

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-24 Thread Michal Mocny
Gorkem, I also found an old JIRA duplicate issue for this which had listed an old suggestion I think is interesting: https://issues.apache.org/jira/browse/CB-4624 Specifically, instead of introducing save/restore commands, we could mirror "npm install" and its use of "--save": - npm install -> co

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-23 Thread Michal Mocny
Gorkem, as an orthogonal issue to the syntax we use, I think there is another small problem with this patch as-is. "cordova plugin add org.apache.cordova.file-transfer && cordova plugin save" would have my application explicitly depend on org.apache.cordova.file. If in the future the dependency i

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-22 Thread Michal Mocny
On Tue, Apr 22, 2014 at 11:37 AM, Gorkem Ercan wrote: > On Fri, Apr 18, 2014 at 7:21 PM, Michal Mocny wrote: > > > On Fri, Apr 18, 2014 at 4:11 PM, Gorkem Ercan > >wrote: > > > > > On Thu, Apr 17, 2014 at 3:46 PM, Michal Mocny > > wrote: > > > > > > > Took a quick glance. General questions: >

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-22 Thread Gorkem Ercan
On Fri, Apr 18, 2014 at 7:21 PM, Michal Mocny wrote: > On Fri, Apr 18, 2014 at 4:11 PM, Gorkem Ercan >wrote: > > > On Thu, Apr 17, 2014 at 3:46 PM, Michal Mocny > wrote: > > > > > Took a quick glance. General questions: > > > - why the need for save? Why not just alter the list on each cordov

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-18 Thread Michal Mocny
On Fri, Apr 18, 2014 at 4:11 PM, Gorkem Ercan wrote: > On Thu, Apr 17, 2014 at 3:46 PM, Michal Mocny wrote: > > > Took a quick glance. General questions: > > - why the need for save? Why not just alter the list on each cordova > > plugin add/rm? > > > > I do not want to force this workflow. Cal

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-18 Thread Gorkem Ercan
On Thu, Apr 17, 2014 at 3:46 PM, Michal Mocny wrote: > Took a quick glance. General questions: > - why the need for save? Why not just alter the list on each cordova > plugin add/rm? > I do not want to force this workflow. Calling save does not bring much overhead, considering plugin list does

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-18 Thread Axel Nennker
Thanks Sergey. I want cb-2606 to be fixed and would be happy if either PR is merged. I am sorry that I had not more time to cleanup the history in my PR. Thanks again. I hope that a committer takes the time to review and merge it now that ApacheCon is over. Axel Am 18.04.2014 00:16 schrieb "sgrebn

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-17 Thread Michal Mocny
Took a quick glance. General questions: - why the need for save? Why not just alter the list on each cordova plugin add/rm? - wouldn't "cordova plugin rm foo && cordova prepare" re-install that plugin right now? - why the name and not ? I think this functionality should overlap with the plugin

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-17 Thread Jesse
Yeah, that looks weird. @purplecabbage risingj.com On Thu, Apr 17, 2014 at 2:46 PM, kamrik wrote: > Github user kamrik commented on a diff in the pull request: > > https://github.com/apache/cordova-cli/pull/165#discussion_r11755812 > > --- Diff: src/save.js --- > @@ -0,0 +1,71 @@ >

RE: [GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-29 Thread Jonathan Bond-Caron
On Fri Mar 28 03:16 PM, Jesse wrote: > 'process.platform' in node returns win32 for windows ( 32+64 ) 'process.arch' > returns x64 if it is 64bit > > Interesting didn't know. In case anyone is curious about this, refers to v8's 'win32' platform / win32 api https://github.com/joyent/node/blob/0

Re: [GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread Jesse
'process.platform' in node returns win32 for windows ( 32+64 ) 'process.arch' returns x64 if it is 64bit @purplecabbage risingj.com On Fri, Mar 28, 2014 at 12:00 PM, agrieve wrote: > Github user agrieve commented on a diff in the pull request: > > https://github.com/apache/cordova-cli/pul

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Sergey Grebnov (Akvelon)
Got it, thx! -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Thursday, March 27, 2014 10:59 PM To: dev Subject: RE: [GitHub] cordova-cli pull request: CB-2606 add icon support The icon in config.xml without width is used to specify a path in the predefined

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Axel Nennker
85542ce898317eb4f40 > > Thx! > Sergey > -Original Message- > From: Axel Nennker [mailto:ignisvul...@gmail.com] > Sent: Thursday, March 27, 2014 7:53 PM > To: dev > Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support > > any comments on t

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Sergey Grebnov (Akvelon)
dova-cli/commit/8802945be42f89078bcd785542ce898317eb4f40 Thx! Sergey -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Thursday, March 27, 2014 7:53 PM To: dev Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support any comments on this method/implementation

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Axel Nennker
This pull request intentionally does not extend the w3c widget standard. There is no cdv:platform nor gap:platform nor any XML namespace used. Am 27.03.2014 18:01 schrieb "cmarcelk" : > Github user cmarcelk commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issu

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Axel Nennker
any comments on this method/implementation? Wishes for an alternative implementation? I know that not all like the "guessing" part... Axel maybe this is liked by more of you?: config.xml // iconpath=some/path and iconname=icon.png would lead to this pseudocode implementation on Android: for

Re: [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread Ian Clelland
You can send a signed copy (either physically signed, or cryptographically) to secret...@apache.org. http://www.apache.org/licenses/#clas has the complete instructions. Ian On Wed, Mar 26, 2014 at 4:02 PM, Jorge Torres < jorge.torres.maldon...@gmail.com> wrote: > Hi Ian, > > Who do I send my I

Re: [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread Jorge Torres
Hi Ian, Who do I send my ICLA? Thank you, Jorge On Wed, Mar 26, 2014 at 12:19 PM, clelland wrote: > Github user clelland commented on the pull request: > > > https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38704767 > > This looks like it should be part of the

Re: [GitHub] cordova-wp8 pull request: CB-5203 Using XmlHTTPRequest.open on WP8...

2014-03-18 Thread purplecabbage
The c# file is the right place to fix it, that's where the js interface comes from. What specifically is happening @dotnetwise? Do you have any error messages? Sent from my iPhone > On Mar 18, 2014, at 8:17 AM, dotnetwise wrote: > > Github user dotnetwise commented on the pull request: > >

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-16 Thread Axel Nennker
Rebased now. I will now repeat the changes on top of the new ConfigParser.js I still have the plan to avoid namespace fiddling and other XML related additions but I will probably not use too much of the magic stuff that I suggested earlier. Am 15.03.2014 13:48 schrieb "Axel Nennker" : > Will do t

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-15 Thread Axel Nennker
Will do that but it nicht take until tomorrow because I am traveling Axel Am 15.03.2014 12:17 schrieb "sgrebnov" : > Github user sgrebnov commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issuecomment-37723271 > > @AxelNennker, could you please rebase your c

Re: [GitHub] cordova-app-hello-world pull request: CB-6185 Spelling: explicitly

2014-03-14 Thread Josh Soref
I can't find the other emails which should have been generated for this pull request. ‎https://issues.apache.org/jira/browse/CB-6185 Anyone know why it wasn't automatically closed by Github.com? [https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452]ASF subversion and gi

Re: [GitHub] cordova-android pull request: Added Log.e when Config is not initi...

2014-03-12 Thread Michal Mocny
If you want to unsub only from github notifications (I know, these are frequent), you cannot directly do this, but just create a local inbox filter for mail incoming from g...@git.apache.org. For example, in gmail, I have two filters: Marked as Cordova: !from:g...@git.apache.org list:"" Marked as

Re: [GitHub] cordova-android pull request: Added Log.e when Config is not initi...

2014-03-12 Thread Shazron
Unsubscribe emails are at http://cordova.apache.org/#mailing-list You will have to directly email dev-unsubscr...@cordova.apache.org On Wed, Mar 12, 2014 at 12:30 PM, Salyer, Josef wrote: > unsubscribe > > -Original Message- > From: asfgit [mailto:g...@git.apache.org] > Sent: Wednesday,

<    1   2   3   >