Re: Browserify JS is in

2014-12-17 Thread Darryl Pogue
On 17 December 2014 at 15:26, Steven Gill wrote: > Sounds like a bug. Can you file an issue for it? > https://issues.apache.org/jira/browse/CB-8183 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional comm

Re: Browserify JS is in

2014-12-17 Thread Steven Gill
Sounds like a bug. Can you file an issue for it? On Wed, Dec 17, 2014 at 12:53 PM, Darryl Pogue wrote: > > On 11 December 2014 at 11:37, Steven Gill wrote: > > I also would like to see this shipped! If you have questions about it, > LMK > > > > I was trying this out today, and overall I love the

Re: Browserify JS is in

2014-12-17 Thread Darryl Pogue
On 11 December 2014 at 11:37, Steven Gill wrote: > I also would like to see this shipped! If you have questions about it, LMK > I was trying this out today, and overall I love the idea. I found one issue though when building for multiple platforms: cordova platform add ios android cordova build

Re: Browserify JS is in

2014-12-15 Thread Josh Soref
.@chromium.org>> Date: Mon Dec 15 2014 10:28:47 GMT-0500 (EST) To: dev mailto:dev@cordova.apache.org>> Subject: Re: Browserify JS is in Maybe most other companies are not in the same boat, but at Google we can't add any software to our build process without it all being checked into sour

Re: Browserify JS is in

2014-12-15 Thread Andrew Grieve
Maybe most other companies are not in the same boat, but at Google we can't add any software to our build process without it all being checked into source control (and reviewed). Currently NPM is our biggest dependency, but thankfully we use that only for fetching (and so don't need it if we alread

Re: Browserify JS is in

2014-12-15 Thread Michal Mocny
Thanks Steven. On Mon, Dec 15, 2014 at 12:15 AM, Steven Gill wrote: > > For the lazy: cordova_plugins.js discussion > https://issues.apache.org/jira/plugins/servlet/mobile#issue/CB-8153 > On Dec 14, 2014 6:58 PM, "Michal Mocny" wrote: > > > Lets discuss the cordova_plugins.js thing elsewhere, th

Re: Browserify JS is in

2014-12-14 Thread Steven Gill
For the lazy: cordova_plugins.js discussion https://issues.apache.org/jira/plugins/servlet/mobile#issue/CB-8153 On Dec 14, 2014 6:58 PM, "Michal Mocny" wrote: > Lets discuss the cordova_plugins.js thing elsewhere, this thread has forked > a lot already. > > On Sun, Dec 14, 2014 at 6:22 PM, Carlos

Re: Browserify JS is in

2014-12-14 Thread Michal Mocny
Lets discuss the cordova_plugins.js thing elsewhere, this thread has forked a lot already. On Sun, Dec 14, 2014 at 6:22 PM, Carlos Santana wrote: > > This is the part that I like the most: > "and start > writing plugins as proper node modules. Maybe even push them to npm and > manage dependencies

Re: Browserify JS is in

2014-12-14 Thread Carlos Santana
This is the part that I like the most: "and start writing plugins as proper node modules. Maybe even push them to npm and manage dependencies that way." Agree with having less XHR, and concatenate cordova + plugins. Not in love with cordova_plugins.js to know what plugins are included in the app,

Re: Browserify JS is in

2014-12-12 Thread Brian LeRoux
yeah we are *not* proposing to distribute browserify or its deps On Fri, Dec 12, 2014 at 1:38 PM, Joe Bowser wrote: > What are we actually distributing? > > On Fri Dec 12 2014 at 12:36:03 PM Andrew Grieve > wrote: > > > On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser wrote: > > > > > On Fri Dec 12

Re: Browserify JS is in

2014-12-12 Thread Joe Bowser
What are we actually distributing? On Fri Dec 12 2014 at 12:36:03 PM Andrew Grieve wrote: > On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser wrote: > > > On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve > > wrote: > > > > > > > > I'm not actually worried about my disk filling up. Dependencies must b

Re: Browserify JS is in

2014-12-12 Thread Andrew Grieve
On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser wrote: > On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve > wrote: > > > > > I'm not actually worried about my disk filling up. Dependencies must be > > vetted for appropriate licenses, so now there's more overhead here. If we > > need to make a change

Re: Browserify JS is in

2014-12-12 Thread Joe Bowser
On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve wrote: > > I'm not actually worried about my disk filling up. Dependencies must be > vetted for appropriate licenses, so now there's more overhead here. If we > need to make a change to the module system now we need to poor through docs > and make P

Re: Browserify JS is in

2014-12-12 Thread Andrew Grieve
On Thu, Dec 11, 2014 at 2:38 PM, Andrew Grieve wrote: > I'd really like to get it fully spelled out *why* browserify is the right > tool for this. Some thoughts below: > > On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux wrote: > >> we should move browserify to main and drop that insane concat code

Re: Browserify JS is in

2014-12-12 Thread Michal Mocny
Okay, well we've got some tests to do and can come back here with results. One feature I would like to not lose: cordova_plugins.js is bad for many reasons, but I have found it useful on several occasions to get a full list of plugins & versions that shipped with an app. One reason is for the mob

Re: Browserify JS is in

2014-12-11 Thread Ian Clelland
On Thu Dec 11 2014 at 9:29:08 PM Anis KADRI wrote: > On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny wrote: > > > > 25MB is for the one-time cordova-cli install, and not overhead for the > > app. Its not perfect but not a blocker imho. > Agreed. In terms of size for a developer tool, that's not

Re: Browserify JS is in

2014-12-11 Thread Anis KADRI
On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny wrote: > > 25MB is for the one-time cordova-cli install, and not overhead for the > app. Its not perfect but not a blocker imho. > > There are more troubling things about the change than the size overhead: > - I don't think browserify has "baked" at a

Re: Browserify JS is in

2014-12-11 Thread Anis KADRI
On Thu, Dec 11, 2014 at 11:38 AM, Andrew Grieve wrote: > > I'd really like to get it fully spelled out *why* browserify is the right > tool for this. Some thoughts below: > > On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux wrote: > > > we should move browserify to main and drop that insane concat c

Re: Browserify JS is in

2014-12-11 Thread Brian LeRoux
I've vetted webpack (and the rest) extensively. Less ecosystem. More complex config. No transforms. Here's a thing I wrote on the modules front. Not directly applicable but possibly relevant and at worst geek entertaining. ;) https://medium.com/@brianleroux/es6-modules-amd-and-commonjs-c1acefbe6f

Re: Browserify JS is in

2014-12-11 Thread Josh Soref
Steven Gill wrote: > Android and IOS had same success rate on mobile spec for browserify system > last time I tested. > Need to do more tests with other platforms. Last I checked, mobile spec was just plain broken. Someone added a mandatory flag for building cordova-js and didn't teach mobile-sp

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
Realized I wasn't clear, but startup/run time is definitely faster. One of the benefits of switching to a system like this. Build time is a few ms slower. On Thu, Dec 11, 2014 at 2:06 PM, Steven Gill wrote: > > > On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny wrote: > >> 25MB is for the one-tim

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
On Thu, Dec 11, 2014 at 1:45 PM, Michal Mocny wrote: > 25MB is for the one-time cordova-cli install, and not overhead for the > app. Its not perfect but not a blocker imho. > Agreed > There are more troubling things about the change than the size overhead: > - I don't think browserify has "ba

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
Answers inline based on my understanding. Current system vs Browserify system (which exists behind a flag currently) On Thu, Dec 11, 2014 at 11:38 AM, Andrew Grieve wrote: > I'd really like to get it fully spelled out *why* browserify is the right > tool for this. Some thoughts below: > > On We

Re: Browserify JS is in

2014-12-11 Thread Michal Mocny
25MB is for the one-time cordova-cli install, and not overhead for the app. Its not perfect but not a blocker imho. There are more troubling things about the change than the size overhead: - I don't think browserify has "baked" at all. It was landed behind a flag, but is it actually used anywher

Re: Browserify JS is in

2014-12-11 Thread Andrew Grieve
I'd really like to get it fully spelled out *why* browserify is the right tool for this. Some thoughts below: On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux wrote: > we should move browserify to main and drop that insane concat code > > its not heavyweight at all. it creates a hash in iife with d

Re: Browserify JS is in

2014-12-11 Thread Steven Gill
I also would like to see this shipped! If you have questions about it, LMK On Thu, Dec 11, 2014 at 11:10 AM, Joe Bowser wrote: > This should be a major, but yeah, I'm fine with making this the default. > > On Thu, Dec 11, 2014, 11:08 AM Brian LeRoux wrote: > > > so I think this has baked long e

Re: Browserify JS is in

2014-12-11 Thread Joe Bowser
This should be a major, but yeah, I'm fine with making this the default. On Thu, Dec 11, 2014, 11:08 AM Brian LeRoux wrote: > so I think this has baked long enough! lets make it the default and suss > the bugs. > > On Thu, Jul 10, 2014 at 3:36 AM, Ally Ogilvie wrote: > > > Ace, look forward to

Re: Browserify JS is in

2014-12-11 Thread Brian LeRoux
so I think this has baked long enough! lets make it the default and suss the bugs. On Thu, Jul 10, 2014 at 3:36 AM, Ally Ogilvie wrote: > Ace, look forward to browser/web as platform. Combined Web and Native API > plugin for Cordova! Yay! > Thanks for the clarification Michal. > > > > On Tue, Ju

Re: Browserify JS is in

2014-07-10 Thread Ally Ogilvie
Ace, look forward to browser/web as platform. Combined Web and Native API plugin for Cordova! Yay! Thanks for the clarification Michal. On Tue, Jul 8, 2014 at 6:07 AM, Anis KADRI wrote: > Right, browserify is just a way to package cordova.js that should make it > easier to add the browser as a

Re: Browserify JS is in

2014-07-07 Thread Anis KADRI
Right, browserify is just a way to package cordova.js that should make it easier to add the browser as a platform so might not be directly related but is somewhat related :-} On Mon, Jul 7, 2014 at 4:45 PM, Michal Mocny wrote: > I think Ally may be confusing what this does?: This browserify wor

Re: Browserify JS is in

2014-07-07 Thread Michal Mocny
I think Ally may be confusing what this does?: This browserify work is not a way to get cordova to run in a desktop browser, its just a means for packaging cordova.js. I think there should be no visible change to end users. There is a separate effort to target the browser as a platform, and it ma

Re: Browserify JS is in

2014-07-07 Thread Anis KADRI
On Sun, Jun 29, 2014 at 9:54 PM, Ally Ogilvie wrote: > Anis that is really sweet. > If this hits CLI, plugin.xml will have sections for plugins to do web > actions? > Not sure I understand what you mean by web actions. > TBH.. i've always wanted a cordova platform add web... but i'd be happy >

Re: Browserify JS is in

2014-06-29 Thread Ally Ogilvie
Anis that is really sweet. If this hits CLI, plugin.xml will have sections for plugins to do web actions? TBH.. i've always wanted a cordova platform add web... but i'd be happy enough with a prepare for browser only mode. Seeing a lot of use cases (e.g. Facebook plugin etc.) where there are JS, i

Re: Browserify JS is in

2014-06-20 Thread Anis KADRI
Ok cool. I can look at adding a --browserify option for run and prepare. I logged an issue for it [1] [1] https://issues.apache.org/jira/browse/CB-7001 On Thu, Jun 19, 2014 at 5:57 PM, Andrew Grieve wrote: > Thanks Anis! > > Tougher for CLI since it's actually the prepare step that creates > c

Re: Browserify JS is in

2014-06-19 Thread Andrew Grieve
Thanks Anis! Tougher for CLI since it's actually the prepare step that creates cordova_plugins.js, but longer term (medium term?) I don't see why we shouldn't just turn it on always anyways. So... Maybe cordova prepare --browserify? Build prepares first, so will also need: cordova run android --b

Re: Browserify JS is in

2014-06-19 Thread Anis KADRI
Sorry. I forgot you asked the question. There was no issue but there is one now. https://issues.apache.org/jira/browse/CB-6990 This "feature" is plugman only for now. How important is it to wire it to CLI ? Have you guys had time to test it out yet ? How would it work with CLI ? Add another flag

Re: Browserify JS is in

2014-06-19 Thread Andrew Grieve
bump On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve wrote: > Cool, yes! Thanks for the update! > > Is there a JIRA for this? Was asked in > https://issues.apache.org/jira/browse/CB-5671. > > > > > On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny > wrote: > >> Awesome Anis. >> >> Will gladly tak

Re: Browserify JS is in

2014-06-16 Thread Andrew Grieve
Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny wrote: > Awesome Anis. > > Will gladly take a look at this later today. Just wanted to send a quick > thanks for landing thi

Re: Browserify JS is in

2014-06-16 Thread Michal Mocny
Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks for landing this this way, and for the useful report. -Michal On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI wrote: > Yo, > > Just wanted to let everyone know that I added browserify support to > plugm