Re: Roadmap for next major versions

2018-07-02 Thread Niklas Merz
I think this PR  https://github.com/apache/cordova-plugin-inappbrowser/pull/271 should  basically do what needs to be done to support both webviews. I haven´t  tested this version yet, but it looks like Dave has done a great job  for supporting WKwebview alongside UIWebview. The main issues we had

Re: Roadmap for next major versions

2018-07-02 Thread Shazron
Thanks Niklas, Since you know what needs to be done or has been done with respect to InAppBrowser - can you highlight any specific tasks or PRs that need to be pulled in for IAB? I probably can't focus on getting anything except WKWebView support for InAppBrowser this week (if I have the bandwidth,

Re: Roadmap for next major versions

2018-07-02 Thread Niklas Merz
That sounds great. Please don't forget InAppBrowser. I worked in getting WKwebview running in InAppBrowser a while ago and I happy to help, review and test these changes . Dave Alden did a good pull request on this. I flag like this sounds like a good way to test this in our app. Am 3. Juli 201

Re: Roadmap for next major versions

2018-07-02 Thread Shazron
I was thinking that the feature flag is just a convenience feature for setting/removing (depends on if the flag is set/omitted): in config.xml So something like this: `cordova platform add ios --wkwebview` or something to that effect. My thinking is -- this would make manual testing easier, and

Re: Roadmap for next major versions

2018-07-02 Thread Darryl Pogue
Thanks Shazron! Regarding point 3 on your list, does that need to be a feature flag since the WebView engine is already controlled via a preference in config.xml? People should be able to opt-in that way just by adding a preference, and then in a future release we just change the default value for

Re: Roadmap for next major versions

2018-07-02 Thread Shazron
Thanks Darryl, I'll be working on getting the WKWebView plugin up to snuff this week (read the comment thread in your doc). 1. Review and resolve all existing PRs 2. Integrate the WKWebView plugin into the cordova-ios repo 3. Turn on WKWebView support via a feature flag (eventually this will be the

Roadmap for next major versions

2018-06-25 Thread Darryl Pogue
Hi folks, As we've been discussing dropping node 4 support and how that requires a major version bump, we should review what had already been on the pile for next majors and what we want on the pile. I've started a Google Doc scratchpad to loosely organize high-level goals for the various modules