Re: WebNotifications plugin

2012-12-03 Thread Anis KADRI
https://github.com/imhotep/WebNotifications For now requires one manual step (adding code to AppDelegate.m) until we figure out a way to deal with it. On Fri, Nov 30, 2012 at 8:48 AM, Filip Maj f...@adobe.com wrote: Yes and probably yes For example, the postMessage API in Android plugins is

Re: WebNotifications plugin

2012-11-30 Thread Filip Maj
Yes and probably yes For example, the postMessage API in Android plugins is not documented. This is essentially the same thing as what we are describing for iOS plugins. We could take this moment to document both in one fell swoop. On 11/30/12 2:09 AM, Brian LeRoux b...@brian.io wrote: Would

Re: WebNotifications plugin

2012-11-29 Thread Filip Maj
I think I had discussions with someone about this particular feature. What about having empty stubs for these functions that some plugins need to hook into (I.e. didReceiveLocalNotification) and then have the tooling drop code in where necessary for these functions? This can be a slippery slope

Re: WebNotifications plugin

2012-11-29 Thread Jesse
Have the AppDelegate raise events when things like 'didReceiveLocalNotification' happen. Have plugins subscribe to the event. Party. On Thu, Nov 29, 2012 at 1:30 PM, Anis KADRI anis.ka...@gmail.com wrote: It's tricky exactly because of that reason (i.e multiple plugins editing the same

Re: WebNotifications plugin

2012-11-29 Thread Shazron
Ok this is the essence of what the previous threads I linked to guys :) On Thu, Nov 29, 2012 at 1:43 PM, Jesse purplecabb...@gmail.com wrote: Have the AppDelegate raise events when things like 'didReceiveLocalNotification' happen. Have plugins subscribe to the event. Party. On Thu, Nov

Re: WebNotifications plugin

2012-11-29 Thread Brian LeRoux
+1 to Jesse's suggestion of Party. And the events thing. On Thu, Nov 29, 2012 at 10:51 PM, Shazron shaz...@gmail.com wrote: Ok this is the essence of what the previous threads I linked to guys :) On Thu, Nov 29, 2012 at 1:43 PM, Jesse purplecabb...@gmail.com wrote: Have the AppDelegate

Re: WebNotifications plugin

2012-11-29 Thread Ally Ogilvie
Hi Chaps, For Cordova 1.9 we were able to receive these events without any modification to the AppDelegate by registering for didFinishLaunching notifications etc. in the class' load method.

Re: WebNotifications plugin

2012-11-28 Thread Anis KADRI
I will get on that if I have time this afternoon! On Wed, Nov 28, 2012 at 9:33 AM, Brian LeRoux b...@brian.io wrote: this is sweet --- should get it working w/ plugin-install [1] and/or cordova-client [2] [1] https:github.com/imhotep/pluginstall [2]

Re: WebNotifications plugin

2012-11-28 Thread Anis KADRI
It requires some code to be appended in the AppDelegate.m which the plugin specification does not support at this time but I added an issue to support that. On Wed, Nov 28, 2012 at 2:14 PM, Anis KADRI anis.ka...@gmail.com wrote: I will get on that if I have time this afternoon! On Wed, Nov

Re: WebNotifications plugin

2012-11-27 Thread Shazron
Just tested it out, looks great! One thing I noticed though -- the function signatures don't match between .h and .m (the .m has the new signature we should be using going forward). On Tue, Nov 27, 2012 at 9:00 AM, Michal Mocny mmo...@google.com wrote: Hi all, As promised, this is the first

Re: WebNotifications plugin

2012-11-27 Thread Michal Mocny
Thanks! On Tue, Nov 27, 2012 at 2:47 PM, Shazron shaz...@gmail.com wrote: Just tested it out, looks great! One thing I noticed though -- the function signatures don't match between .h and .m (the .m has the new signature we should be using going forward). On Tue, Nov 27, 2012 at 9:00 AM,