Re: WebNotifications plugin

2012-12-04 Thread Michal Mocny
Awesome Anis! I'll play with this tonight, thanks! On Mon, Dec 3, 2012 at 8:46 PM, Anis KADRI wrote: > https://github.com/imhotep/WebNotifications > > For now requires one manual step (adding code to AppDelegate.m) until we > figure out a way to deal with it. > > > On Fri, Nov 30, 2012 at 8:48 A

Re: WebNotifications plugin

2012-12-03 Thread Anis KADRI
https://github.com/imhotep/WebNotifications For now requires one manual step (adding code to AppDelegate.m) until we figure out a way to deal with it. On Fri, Nov 30, 2012 at 8:48 AM, Filip Maj wrote: > Yes and probably yes > > For example, the postMessage API in Android plugins is not documen

Re: WebNotifications plugin

2012-11-30 Thread Filip Maj
Yes and probably yes For example, the postMessage API in Android plugins is not documented. This is essentially the same thing as what we are describing for iOS plugins. We could take this moment to document both in one fell swoop. On 11/30/12 2:09 AM, "Brian LeRoux" wrote: >Would this be an ap

Re: WebNotifications plugin

2012-11-30 Thread Brian LeRoux
Would this be an appropriate addition to the plugin dev guide or are there other events/scenarios we/re not considering? On Fri, Nov 30, 2012 at 6:57 AM, Filip Maj wrote: > I feel pretty dumb not thinking about this before.. > > O well, good thing Jesse is smrt! > > On 11/29/12 7:21 PM, "Ally Ogi

Re: WebNotifications plugin

2012-11-29 Thread Filip Maj
I feel pretty dumb not thinking about this before.. O well, good thing Jesse is smrt! On 11/29/12 7:21 PM, "Ally Ogilvie" wrote: >Hi Chaps, > >For Cordova 1.9 we were able to receive these events without any >modification to the AppDelegate by registering for didFinishLaunching >notifications e

Re: WebNotifications plugin

2012-11-29 Thread Ally Ogilvie
Hi Chaps, For Cordova 1.9 we were able to receive these events without any modification to the AppDelegate by registering for didFinishLaunching notifications etc. in the class' load method. https://github.com/wcwynn/phonegap-plugin-localNotifications/blob/v1.9/ios/project/Plugins/LocalNotificati

Re: WebNotifications plugin

2012-11-29 Thread Brian LeRoux
+1 to Jesse's suggestion of Party. And the events thing. On Thu, Nov 29, 2012 at 10:51 PM, Shazron wrote: > Ok this is the essence of what the previous threads I linked to guys :) > > > On Thu, Nov 29, 2012 at 1:43 PM, Jesse wrote: > >> Have the AppDelegate raise events when things like >> 'didR

Re: WebNotifications plugin

2012-11-29 Thread Shazron
Ok this is the essence of what the previous threads I linked to guys :) On Thu, Nov 29, 2012 at 1:43 PM, Jesse wrote: > Have the AppDelegate raise events when things like > 'didReceiveLocalNotification' happen. > Have plugins subscribe to the event. > Party. > > > On Thu, Nov 29, 2012 at 1:30 P

Re: WebNotifications plugin

2012-11-29 Thread Jesse
Have the AppDelegate raise events when things like 'didReceiveLocalNotification' happen. Have plugins subscribe to the event. Party. On Thu, Nov 29, 2012 at 1:30 PM, Anis KADRI wrote: > It's tricky exactly because of that reason (i.e multiple plugins editing > the same files/methods). I don't se

Re: WebNotifications plugin

2012-11-29 Thread Anis KADRI
It's tricky exactly because of that reason (i.e multiple plugins editing the same files/methods). I don't see a clean solution to this problem. One way would be to just apply the patch. If it fails, notify the user and prompt them to apply the code manually. Bright minds out there, your thoughts ar

Re: WebNotifications plugin

2012-11-29 Thread Filip Maj
I think I had discussions with someone about this particular feature. What about having empty stubs for these functions that some plugins need to hook into (I.e. didReceiveLocalNotification) and then have the tooling drop code in where necessary for these functions? This can be a slippery slope (m

Re: WebNotifications plugin

2012-11-28 Thread Anis KADRI
On Wed, Nov 28, 2012 at 10:43 PM, Brian LeRoux wrote: > would this not be an indication that we need to modify the plugin api? > (code munging would be a bad code smell for a pluggable architecture > imo) > Yes. The current specification does not support this use case. I can't seem to find a cle

Re: WebNotifications plugin

2012-11-28 Thread Shazron
We discussed this previously: Enhancing the plugin lifecycle for iOS: http://markmail.org/thread/ecakmzk37vey4kf6 Plugin loading - on startup and on demand: http://markmail.org/thread/hq2rd5lobbl4nkav http://issues.cordova.io/1693 We will need to expand on that, to support other application dele

Re: WebNotifications plugin

2012-11-28 Thread Brian LeRoux
would this not be an indication that we need to modify the plugin api? (code munging would be a bad code smell for a pluggable architecture imo) On Thu, Nov 29, 2012 at 5:41 AM, Anis KADRI wrote: > It requires some code to be appended in the AppDelegate.m which the plugin > specification does not

Re: WebNotifications plugin

2012-11-28 Thread Anis KADRI
It requires some code to be appended in the AppDelegate.m which the plugin specification does not support at this time but I added an issue to support that. On Wed, Nov 28, 2012 at 2:14 PM, Anis KADRI wrote: > I will get on that if I have time this afternoon! > > > On Wed, Nov 28, 2012 at 9:33

Re: WebNotifications plugin

2012-11-28 Thread Anis KADRI
I will get on that if I have time this afternoon! On Wed, Nov 28, 2012 at 9:33 AM, Brian LeRoux wrote: > this is sweet --- should get it working w/ plugin-install [1] and/or > cordova-client [2] > > [1] https:github.com/imhotep/pluginstall > [2] https://github.com/filmaj/cordova-client > >

Re: WebNotifications plugin

2012-11-28 Thread Brian LeRoux
this is sweet --- should get it working w/ plugin-install [1] and/or cordova-client [2] [1] https:github.com/imhotep/pluginstall [2] https://github.com/filmaj/cordova-client On Tue, Nov 27, 2012 at 7:56 PM, Michal Mocny wrote: > Thanks! > > On Tue, Nov 27, 2012 at 2:47 PM, Shazron wrote: >>

Re: WebNotifications plugin

2012-11-27 Thread Michal Mocny
Thanks! On Tue, Nov 27, 2012 at 2:47 PM, Shazron wrote: > Just tested it out, looks great! One thing I noticed though -- the function > signatures don't match between .h and .m (the .m has the new signature we > should be using going forward). > > > On Tue, Nov 27, 2012 at 9:00 AM, Michal Mocny

Re: WebNotifications plugin

2012-11-27 Thread Shazron
Just tested it out, looks great! One thing I noticed though -- the function signatures don't match between .h and .m (the .m has the new signature we should be using going forward). On Tue, Nov 27, 2012 at 9:00 AM, Michal Mocny wrote: > Hi all, > > As promised, this is the first version of a w3

WebNotifications plugin

2012-11-27 Thread Michal Mocny
Hi all, As promised, this is the first version of a w3c Web Notifications implementation for iOS. https://github.com/mmocny/phonegap-plugins/tree/web_notifications/iOS/WebNotifications Example usage includes scheduling notifications in the resign event (the bugfix to allow executing js, includin