[ANNOUNCEMENT] cordova-plugin-file-transfer 2.0.0 Release

2023-09-13 Thread Bryan Ellis
We have just released an update to our plugins! - cordova-plugin-file-transfer@2.0.0 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-plugin-file-transfer 2.0.0 Release

2023-09-13 Thread Bryan Ellis
> - Verified Tags > > On 2023-09-08 9:39 a.m., Bryan Ellis wrote: >> Please review and vote on this cordova-plugin-file-transfer Release v2.0.0 >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> The archive has been published to dist/dev

Re: [VOTE] cordova-plugin-file-transfer 2.0.0 Release

2023-09-11 Thread Ken Naito
+1 I did: * coho verify-archive OK * coho verify-tags OK * The commit 2c15ad2cbec24f6dfb904935f6de75e9b28a754d is green. Thanks! Kenichi Naito On 2023/09/08 21:39, Bryan Ellis wrote: cordova-plugin-file-transfer: 2.0.0 (1acbcad972

Re: [VOTE] cordova-plugin-file-transfer 2.0.0 Release

2023-09-08 Thread Norman Breau
I vote +1: - Ran NPM Test - Verified Archive - Verified Tags On 2023-09-08 9:39 a.m., Bryan Ellis wrote: Please review and vote on this cordova-plugin-file-transfer Release v2.0.0 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev

[VOTE] cordova-plugin-file-transfer 2.0.0 Release

2023-09-08 Thread Bryan Ellis
Please review and vote on this cordova-plugin-file-transfer Release v2.0.0 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/file-transfer-v2.0.0 The package was published from its

[DISCUSS] cordova-plugin-file-transfer 2.0.0 Release

2023-09-04 Thread Bryan Ellis
Does anyone have any reason to delay a release for cordova-plugin-file-transfer? * cordova-plugin-file-transfer (2.0.0) Any additional outstanding changes to land? If not, I will start the release process shortly https://github.com/apache/cordova-plugin-file-transfer/compare/rel/1.7.1...master

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-25 Thread Bryan Ellis
t;>> >>>> This vote is only for the purpose of unarchive and remove the >> deprecation >>>> status for the plugin of: >>>> >>>> cordova-plugin-file-transfer >>>> >&

Re: [DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-08-19 Thread Harel Mazor
he webview memory, I don't know, your call I guess... On 2020/07/23 09:23:38, Tim Brust wrote: > Hi there, > > I'd like to discuss the revival of the cordova-plugin-file-transfer plugin. > With the decision from 2017 it was sunsetted and the XHR/fetch alternative > was propos

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-18 Thread Jan Piotrowski
only for the purpose of unarchive and remove the > deprecation > >> status for the plugin of: > >> > >> cordova-plugin-file-transfer > >> > >> Please keep the discussion in the discussion thread. >

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-18 Thread Tim Brust
+1 Sent from my iPhone > On 18. Aug 2020, at 8:22 AM, Dave Alden wrote: > > +1 > >> On Tue, 18 Aug 2020, 05:47 Bryan Ellis, wrote: >> >> This vote is only for the purpose of unarchive and remove the deprecation >> status for the plugin of: >> >

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-18 Thread Dave Alden
+1 On Tue, 18 Aug 2020, 05:47 Bryan Ellis, wrote: > This vote is only for the purpose of unarchive and remove the deprecation > status for the plugin of: > > cordova-plugin-file-transfer > > Please keep the discussion in the discussion thread. > > Vote will follo

Re: [VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-17 Thread Norman Breau
/1aed4456-47d2-48e3-b21d-c1fa1dd14...@getmailspring.com/2?redirect=https%3A%2F%2Fbreautek.com=ZGV2QGNvcmRvdmEuYXBhY2hlLm9yZw%3D%3D) On Aug 18 2020, at 1:47 am, Bryan Ellis wrote: > This vote is only for the purpose of unarchive and remove the deprecation > status for the plugin of: > > co

[VOTE] Unarchive & Un-deprecate cordova-plugin-file-transfer

2020-08-17 Thread Bryan Ellis
This vote is only for the purpose of unarchive and remove the deprecation status for the plugin of: cordova-plugin-file-transfer Please keep the discussion in the discussion thread. Vote will follow the usual voting rules: * Minimum of 48 Hours * 2 + 1 Binding Vote +1

Re: [DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-08-17 Thread Mark de Groot
Hi all, I agree this plugin still has it's value in the cordova universe and (at times) works way better than the proposed alternative using XHR. I ran some tests downloading a 70 MB file. Using cordova-plugin-file-transfer this takes about 35 seconds. Downloading using XHR took 30 seconds

Re: [DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-07-27 Thread Harel Mazor
; On Jul 23 2020, at 6:23 am, Tim Brust > wrote:> > > Hi there,> > >> > > I'd like to discuss the revival of the cordova-plugin-file-transfer > > plugin.> > > With the decision from 2017 it was sunsetted and the XHR/fetch alternative> > > was pro

Re: [DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-07-27 Thread Shlomo Zalman Heigh
, but since I am using other plugins that depend on it, that creates a dependency version conflict. Thank you for considering. Shlomo Zalman Heigh On 2020/07/23 09:23:38, Tim Brust wrote: > Hi there,> > > I'd like to discuss the revival of the cordova-plugin-file-tra

Re: [DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-07-27 Thread Tomas Potok
Brust wrote: > Hi there, > > I'd like to discuss the revival of the cordova-plugin-file-transfer plugin. > With the decision from 2017 it was sunsetted and the XHR/fetch alternative > was proposed. [1], [2] > > However, neither the plugin was deprecated on npm nor the GitHub

Re: [DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-07-23 Thread Norman Breau
the best free email app for work On Jul 23 2020, at 6:23 am, Tim Brust wrote: > Hi there, > > I'd like to discuss the revival of the cordova-plugin-file-transfer plugin. > With the decision from 2017 it was sunsetted and the XHR/fetch alternative > was proposed. [1], [2] >

[DISCUSS] Revive/Undeprecate cordova-plugin-file-transfer

2020-07-23 Thread Tim Brust
Hi there, I'd like to discuss the revival of the cordova-plugin-file-transfer plugin. With the decision from 2017 it was sunsetted and the XHR/fetch alternative was proposed. [1], [2] However, neither the plugin was deprecated on npm nor the GitHub repository archived. With the release

Cordova-plugin-file-transfer

2018-01-06 Thread Dan Field
So I'd like to update this plugin to more securely delete files than just calling file.delete - this could leave partial data in a recoverable state causing potential security concerns on Android. Any thoughts or objections?

Re: cordova-plugin-file-transfer

2018-01-06 Thread Dan Field
Well, actually, I'm becoming less convinced that overwriting the file would really improve security - the OS could end up writing the new data to a different location on the card, leaving the partially downloaded data anyway. Unless anyone has a better idea, I'm probably going to have to go back

Re: cordova-plugin-file-transfer

2018-01-06 Thread Dan Field
So I'm happy to do the implementation/create the issue/ do the PR. As much as I'd like to transition to using XHR, that causes some other issues internally for the project I'm workining on - the most pressing one currently is that we're required to support some older platforms that don't work

Re: cordova-plugin-file-transfer

2018-01-06 Thread julio cesar sanchez
Also, file-transfer plugin has been deprecated, so is less likely to get that change applied. Read more about the deprecating and the recommended transition at https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html. 2018-01-06 21:48 GMT+01:00 Simon MacDonald

Re: cordova-plugin-file-transfer

2018-01-06 Thread Simon MacDonald
Probably best to create an issue in JIRA and we love PR's. Simon Mac Donald http://simonmacdonald.com On Sat, Jan 6, 2018 at 2:21 PM, Dan Field wrote: > The Android version of this plugin makes calls to file.delete on abort() > and on a failed/partial download(). > > Any

cordova-plugin-file-transfer

2018-01-06 Thread Dan Field
The Android version of this plugin makes calls to file.delete on abort() and on a failed/partial download(). Any thoughts on updating this logic to first write garbage to the file before deleting it to make recovery of sensitive data more difficult? I'm getting complaints from my security team

Draft blog post for transitioning off cordova-plugin-file-transfer

2017-10-05 Thread Filip Maj
https://github.com/apache/cordova-docs/pull/746 Comments, reviews, questions, ideas, whatever are welcome! Appreciate any feedback folks have. Cheers, Fil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

2017-09-21 Thread Viras-
Github user Viras- commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/178 Are there any intentions on merging this pull or should I do it myself directly? --- - To unsubscribe, e

[GitHub] cordova-plugin-file-transfer pull request #190: [Android] Handle redirects w...

2017-09-04 Thread jumangee
GitHub user jumangee opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/190 [Android] Handle redirects when downloading a file (actual) Then FileTransfer download gets 301 or 302 redirect it storps and storing the HTML from that page instead

[GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...

2017-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #187: CB-12809: Google Play Blocker: Unsa...

2017-08-31 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/187 I think we also want to remove the stuff from the README around how `trustAllHosts` is supported on Android. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file-transfer pull request #189: C# receive file from FileTra...

2017-08-30 Thread diegofuks
GitHub user diegofuks opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/189 C# receive file from FileTransfer Hi, what's the best way to receive the file from FileTransfer using C# RestFul service and save to the server? I've tried to implement

[GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...

2017-08-30 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/187#discussion_r136122199 --- Diff: www/FileTransfer.js --- @@ -163,7 +162,7 @@ FileTransfer.prototype.upload = function(filePath, server, successCallback, erro

[GitHub] cordova-plugin-file-transfer pull request #188: Update README.md

2017-08-26 Thread thegatheringstorm
GitHub user thegatheringstorm opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/188 Update README.md There is something Imprecise about "Example with Upload Headers and Progress Events" ### Platform

[GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...

2017-08-21 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/187 CB-12809: Google Play Blocker: Unsafe SSL TrustManager Defined ### Platforms affected Android ### What does this PR do? It removes

[GitHub] cordova-plugin-file-transfer pull request #186: Multiple File Transfer

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #186: Multiple File Transfer

2017-08-10 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/186 This is not the right place to ask questions. Please, close this pull request. You can ask your question on [Stack Overflow](https://stackoverflow.com/questions/tagged

[GitHub] cordova-plugin-file-transfer pull request #186: Multiple File Transfer

2017-08-10 Thread ramkumarizaap
GitHub user ramkumarizaap opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/186 Multiple File Transfer How to make multiple file transfer at one request? I did with in looping but it will uploading last file only not all files

[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...

2017-08-04 Thread hey99xx
Github user hey99xx commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/161 This can be closed, right? https://github.com/apache/cordova-plugin-file-transfer/commit/655489905ab5bd2600d4eaf80e8dd5d27e96b461 --- If your project is set up for it, you can

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-07-18 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Alright, I took a look at this again after an extended break and I have more comments, and want to bring more information to the community about the future of this plugin

[GitHub] cordova-plugin-file-transfer issue #168: patch method

2017-07-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/168 This patch (pun, I know) needs a README update for `httpMethod` as well, to be complete. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-07-14 Thread stalniy
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 @filmaj any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer pull request #185: CB-7995: document that `File...

2017-07-14 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request #185: CB-7995: document that `File...

2017-07-14 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/185 CB-7995: document that `FileTransferError.exception` on iOS is never used https://issues.apache.org/jira/browse/CB-7995 You can merge this pull request into a Git

[GitHub] cordova-plugin-file-transfer pull request #184: CB-13017 (android) Added pro...

2017-07-12 Thread dracorlll
GitHub user dracorlll opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/184 CB-13017 (android) Added proxy option in download method ### Platforms affected Android ### What does this PR do? Download files with proxies

[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename

2017-07-12 Thread feidianbo
Github user feidianbo commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/177 @purplecabbage You can download the fowling image to check the bug: http://git.oschina.net/fdb/demo1/raw/master/风景图片.jpg The above url contains the Chinese

[GitHub] cordova-plugin-file-transfer pull request #130: Update index.md

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request #139: Insert Content-Type to each ...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #130: Update index.md

2017-07-11 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/130 Localized documentation is not editable. Please see https://github.com/cordova/cordova-discuss/wiki/Translations for more details. Thank you for your

[GitHub] cordova-plugin-file-transfer pull request #144: Fix documentation for option...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #144: Fix documentation for options.heade...

2017-07-11 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/144 good call! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-file-transfer pull request #167: Fix log warning

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request #164: Removed warning

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request #183: Remove broken headline and u...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #168: patch method

2017-07-11 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/168 https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PATCH LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-file-transfer issue #174: CB-12399: (Android) Fix bug with We...

2017-07-11 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/174 Thoughts here @infil00p ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename

2017-07-11 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/177 @feidianbo Can you provide an example url that would have failed and now will pass, short of writing the whole test. --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-file-transfer pull request #182: Fire successCallback for any...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #182: Fire successCallback for any 2XX HT...

2017-07-11 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/182 Yes this is an important change. I'm wondering how we can set up testing for these kinds of issues. Perhaps that's a wider question about how to test the browser

[GitHub] cordova-plugin-file-transfer issue #141: CB-10974 Cordova file transfer Cont...

2017-07-10 Thread cozzbie
Github user cozzbie commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/141 Issue seems to be mostly an android problem because same code works fine on iOS. Using @cooperjbrandon advice and adding `options.chunkedMode = false;` to just the android code

[GitHub] cordova-plugin-file-transfer pull request #183: Remove broken headline and u...

2017-07-08 Thread janpio
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/183 Remove broken headline and useless reference to it You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin

[GitHub] cordova-plugin-file-transfer pull request #182: Fire successCallback for any...

2017-07-07 Thread bozdoz
GitHub user bozdoz opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/182 Fire successCallback for any 2XX HTTP status Found this bug when receiving a 201 response. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-file-transfer pull request #156: CB-9027 (android, ios): Expo...

2017-07-03 Thread ryanwilliams83
Github user ryanwilliams83 closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-file-transfer pull request #181: CB-12935: (ios, android) Ena...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request #181: CB-12935: (ios, android) Ena...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/181 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do? https://issues.apache.org/jira

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

2017-06-20 Thread edu526
Github user edu526 commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/178 Sorry, is this change available for use? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Thanks. I will need to test this manually as the file-transfer CI is super broken. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread homen
Github user homen commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 @filmaj All my editors showing correct alignment. Anyhow I fixed this with five commits :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-file-transfer pull request #150: CB-11534 This plugin should ...

2017-06-06 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/150#discussion_r120497208 --- Diff: plugin.xml --- @@ -30,6 +30,8 @@ https://issues.apache.org/jira/browse/CB/component/12320650

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-05 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-05 Thread homen
Github user homen commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Hi all, I have done the required changes. It can be merged now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-05 Thread stalniy
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 @homen do you plan to fix the PR in the nearest future? :) It's really annoying for me... And I want to have this fix in my codebase! --- If your project is set up

[GitHub] cordova-plugin-file-transfer pull request #180: CB-12847: added `bugs` entry...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #180: CB-12847: added `bugs` entry to pac...

2017-05-25 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/180 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/180/commits

[GitHub] cordova-plugin-file-transfer issue #180: CB-12847: added `bugs` entry to pac...

2017-05-25 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/180 These flaky failures are clearly not caused by tour changes. I see them in the periodic build too. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file-transfer issue #180: CB-12847: added `bugs` entry to pac...

2017-05-25 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/180 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/180/commits

[GitHub] cordova-plugin-file-transfer issue #180: CB-12847: added `bugs` entry to pac...

2017-05-25 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/180 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-file-transfer issue #180: CB-12847: added `bugs` entry to pac...

2017-05-24 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/180 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/180/commits

[GitHub] cordova-plugin-file-transfer pull request #180: CB-12847: added `bugs` entry...

2017-05-24 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/180 CB-12847: added `bugs` entry to package.json. ### What does this PR do? Adds a bugs entry to the package.json. ### What testing has been done on this change

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-05-18 Thread ygrishajev
Github user ygrishajev commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 @homen you should probably import `cordova.PermissionHelper` like [here](https://github.com/apache/cordova-plugin-camera/commit/a9c18710f23e86f5b7f8918dfab7c87a85064870#diff

[GitHub] cordova-plugin-file-transfer pull request #179: CB-12809 android

2017-05-15 Thread amovsesy
Github user amovsesy closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-14 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 +1 to deprecation as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 +1 to @jcesarmobile's proposed solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Yeah, so the solution should be to deprecate `trustAllHosts`, documenting it and then remove those methods, not to implement them with a safe implementation because

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread amovsesy
Github user amovsesy commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 @jcesarmobile, I understand, but this is violating Google's play ToS and it clearly states that any new updates or apps using an unsafe implementation of TrustManager

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Those methods are there to ignore the certificates if you pass `trustAllHosts` param set to true (default is false) --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android

2017-05-12 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/179/commits

[GitHub] cordova-plugin-file-transfer issue #179: Fixing a security issue which is ba...

2017-05-12 Thread amovsesy
Github user amovsesy commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 @stevengill Can you please take a look at this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-file-transfer pull request #179: Fixing a security issue whic...

2017-05-12 Thread amovsesy
GitHub user amovsesy opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Fixing a security issue which is banned by google play that can be fo… …und https://support.google.com/faqs/answer/6346016 Adding a check for the certificate

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

2017-05-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/178 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/178/commits

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-05-02 Thread maxpaj
Github user maxpaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 This should really be merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: (iOS) Adding support for ...

2017-05-01 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/178 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/178/commits

[GitHub] cordova-plugin-file-transfer pull request #178: CB-12745: (iOS) Adding suppo...

2017-05-01 Thread Viras-
GitHub user Viras- opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/178 CB-12745: (iOS) Adding support for non base64 encoded data-URIs ### Platforms affected iOS ### What does this PR do? Adding support for non base64

[GitHub] cordova-plugin-file-transfer issue #174: CB-12399: (Android) Fix bug with We...

2017-04-26 Thread Lemon-King
Github user Lemon-King commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/174 I believe I signed the ICLA on the main apache org jira site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-file-transfer issue #174: CB-12399: (Android) Fix bug with We...

2017-04-24 Thread Lemon-King
Github user Lemon-King commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/174 The patch itself allows WebView and CookieManager's cookies to be used together really. It won't overwrite WebView but join WebView and CookieManager together

[GitHub] cordova-plugin-file-transfer issue #174: CB-12399: (Android) Fix bug with We...

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/174 I see, so any custom handling of cookies via CookieManager are being appended over and on top of whatever the WebView is handling. I guess if there are conflicts between

[GitHub] cordova-plugin-file-transfer issue #174: CB-12399: (Android) Fix bug with We...

2017-04-24 Thread Lemon-King
Github user Lemon-King commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/174 Can do. This PR resolves an issue we came across on our framework with File Transfer and were unsure if others were dealing with the same problem. The issue

[GitHub] cordova-plugin-file-transfer issue #177: fix Chinese words error in filename

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/177 I think we should try to write a test for this, if possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

  1   2   3   4   5   6   7   8   9   >