Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Steven Gill
4.0 is released. > > -Nikhil > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Wednesday, September 30, 2015 1:00 PM > To: dev@cordova.apache.org > Subject: Re: cordova-plugin-whitelist ios issue > > +1 > OK I guess I did a hoorible

RE: cordova-plugin-whitelist ios issue

2015-09-30 Thread Nikhil Khandelwal
: cordova-plugin-whitelist ios issue +1 OK I guess I did a hoorible job doing an example :-) I compare 1.0.0 vs. 1.1.0 And it looks like android didn't change. And the solution is that plugin.xml doesn't have the and it doesn't have the offending OK so still my position is that ver

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Carlos Santana
gt; >> >>> > > >> >>> > If they have cordova-ios 3.x installed - ignore this warning. This > >> >>> > plugin wasn't meant for your platform. > >> >>> > > >> >>> > > >> >>> > > >> >>> &g

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Shazron
t;> I think the first version of the whitelist plugin was released >> without >> >>> the corodva-ios 4.0 check, so that developers do not see this warning >> >>> because cordova-ios 4.0 was not released. I agree with Tommy, that the >> >>> wording of th

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Steven Gill
;>> because cordova-ios 4.0 was not released. I agree with Tommy, that the > >>> wording of the warning seems to suggest there is a way for me to fix > this > >>> issue: > >>> >> "Plugin doesn't support this project's cordova-ios

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Shazron
That's a bad argument Carlos and you know it. No one will see the warning unless they add the firefoxos platform, and if they added it, it is relevant to them. This is a valid warning. Plugins are in cross-platform territory and this will happen, let's not skirt around it. We can hide now by "fixi

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Shazron
hat the >>> wording of the warning seems to suggest there is a way for me to fix this >>> issue: >>> >> "Plugin doesn't support this project's cordova-ios version. >>> cordova-ios: 3.9.1, failed version requirement: >=4.0.0-dev.&q

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Carlos Santana
t;> [1] >> https://github.com/apache/cordova-plugin-whitelist/commit/72a067c96e4e54efb8f1f152220d4a5fdf404324#commitcomment-11624636 >> [2] http://callback.markmail.org/thread/w2pjyndljbdng23f >> >> -Original Message----- >> From: Carlos Santana [mailto:csantan...@

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Carlos Santana
Carlos Santana [mailto:csantan...@gmail.com] > Sent: Wednesday, September 30, 2015 9:03 AM > To: dev@cordova.apache.org > Subject: Re: cordova-plugin-whitelist ios issue > > People are already getting surprised today that their apps do not connect > to any network when they create an a

RE: cordova-plugin-whitelist ios issue

2015-09-30 Thread Nikhil Khandelwal
ist/commit/72a067c96e4e54efb8f1f152220d4a5fdf404324#commitcomment-11624636 [2] http://callback.markmail.org/thread/w2pjyndljbdng23f -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Wednesday, September 30, 2015 9:03 AM To: dev@cordova.apache.org Subject: Re: cordova-plugin-whi

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Carlos Santana
People are already getting surprised today that their apps do not connect to any network when they create an app that contains cordova-android@4.x because the whitelist plugin is not included by default. Why whitelist is not included by default? - the don't use the cordova-cli, the use cordova-andr

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Carlos Santana
So this mean I can add this engine tag today to the whitelist plugin with some code specific to firefoxos? I know cordova-firefoxos@4.0.0-dev or ordova-firefoxos@4.0.0 is not on npm but is very useful to give users the warning now. This will avoid the user from upgrading the plugin ever in the f

Re: cordova-plugin-whitelist ios issue

2015-09-30 Thread Simon MacDonald
-1 to this proposal IMHO Warnings are useful. If someone sees this and is confused as to why there is a new whitelist plugin then looks into it some more detail that will be beneficial. I think the warning should be more explicit. Put an info tag into the plugin.xml for the whitelist linking to th

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Tommy Williams
This. +1 On 30 September 2015 at 12:31:29, Carlos Santana (csantan...@gmail.com) wrote: In summary I proposed that we update the plugin with a version that only  contains the android code.  When we publish cordova-ios@4.0.0 then we publish a new version that  contains the ios code and contains

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Carlos Santana
.9.1, failed version requirement: >=4.0.0-dev." >> >> >> >> However, with this plugin we do not have a way to fix it because ios >> 4.0 is not released. >> >> >> >> I suggest we do the following: >> >> - Unpublish the version th

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Carlos Santana
> >>> > >>> On Tue, Sep 29, 2015 at 5:19 PM, Nikhil Khandelwal > >>> wrote: > >>>> I understand the warning w.r.t. plugins and android 5.0 as we will > release android 5.0 along with the plugin update and there would be a path > for peo

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
that pins cordova-ios 4.x we should ship a >> cordova-app-hello-world template that targets v2 of this plugin. >> >> Thanks, >> Nikhil >> >> -Original Message- >> From: Shazron [mailto:shaz...@gmail.com] >> Sent: Tuesday, September 29, 2015 5:28 P

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
ls release, that pins cordova-ios 4.x we should ship a > cordova-app-hello-world template that targets v2 of this plugin. > > Thanks, > Nikhil > > -Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Tuesday, September 29, 2015 5:28 PM > To: dev@

RE: cordova-plugin-whitelist ios issue

2015-09-29 Thread Nikhil Khandelwal
haz...@gmail.com] Sent: Tuesday, September 29, 2015 5:28 PM To: dev@cordova.apache.org Subject: Re: cordova-plugin-whitelist ios issue This is only happening because we have two engine requirements - cordova-android 4.x and cordova-ios 4.x. This is correct for cordova-plugin-whitelist. Like I me

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
're getting feedback from customers about this. >>> >>> IMO we should never release a plugin which always emits a warning that >>> cannot be resolved. >>> >>> -Nikhil >>> >>> -Original Message- >>> From: Shazron [mai

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
t;> From: Shazron [mailto:shaz...@gmail.com] >> Sent: Tuesday, September 29, 2015 5:17 PM >> To: dev@cordova.apache.org >> Subject: Re: cordova-plugin-whitelist ios issue >> >> No its not a "rogue version". cordova-plugin-whitelist requires cordova-ios >

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
:17 PM > To: dev@cordova.apache.org > Subject: Re: cordova-plugin-whitelist ios issue > > No its not a "rogue version". cordova-plugin-whitelist requires cordova-ios > 4.0 and cordova-android 4.0. > It's just a warning and is expected to work this way. > https://na

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
If you have cordova-ios and android 3.x you do not need cordova-plugin-whitelist *at all*. It is only for cordova-ios and android 4.x. The 3.x series have built in whitelists. On Tue, Sep 29, 2015 at 5:17 PM, Shazron wrote: > No its not a "rogue version". cordova-plugin-whitelist requires > cordo

RE: cordova-plugin-whitelist ios issue

2015-09-29 Thread Nikhil Khandelwal
lugin-whitelist ios issue No its not a "rogue version". cordova-plugin-whitelist requires cordova-ios 4.0 and cordova-android 4.0. It's just a warning and is expected to work this way. https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-plu

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
No its not a "rogue version". cordova-plugin-whitelist requires cordova-ios 4.0 and cordova-android 4.0. It's just a warning and is expected to work this way. https://github.com/apache/cordova-plugin-whitelist/blob/master/README.md On Tue, Sep 29, 2015 at 5:08 PM, Nikhil Khandelwal wrote: > 1.

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Tommy Williams
Maybe less terse? It’s a little confronting, like you have messed something up and actually need to figure out how to update to 4.0.0-dev :/ On 30 September 2015 at 10:14:57, Steven Gill (stevengil...@gmail.com) wrote: It is just a warning though. Shouldn't break any builds. This will become

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Steven Gill
It is just a warning though. Shouldn't break any builds. This will become more common once we release the new plugins which will require cordova-android 5.0+. Is the suggestion to remove the warning completely? On Tue, Sep 29, 2015 at 5:08 PM, Nikhil Khandelwal wrote: > 1. cordova creat

cordova-plugin-whitelist ios issue

2015-09-29 Thread Nikhil Khandelwal
1. cordova create test 2. cordova platform add ios WARNING: Applications for platform ios can not be built on this OS - win32. Adding ios project... iOS project created with cordova-ios@3.9.1 Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the project Fetchi