Github user miqmago commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-106736212
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49
CB-9094: Smarter autohide logic on Android
When the plugin is initialized, the splash screen is shown with an
auto-hide delay. If a subsequent call to show() comes in while
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-106625709
@infil00p Would you be able to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user tfitschen opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48
CB-8396 - Read property AutoHideSplashScreen on android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mayflower/cordova
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#discussion_r31235221
--- Diff: src/android/SplashScreen.java ---
@@ -91,7 +91,9 @@ protected void pluginInitialize() {
firstShow = false
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-101761529
Hi @shazron: I'm still getting the same crash from users after applied the
latest fix. Any ideas? Thanks.
---
If your project is set up for it, you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100305790
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47#issuecomment-100306319
Thanks for the PR Dan -- I'm away, will take a look Monday.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
CB-3562: Disable screen rotation for iPhone when splash screen is shown
(updated)
This is an updated port of emarashliev's fix for CB-3562, as this bug still
exists
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100047179
@shazron Can you please review merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46
CB-8988: Fix rotation on iOS/iPad
The viewController.interfaceOrientation passed to getImageName has not
yet been updated with the new orientation, even when the frame/bounds
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045852
--- Diff: README.md ---
@@ -54,12 +54,18 @@ In your `config.xml`, you need to add the following
preferences:
preference name
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045956
--- Diff: src/android/SplashScreen.java ---
@@ -254,8 +262,12 @@ public void run
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-95968778
The options are not the same as those options change the whole project
while these only affect the splash screen. We have a client that's requested
GitHub user TheBosZ opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Add fullscreen options
This change adds settings to hide the navigation and status bars while the
splash screen is displayed. Full-screen apps aren't affected.
You can merge
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-94884712
@purplecabbage Is that strictly necessary, given the code is quite
straightforward and fairly common? I'd love to get this merged in if possible
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/42#issuecomment-94884271
@stevengill @purplecabbage @sgrebnov Is it possible to get someone to
review and merge this?
---
If your project is set up for it, you can reply
GitHub user chrskrchr opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/44
CB-8875 execute entire call to [UIView transitionWithView] on the main t...
...hread so that view fades as expected
You can merge this pull request into a Git repository
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-92240487
Just use the old org.apache.cordova.splashscreen name for now, that will
work even within the deprecation period (6 months long).
---
If your
Github user BrunoMarchesson commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-92078418
Well, 3 weeks after, still not working ?!
What are we supposed to do to add this plugin since the official
instruction does not work
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91347597
Filed a new issue: https://issues.apache.org/jira/browse/CB-8836
---
If your project is set up for it, you can reply to this email and have your
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91339236
Hmm. Can it be that it would not crash every time? AutoHideSplashScreen is
false, and navigator.splashscreen.hide is called in javascript
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91337249
I've updated my gist with a fix:
https://gist.github.com/shazron/e45705f76bef4448139a/daddb1f1fefc6171589b2c79bb9333efe6603ed6
---
If your
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91343883
Yes, definitely. I'll let you try it out for bit?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91333840
I just got the following new crash group. Do you think it's the same issue?
```
Incident Identifier: DD4D6021-EC75-4FFC-949E-2156E433A5F6
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91342982
Great thanks @shazron !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91343025
Are you planning to commit this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91335908
Ugh - it's related.
Basically, when calling this:
https://gist.github.com/shazron/e45705f76bef4448139a#file-gistfile1-m-L15
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91339823
Yes it definitely can not crash every time -- but it's a certainty that it
would eventually.
---
If your project is set up for it, you can reply
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91338139
Actually, this needs to be wrapped as well:
https://gist.github.com/shazron/e45705f76bef4448139a/daddb1f1fefc6171589b2c79bb9333efe6603ed6#file
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91344385
Sounds good. I'm having trouble repro'ing the crashes; I've only personally
seen it twice after a zillion attempts. But I'm definitely getting
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-91346209
No, thank you for the reports, that has helped solve the issue.
I'll pull the changes in anyway. Admittedly this is sloppy work on our part
Github user agrieve closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-90591245
This was merged. Will be applicable for cordova-android@4.0.0
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-90766537
@AlexTalis please include a missing import on [this
line](https://github.com/apache/cordova-plugin-splashscreen/commit
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89891961
Thanks so much @shazron. I will try your patch.
Here is a raw crash log:
```
Incident Identifier: FF007664-79D7-4895-99C8
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89449427
@jacobg not too sure what's going on here. Post the full crash log
somewhere? (shot in the dark). I'll review the code again.
---
If your project
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89458111
This could be it:
1.
https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios
Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-89449833
@agrieve, I believe I implemented all the changes we discussed. Can you
accept the pull request?
---
If your project is set up for it, you can
Github user jacobg commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-88049413
Ever since I added the splashscreen plugin to my app, I (and customers)
have been getting this crash occasionally:
```
1
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413370
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413145
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413236
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-87767088
Good stuff! A few minor comments then we're good to go I think!
---
If your project is set up for it, you can reply to this email and have your
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27412851
--- Diff: src/android/SplashScreen.java ---
@@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27423375
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27416639
--- Diff: src/android/SplashScreen.java ---
@@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27424716
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27416895
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27442565
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446516
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444238
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27445114
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444149
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444623
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446641
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Some devices have had a flicker issue, not sure which it was.
Joe might remember.
@purplecabbage
risingj.com
On Mon, Mar 30, 2015 at 6:17 PM, AlexTalis g...@git.apache.org wrote:
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-86878586
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87015745
I should also point out that the ResolutionHelper.cs file is taken from
MSDN sample code:
https://msdn.microsoft.com/library/windows/apps/jj206974(v
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87028196
I'll rewrite it, since I haven't looked at it. Just so we're clear.
---
If your project is set up for it, you can reply to this email and have
GitHub user AlexTalis opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43
CB-8753 Maintain splash screen aspect ratio
- Added SplashMaintainAspectRatioâ preference to maintain SplashScreen
aspect ratio instead of scaling it to dialog
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41
CB-8750 [wp8]: Allow resolution-specific splashscreen images
There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At
the moment, though, there is only one
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/42
CB-8758 [wp8]: UnauthorizedAccessException on hide()
When calling hide() from JS, the attempt to access Popup could happen on
a background thread, which ends up throwing
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-85662478
The next version of the plugin will be installable by this name, it's just
not working yet.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-82766632
Thanks, but... This was intentional. Plugins are being hosted on npm and we
are adopting npm style package ids
---
If your project is set up
GitHub user adamsc64 opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/39
Fixed plugin name in the readme.
While I was installing this on a small project, I noticed that the
reference to the plugin name was wrong in the README. Here is a quick pull
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26150136
--- Diff: src/wp/SplashScreen.cs ---
@@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
/// /summary
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26143768
--- Diff: src/wp/SplashScreen.cs ---
@@ -68,27 +77,52 @@ public override void OnInit()
if (!WasShown
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26144383
--- Diff: src/wp/SplashScreen.cs ---
@@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
/// /summary
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149711
--- Diff: src/wp/SplashScreen.cs ---
@@ -163,5 +190,30 @@ public void hide(string options = null)
story.Begin
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149807
--- Diff: src/wp/SplashScreen.cs ---
@@ -163,5 +190,30 @@ public void hide(string options = null)
story.Begin
Alexandrov; dev
Cc: agri...@chromium.org
Subject: Re: Pull Request Review Request [apache/cordova-plugin-splashscreen]
Thanks Georgi!
Bouncing you to the mailing-list though, as I don't do any Windows development.
On Mon, Mar 9, 2015 at 8:15 AM, Georgi Alexandrov
georgi.alexand
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149994
--- Diff: src/wp/SplashScreen.cs ---
@@ -68,27 +77,52 @@ public override void OnInit()
if (!WasShown
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#issuecomment-78152746
Thanks for the contribution.
I did some cleanup in general of this code, some per comments from
@robpaveza
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Thanks Georgi!
Bouncing you to the mailing-list though, as I don't do any Windows
development.
On Mon, Mar 9, 2015 at 8:15 AM, Georgi Alexandrov
georgi.alexand...@telerik.com wrote:
Hi Andrew,
I saw that you are one of the main contributors in
*cordova-plugin-splashscreen*. I
GitHub user galexandrov opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38
[WP8] Respect SplashScreen and SplashScreenDelay preferences from config
file
Extend WP8 Splash Screen to respect SplashScreen and SplashScreenDelay
preferences from config
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/37
CB-8574 Integrate TravisCI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-splashscreen
GitHub user sosahvictor opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/36
CB-8438 cordova-plugin-splashscreen documentation translation
CB-8438 cordova-plugin-splashscreen documentation translation:
cordova-plugin-splashscreen
You can merge
Github user sosahvictor closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sosahvictor commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/36#issuecomment-76056176
This will not be merged here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/35#issuecomment-73857850
Tested, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/35
CB-8397 Add support for Windows Phone 8.1 splashscreen
https://issues.apache.org/jira/browse/CB-8397
You can merge this pull request into a Git repository by running
Github user cgwyllie commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-73274586
@agrieve @jbavari Hey, been looking into this for a while this afternoon
and was wondering how it's possible to use the version of Cordova
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/33#issuecomment-70185588
No, this is incorrect. The splash screen names conform to the ones we set
in Info.plist:
https://github.com/apache/cordova-ios/blob
GitHub user sokolovstas opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/33
Fix splash screen path for iPhone 6 and iPhone 6 plus
Added -800 prefix for iphone 6. Splash screen not working without -800
You can merge this pull request into a Git
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/34
CB-7964 Add cordova-plugin-splashscreen support for browser platform
Added Browser platform support
Using cordova/confighelper module to read parameter values from config.xml
Github user solarsaturn9 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-66492739
Additionally, CDV_IsIPad is deprecated and produces an error when building.
Not sure how to report this seeing as how I don't know a good
Github user jbavari commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-65865043
Works great. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user agrieve opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32
CB-3679 Break Android splashscreen logic into splascreen plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agrieve
GitHub user mdudek opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/31
Fixed SplashScreenProxy.js
Fixed exception when hide() method is called multiple times.
You can merge this pull request into a Git repository by running:
$ git pull https
501 - 600 of 686 matches
Mail list logo
