[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Github user hengwoon commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/83 This would be extremely useful since it allows re-scrolling while a momentum scroll is in progress. Would be great if we can get this support in --- If your project is set up for

Nightly build #439 for cordova has succeeded!

Nightly build #439 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/439/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-statusbar pull request #83: CB-13124: Add option for native s...

GitHub user lunaru opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/83 CB-13124: Add option for native scroll-to-top on WebView ### Platforms affected iOS ### What does this PR do? Adds "StatusBarDefaultScrollToTop" option to allow

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r129730654 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,66 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r129730691 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,66 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Confirmed that this patch fixes the crash. Merged it in. Thanks for the contribution @SharUpOff! + on your first ever GitHub PR, too --- If your project is set up for

[GitHub] cordova-plugin-splashscreen pull request #130: CB-13094: (android) Don't sho...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Going to about:blank is done as a garbage collection technique before closing out the WebView entirely so that the memory is freed. There's a hilarious TODO here saying that

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #576: CB-12361 : added unit tests for remove platform

Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/576 Thanks @stevengill I will merge it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request #576: CB-12361 : added unit tests for remove platfo...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/576#discussion_r129713116 --- Diff: spec/cordova/platform/remove.spec.js --- @@ -0,0 +1,160 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

Re: Incompatible plugin should reject the build

Just created an issue for swapping to cordovaDependency from engine. https://issues.apache.org/jira/browse/CB-13123 I agree that we should switch the behavior to fail. It would need to be a major version of cordova. Chatted with Shaz & Simon and decided it would make sense to add a flag to

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/583 CB-12361 : added tests for plugin/index.js ### Platforms affected ### What does this PR do? Added tests for plugin/index.js ### What testing has been

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 And @SharUpOff your intuition is confirmed: the logcat logs show that after pressing the back button in my app after loading it up, Cordova tries to load about:url: ```

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 OK, I've been able to reproduce the behaviour - sort of. In my case, it wasn't that the my app showed the splashscreen, but that the app crashed while exiting! My test

Re: Incompatible plugin should reject the build

OMG late to this thread but yes, this should fail and freakout. My assumption is the same as the person who reported CB-12122 is: any dependent plugins that fail constraint checking would bubble the failure up the dependency chain. Unfortunately, the behaviour is not _super_ explicit in the docs

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129673561 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,173 @@ + + +# New Platform Checklist + +## Stand-alone scripts +

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129671498 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,173 @@ + + +# New Platform Checklist + +## Stand-alone scripts +

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Ah, great! Thanks for describing that. I will take a look at that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-device pull request #66: deviceready has not fired after 5 se...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request #230: when i use cordova.InAppBrows...

Github user jjjachyty closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser issue #230: when i use cordova.InAppBrowser.open...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/230 You have send a pull request, can you close it? You just have to add gap: to your Content-Security-Policy meta tag --- If your project is set up for it, you can

[GitHub] cordova-plugin-inappbrowser pull request #230: when i use cordova.InAppBrows...

GitHub user jjjachyty opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/230 when i use cordova.InAppBrowser.open() ios not open browser,but when i Double click the Home button then open ### Platforms affected ### What does

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-android/pull/397 @filmaj, updated. But I little doubt about folders names after prepare, this PR just skips the removal of an original package if names (manifestId and androidPkgName) differ in

[GitHub] cordova-plugin-dialogs pull request #95: CB-13028 (CI) Browser builds on Tra...

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-dialogs pull request #95: CB-13028 (CI) Browser builds on Tra...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/95 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on browser

[GitHub] cordova-plugin-device-motion pull request #56: CB-13115 (browser) Fixed getC...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-motion pull request #56: CB-13115 (browser) Fixed getC...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/56 CB-13115 (browser) Fixed getCurrentAcceleration() on Firefox, Safari … …and Edge ### Platforms affected Browser ### What does this PR do?

[GitHub] cordova-plugin-device-motion pull request #55: CB-13028 (CI) Browser builds ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-motion pull request #55: CB-13028 (CI) Browser builds ...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/55 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on

[GitHub] cordova-plugin-device pull request #69: CB-13113 (browser) device.isVirtual ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request #69: CB-13113 (browser) device.isVirtual ...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device/pull/69 CB-13113 (browser) device.isVirtual is always false ### Platforms affected Browser ### What does this PR do? Introduces device.isVirtual to browser platform and

[GitHub] cordova-plugin-device pull request #68: CB-13028 (CI) Browser builds on Trav...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request #68: CB-13028 (CI) Browser builds on Trav...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device/pull/68 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on browser

[GitHub] cordova-plugin-console pull request #24: CB-13028 (CI) Browser builds on Tra...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Accepting new apps into the App Showcase

+1 to drop it On Wed, Jul 26, 2017 at 10:01 AM, Simon MacDonald wrote: > +1 to drop it. > > Simon Mac Donald > http://simonmacdonald.com > > On Tue, Jul 25, 2017 at 7:00 PM, Shazron wrote: > > > +1 drop it altogether. > > We can't be the arbiter