GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-js/pull/150
CB-13501 : added support for node 8
### Platforms affected
### What does this PR do?
Added support for node 8
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-coho/pull/162
CB-13504 : adding progress to knownIssues for cordova-fetch 1.2.1 relâ¦
â¦ease
### Platforms affected
### What does this PR do?
Adding progress
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/288
CB-13501 : updated to include node 8
### Platforms affected
### What does this PR do?
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/603
CB-12361 : added unit tests for check.js
### Platforms affected
### What does this PR do?
Added unit tests for check.js to increase coverage
### What
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/600
Hi! @akdor1154 Can you please squash your commits? Thank you!
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147014589
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147012615
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/599
@stevengill CI is passing now. Let me know if I should merge it in!
---
-
To unsubscribe, e-mail: dev-unsubscr
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/599
CB-13463 : prevent package.json update with --nosave (for plugins)
### Platforms affected
### What does this PR do?
Prevent package.json update with --nosave
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/598
CB-13123 : plugin add should use cordovaDependency instead
of plugin.xml engine tag
### Platforms affected
### What does this PR do?
plugin add/ install
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/596
CB-13303 : added save_exact and production opts
### Platforms affected
### What does this PR do?
Added save-exact and production opts
### What testing
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/287
CB-13303 : added noprod/production as an option, no prod turns off prâ¦
â¦oduction
### Platforms affected
### What does this PR do?
Added noprod
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/286#discussion_r142508791
--- Diff: src/cli.js ---
@@ -449,6 +450,10 @@ function cli (inputArgs) {
args.save = true;
}
+if (args
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/286#discussion_r142480887
--- Diff: src/cli.js ---
@@ -443,12 +444,16 @@ function cli (inputArgs) {
});
}
-if (args.nosave
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/286
CB-13353 : added save-exact option
### Platforms affected
### What does this PR do?
Added save-exact option
### What testing has been done on this change
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141135727
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts&
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-coho/pull/160
CB-13331 : add in missing labels/tags to track issues more easily andâ¦
⦠clearly
### Platforms affected
### What does this PR do?
update/ add
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141107663
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts&
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-js/pull/149
CB-12895 : added eslint to repo
### Platforms affected
### What does this PR do?
Added eslint to repo
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/595
CB-12361 : updated and added unit tests for add.spec.js
### Platforms affected
### What does this PR do?
Updated and added "to-do" unit tests for a
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/594
CB-13288 : updated index.js and test to fix cordova plugin search
### Platforms affected
### What does this PR do?
Updated index.js and test to fix cordova
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/592
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/593
CB-12361 : added plugin unit tests for plugin list
### Platforms affected
### What does this PR do?
Added plugin unit tests for plugin list
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/592
CB-12361 : added some unit tests for plugman
### Platforms affected
### What does this PR do?
Added some unit tests for plugman
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/285
CB-13274 : removed .jshintignore file and removed unneeded references to
jshint
### Platforms affected
### What does this PR do?
Removed .jshintignore
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/591
CB-13274 : updated readme.md & removed references to jshint
### Platforms affected
### What does this PR do?
Updated readme.md & removed references t
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-docs/pull/726
Small update to readme.md
### Platforms affected
### What does this PR do?
Small update to readme.md
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-docs/pull/725
minor updates to README.md
### Platforms affected
### What does this PR do?
Minor updates to README.md.
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-docs/pull/724
CB-13231 : added cordova-common@2.1.0 release blog post
### Platforms affected
### What does this PR do?
### What testing has been done on this change
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/590
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-coho/pull/157
Fixed/revised tools-release-process.md
### Platforms affected
### What does this PR do?
Fixed/revised tools-release-process.md
### What testing has been
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/569#discussion_r135308470
--- Diff: spec/cordova/plugin/add.spec.js ---
@@ -21,16 +21,82 @@
/* globals fail */
var Q = require('q');
-var add = require
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/590
CB-13145: Create playservices version preference in config.xml
Still need to add in tests
### Platforms affected
### What does this PR do?
CB-13145
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/574
Thanks @stevengill ! I will merge it in today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132795105
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-coho/pull/154
CB-12895 : Added eslint
### Platforms affected
### What does this PR do?
Added eslint
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/236
CB-12895 : Added eslint and removed jshint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/60
CB-12895 : added eslint and removed jshint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint.
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/214
CB-12895 : Setup eslint and removed jshint
### Platforms affected
### What does this PR do?
Setup eslint and removed jshint
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/92
CB-12895 : Added eslint and removed jshint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint
### What testing
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/96
CB-12895 : setup eslint and removed jshint
### Platforms affected
### What does this PR do?
Setup eslint and removed jshint.
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/70
CB-12895 : Setup eslint and removed jshint
### Platforms affected
### What does this PR do?
Setup eslint and removed jshint
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/82
CB-12895 : Added eslint and removed jshint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/58
CB-12895 : Added eslint and removed jshint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/58
CB-12895 : added eslint and removed jshint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/59
CB-12895 : added eslint and removed jshint
### Platforms affected
### What does this PR do?
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/588
CB-13056 : Removed parsers & platformApi polyfill for webos, blackberry, &
ubuntu
### Platforms affected
### What does this PR do?
Removed
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/587
CB-13056 : added deprecation notice for webos
### Platforms affected
### What does this PR do?
Added deprecation notice for webos
### What testing has
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/586
Can I delete:
1. commented out tests or parts of tests that contain platforms.json or
platform_metadata?
2. Can I delete save.js and save.spec.js?
---
If your project is set up
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/586
CB-13057 : Remove cordova platform save command
### Platforms affected
### What does this PR do?
Remove cordova platform save command
### What testing
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/585
CB-13057 : added deprecation warning for cordova platform save
### Platforms affected
### What does this PR do?
Added deprecation warning for cordova platform
Github user audreyso commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/26
Thanks for the review! Okay to merge @filmaj?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/26
CB-12895 : replaced jshint with eslint
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41
CB-12895: replaced jshint with eslint
### Platforms affected
### What does this PR do?
replaced jshint with eslint
### What testing has
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/578#discussion_r129969368
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/584
CB-12361 : added tests for plugin/save.js
### Platforms affected
### What does this PR do?
added tests for plugin/save.js
### What testing has been
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/576
Thanks @stevengill I will merge it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/583
CB-12361 : added tests for plugin/index.js
### Platforms affected
### What does this PR do?
Added tests for plugin/index.js
### What testing has been
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129106466
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129104787
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129092432
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128880654
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128880058
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128879376
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128878157
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128877652
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128876824
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834432
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834249
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/582
CB-12361 : added tests for plugin/search.js
### Platforms affected
### What does this PR do?
Added tests for plugin/search.js.
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/581
CB-12361 : added plugin remove tests
### Platforms affected
### What does this PR do?
Added plugin remove tests.
### What testing has been done
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/580
CB-12895 : Replaced jshint with eslint
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been done
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/579
CB-12361 : added tests for save.js
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
added tests
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/578
CB-12361 : added unit-tests for getPlatformDetailsFromDir
### Platforms affected
### What does this PR do?
added unit-tests for getPlatformDetailsFromDir
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/577
CB-12361 : added tests for platform/list.js
### Platforms affected
### What does this PR do?
Added tests for platform/list.js
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/576
CB-12361 : added unit tests for remove platform
### Platforms affected
### What does this PR do?
Added unit tests for remove platform
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-osx/pull/38
CB-12895 : replaced jshint with eslint
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been done
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/281
CB-12895 : replaced jshint with eslint
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugman/pull/90
CB-12895 : setup eslint and removed jshint
### Platforms affected
### What does this PR do?
Setup eslint and removed jshint
### What testing has
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-browser/pull/37
CB-12895 : replaced jshint with eslint
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been done
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-ios/pull/327
CB-12895: replaced jshint with eslint
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been done
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/574
CB-12838 : prevented sorting and alphabetizing platforms and plugins iâ¦
â¦n pkgJson and config
### Platforms affected
### What does this PR do
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127110528
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127066391
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127008421
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127007878
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-windows/pull/236
CB -12895 : updated files to use eslint instead jshint
### Platforms affected
### What does this PR do?
Updated files to use eslint instead jshint
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/573
CB-12361 : updated addHelper tests
### Platforms affected
### What does this PR do?
updated addHelper tests
### What testing has been done on this change
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/570
CB-12361 : updated cordova-lib addHelper.spec tests
Not ready to be merged/reviewed yet! Thank you!
### Platforms affected
### What does this PR do
Github user audreyso commented on the issue:
https://github.com/apache/cordova-cli/pull/281
Refactored!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user audreyso commented on the issue:
https://github.com/apache/cordova-android/pull/386
I think I have permission, but haven't ever done it before! @filmaj
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/561
@filmaj I rebased this for now. If we change the tests to unit tests,
should it be in this PR or in a separate one?
---
If your project is set up for it, you can reply to this email and have
Github user audreyso commented on the issue:
https://github.com/apache/cordova-android/pull/386
I rebased this morning! @filmaj @infil00p If anyone has time to merge it
in, that would be great :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user audreyso commented on the issue:
https://github.com/apache/cordova-android/pull/386
Ohh thank you for that clarification @filmaj . So I did the following:
1. Left the project root level eslint file to keep--> root: true
2. Removed eslint config files from spec/
Github user audreyso commented on the issue:
https://github.com/apache/cordova-android/pull/386
Thanks! @filmaj That makes sense and seems easier than having to add in
/*eslint-env: jasmine*/ in every file. I made some changes and added .eslint
configs where they are needed. Let me
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-android/pull/386
CB-12895 : added eslint and removed jshint / reformatted with eslint
### Platforms affected
### What does this PR do?
Added eslint and removed jshint
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/281
CB-12895 : updated to use eslint instead of jshint
### Platforms affected
### What does this PR do?
Updated to use eslint instead of jshint
### What
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/561
Cb 12870 - Check that all use cases are caught in Api.js
Not ready for review yet, still updating tests. Thanks!
### Platforms affected
### What does this PR do
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36
CB-12762 : point package.json repo items to github mirrors instead ofâ¦
⦠apache repos site
### Platforms affected
### What does this PR
1 - 100 of 267 matches
Mail list logo
