Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/599
merge!
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/599
LGTM, but the ci failures ð¨
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/601
yeah i ran into this last time i tried to do it.
npm 5 doesn't handle `npm link` properly. Doesn't work with our current
link all the cordova deps strategy
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/597
merged! Thanks again @OminousWater!
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/597
No worries @OminousWater! That is what reviews are for :)
CI gets trigged with new commits or updated commits. Looks like your PR
triggered it. I'll wait and see how they go
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/597#discussion_r146039059
--- Diff: src/plugman/init-defaults.js ---
@@ -55,25 +55,26 @@ function readDeps (test) {
};
}
-var name = pkg.name
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/597#discussion_r146038992
--- Diff: .eslintignore ---
@@ -1,4 +1 @@
-spec/cordova/fixtures/**
-spec/plugman/projects/**
-spec/plugman/plugins/**
-spec/cordova
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/597#discussion_r146039159
--- Diff: src/plugman/init-defaults.js ---
@@ -149,10 +149,11 @@ if (!pkg.author) {
}
: prompt('author');
}
-/* eslint
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/597
Thanks for all your work on this @OminousWater!
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/597
I think turning it back to `package` in plugman is the way to go. We can
add an eslint exception for it I hope
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/161
Update tools-release-process.md
### Platforms affected
### What does this PR do?
### What testing has been done on this change
Github user stevengill commented on the issue:
https://github.com/apache/cordova-node-xcode/pull/2
Hey @sruthakeerthikotla!
Could you add a test to the pr?
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/287#discussion_r142530184
--- Diff: src/cli.js ---
@@ -475,8 +491,11 @@ function cli (inputArgs) {
link: args.link || false,
save: args.save
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/287#discussion_r142529980
--- Diff: src/cli.js ---
@@ -465,6 +473,14 @@ function cli (inputArgs) {
// User explicitly did not pass in searchpath
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/286#discussion_r142484800
--- Diff: src/cli.js ---
@@ -449,6 +450,10 @@ function cli (inputArgs) {
args.save = true
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/286#discussion_r142475924
--- Diff: src/cli.js ---
@@ -443,12 +444,16 @@ function cli (inputArgs) {
});
}
-if (args.nosave
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/285
Merge it!
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r141133636
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts&
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r140927739
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts&
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r140927689
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB;
},
"scripts&
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device-motion/pull/57
Merged this in, Added `info` tag.
@maverickmishra can you close this issue
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r139333464
--- Diff: README.md ---
@@ -27,6 +27,18 @@ description: Access accelerometer data.
# cordova-plugin-device-motion
Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/729
LGTM.
I personally prefer `npm run serve` over `node_modules/.bin/gulp build
--prod` but can deal
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r137442765
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +62,131 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r137442686
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +62,131 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r137442253
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +62,131 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r137442083
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +62,131 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/724#discussion_r137072952
--- Diff: www/_posts/2017-09-01-cordova-common-2.1.0.md ---
@@ -0,0 +1,40 @@
+---
+layout: post
+author:
+name: Audrey So
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/724#discussion_r137072825
--- Diff: www/_posts/2017-09-01-cordova-common-2.1.0.md ---
@@ -0,0 +1,40 @@
+---
+layout: post
+author:
+name: Audrey So
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/724#discussion_r137073157
--- Diff: www/_posts/2017-09-01-cordova-common-2.1.0.md ---
@@ -0,0 +1,40 @@
+---
+layout: post
+author:
+name: Audrey So
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/584
Make sure to run `npm run cover` to see the coverage report for save.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136486774
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136490386
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136489451
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136488898
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136490187
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136487019
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/584#discussion_r136487749
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-js/pull/148
CB-13232: added test for cordova's unquie local style require
This is in response to https://github.com/apache/cordova-js/pull/146
You can merge this pull request into a Git repository
Github user stevengill commented on the issue:
https://github.com/apache/cordova-js/pull/146
If you checkout https://github.com/apache/cordova-ios/pull/333, you can see
that I fixed the relative require for console.
---
If your project is set up for it, you can reply to this email
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/590
This has been merged. Can you close it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/723
Let me know if you have any feedback!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/723
CB-13214: added browser and serve release blog post
### Platforms affected
### What does this PR do?
### What testing has been done on this change
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/590#discussion_r135664127
--- Diff: src/cordova/plugin/util.js ---
@@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) {
var autosave
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/590#discussion_r135664112
--- Diff: src/cordova/plugin/util.js ---
@@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) {
var autosave
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/569#discussion_r135331136
--- Diff: spec/cordova/plugin/add.spec.js ---
@@ -21,16 +21,82 @@
/* globals fail */
var Q = require('q');
-var add = require
Github user stevengill commented on the issue:
https://github.com/apache/cordova-js/pull/146
I had to revert this as it broke all of our plugins that use local require
syntax (ex. cordova device-motion at
https://github.com/apache/cordova-plugin-device-motion/blob/master/www
Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/719
hmm, @filmaj screen shot makes it seem like he is testing on dev and not on
7.x. Maybe there are other references that still need to be removed.
---
If your project is set up for it, you
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/574
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132781446
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132780726
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/574#discussion_r132780476
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
fs.writeFileSync
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/581#discussion_r132758854
--- Diff: spec/cordova/plugin/remove.spec.js ---
@@ -32,18 +66,123 @@ describe('cordova/plugin/remove', function () {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/577#discussion_r132738598
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,75 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/577#discussion_r132742737
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,75 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/582#discussion_r132736159
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
console.error(e
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/582#discussion_r132736117
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
console.error(e
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/284
Changes look good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/284#discussion_r132319941
--- Diff: doc/readme.md ---
@@ -374,7 +374,7 @@ based on the following criteria (listed in order of
precedence):
### Examples
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/578#discussion_r129996355
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/580
Huge PR! haha LGTM. I did a quick scan. Looks like spacing formatting for
the most part. A few unused vars that you added exceptions for.
Merge it
---
If your project is set up
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/579#discussion_r129981636
--- Diff: spec/cordova/platform/save.spec.js ---
@@ -0,0 +1,71 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/579#discussion_r129981726
--- Diff: spec/cordova/platform/save.spec.js ---
@@ -0,0 +1,71 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/578#discussion_r129926425
--- Diff: spec/cordova/platform/getPlatformDetailsFromDir.spec.js ---
@@ -0,0 +1,79 @@
+/**
+Licensed to the Apache Software Foundation
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/577#discussion_r129730654
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/577#discussion_r129730691
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,66 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/576#discussion_r129713116
--- Diff: spec/cordova/platform/remove.spec.js ---
@@ -0,0 +1,160 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128869649
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128869395
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/558
Hey @G-Rath
CB-12810 is very much still open :).
https://issues.apache.org/jira/browse/CB-12810
Thanks for your comment. This is something we will hopefully get to soon
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127055093
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127032404
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r126843121
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r126842836
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r126844076
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124893454
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124892113
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124880319
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124881373
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124879975
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124891852
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124893969
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124894106
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124863854
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124890998
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124873252
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124871034
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124867315
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124868182
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124874233
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124881302
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124878766
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124879465
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124878233
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r124878443
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,459 @@
*/
/* eslint-env jasmine */
+var path = require('path
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/569
CB-12361: added main function unit tests for plugin add.spec.js
work in progress. Please don't merge
You can merge this pull request into a Git repository by running:
$ git pull https
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/568
looks good to me. Only thing I would add is updating travis and appveyor as
well. They run the integration tests as a separate task currently.
---
If your project is set up for it, you can
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/567
Sent an update with changes based on feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/567#discussion_r123426288
--- Diff: spec-cordova/prepare.spec.js ---
@@ -17,175 +17,265 @@
under the License.
*/
-var shell = require('shelljs
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/567#discussion_r123367811
--- Diff: spec-cordova/prepare.spec.js ---
@@ -17,175 +17,265 @@
under the License.
*/
-var shell = require('shelljs
1 - 100 of 779 matches
Mail list logo
