[GitHub] cordova-android pull request #333: CB-11869 Fix cordova-js android exec test...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-test-framework pull request #22: chore: edit package.json lic...

2016-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request #22: chore: edit package.json lic...

2016-09-28 Thread t1st3
GitHub user t1st3 opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/22 chore: edit package.json license to match SPDX id ### Platforms affected All ### What does this PR do? Fix a typo in the license field of package.json

[GitHub] cordova-plugin-test-framework pull request #21: CB-11917 - Remove pull reque...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/21 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-android pull request #333: CB-11869 Fix cordova-js android exec test...

2016-09-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/333 CB-11869 Fix cordova-js android exec tests Useragent Regexp result is null in node environment - add a check for it Updated cordova-js

[GitHub] cordova-plugin-test-framework pull request #13: CB-9071 Update test framewor...

2016-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: How to run a unit test for a plugin

2016-08-23 Thread Deshan Kalupahana
Ok. Fixed and PR that with https://github.com/apache/cordova-plugin-dialogs/pull/83. Admins can merge it Thanks for the help On Tue, Aug 23, 2016 at 11:18 PM, Shazron <shaz...@gmail.com> wrote: > In this case since its a manual test just update the existing testfile. > > On Tu

Re: How to run a unit test for a plugin

2016-08-23 Thread Shazron
In this case since its a manual test just update the existing testfile. On Tue, Aug 23, 2016 at 7:54 AM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > It worked. Thanks. > Can I change existing tests to support my bug fix or should i write a new > file? > > On Tu

Re: How to run a unit test for a plugin

2016-08-23 Thread Jesse
Bugfix pull requests that come with a test to prove they fix the defect are our absolute favorites! @purplecabbage risingj.com On Tue, Aug 23, 2016 at 7:54 AM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > It worked. Thanks. > Can I change existing tests to suppor

Re: How to run a unit test for a plugin

2016-08-23 Thread Deshan Kalupahana
It worked. Thanks. Can I change existing tests to support my bug fix or should i write a new file? On Tue, Aug 23, 2016 at 12:23 PM, Shazron <shaz...@gmail.com> wrote: > A slower way would be to send the pull request and let the CI test it i.e > https://github.com/apache/cordova-pl

Re: How to run a unit test for a plugin

2016-08-23 Thread Shazron
, > > I'm currently working on CB-11281, a bug in windows platform to learn > the code base. I fixed that. But i don't know how to unit test that. > The steps in docementation with "org.apache.cordova.test-framework" is > not clear. Help me to run the unit test. > > Thanks >

Re: How to run a unit test for a plugin

2016-08-23 Thread Shazron
A slower way would be to send the pull request and let the CI test it i.e https://github.com/apache/cordova-plugin-dialogs/pull/82 On Mon, Aug 22, 2016 at 11:50 PM, Shazron <shaz...@gmail.com> wrote: > Install cordova-paramedic from its repo url or npmjs. See > https://github.com/ap

How to run a unit test for a plugin

2016-08-23 Thread Deshan Kalupahana
Hi, I'm currently working on CB-11281, a bug in windows platform to learn the code base. I fixed that. But i don't know how to unit test that. The steps in docementation with "org.apache.cordova.test-framework" is not clear. Help me to run the unit test. Thanks -- Deshan

Re: re-write tests for new Android JUnit test framework

2016-05-26 Thread Joe Bowser
er to a reference? > https://developer.android.com/studio/test/index.html > I’ve tweaked a few of the tests and written two but I don’t know what > needs to be done for this migration task. > I might be interested in taking this on as a learning exercise. > > Awesome. I have almost no

re-write tests for new Android JUnit test framework

2016-05-26 Thread Homer, Tony
! Yay for tests! > >BTW, We need to re-write those to migrate to the new Android JUnit test >framework (It's more deleting code than adding). > > > > >> On 5/25/16, 3:31 PM, "Carlos Santana" <csantan...@gmail.com> wrote: >> >> >+1 >

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-25 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/306#issuecomment-221718552 OK, this is a pre-req of #307, so I merged them both together. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-25 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/306#issuecomment-221691711 This looks completely unrelated to the pull request itself. We should just merge this in. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-25 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/306#issuecomment-221691227 Why did this break travis??? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-20 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-android/pull/306 CB-10096: Upgrade test project to Gradle Plugin 2.1.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony--/cordova-android CB-10096

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-vibration pull request: Dummy PR to test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-battery-status pull request: Dummy PR to test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-statusbar pull request: Dummy PR to test CI

2016-05-18 Thread sarangan12
Github user sarangan12 closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-battery-status pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
/commits/e09e7576f8b6c64de104bb356a048d5961e63818) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/11/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-battery-status pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/36 Dummy PR to test CI Dummy PR to test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-plugin

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
/commits/72ee63c24f21ef4f246223b2c96ec4a27cd30074) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/8/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219833742 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
/commits/72ee63c24f21ef4f246223b2c96ec4a27cd30074) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/7/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219830920 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
/commits/72ee63c24f21ef4f246223b2c96ec4a27cd30074) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/6/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/48#issuecomment-219826350 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread cordova-qa
/commits/72ee63c24f21ef4f246223b2c96ec4a27cd30074) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-globalization-pr/5/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-globalization pull request: Dummy PR to test CI

2016-05-17 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/48 Dummy PR to test CI Dummy PR to test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-plugin

[GitHub] cordova-plugin-statusbar pull request: Dummy PR to test CI

2016-05-16 Thread cordova-qa
/7458667998ef91c54817288a6d69076f4bd115b5) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar/9/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1

[GitHub] cordova-plugin-statusbar pull request: Dummy PR to test CI

2016-05-16 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/57#issuecomment-219520871 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-statusbar pull request: Dummy PR to test CI

2016-05-16 Thread cordova-qa
/7458667998ef91c54817288a6d69076f4bd115b5) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar/7/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1

[GitHub] cordova-plugin-statusbar pull request: Dummy PR to test CI

2016-05-16 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/57 Dummy PR to test CI Dummy PR to test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-plugin-statusbar

[GitHub] cordova-plugin-vibration pull request: Dummy PR to test CI

2016-05-16 Thread cordova-qa
/0efd6d1e928cf13b3ecaef9c52f2b756ba7df160) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration/7/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1

[GitHub] cordova-plugin-vibration pull request: Dummy PR to test CI

2016-05-16 Thread cordova-qa
/0efd6d1e928cf13b3ecaef9c52f2b756ba7df160) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration/6/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1

[GitHub] cordova-plugin-vibration pull request: Dummy PR to test CI

2016-05-16 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/46 Dummy PR to test CI Dummy PR to test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-plugin-vibration

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-14 Thread cordova-qa
/commits/6933c2efde092b7e94e2409b61b68005e462b0ef) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-motion/9/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-14 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/44#issuecomment-219207354 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-14 Thread cordova-qa
/commits/6933c2efde092b7e94e2409b61b68005e462b0ef) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-motion/8/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-14 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/44#issuecomment-219206991 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-14 Thread cordova-qa
/commits/6933c2efde092b7e94e2409b61b68005e462b0ef) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-motion/7/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-device-motion pull request: Dummy Commit to Test CI

2016-05-14 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/44 Dummy Commit to Test CI Dummy Commit to Test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-13 Thread cordova-qa
/commits/3bf654ee0e0ccd75c5086aacd2a27c385943f93a) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/5/) | Builder Name | Console Output | Test Report | Device Logs

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-13 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/62#issuecomment-219202027 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-13 Thread cordova-qa
/91be1d807b82461cac41a3529c841c824a01ac2b) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/3/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-13 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/52#issuecomment-219201706 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-13 Thread cordova-qa
=windows-8.1-store/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave,platformName=windows-8.1-store/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/4//label=windows-slave

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-13 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/62#issuecomment-219179412 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-13 Thread cordova-qa
=windows-8.1-store/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave,platformName=windows-8.1-store/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/3//label=windows-slave

[GitHub] cordova-plugin-media-capture pull request: Dummy Commit to test CI

2016-05-13 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/62 Dummy Commit to test CI Dummy Commit to test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-13 Thread cordova-qa
) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-store/testReport/) - [Device Logs]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/2//label=windows-slave,platformName=windows-8.1-store/artifact/) 2

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-13 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/52#issuecomment-219169821 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-13 Thread cordova-qa
) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-store/testReport/) - [Device Logs]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device/1//label=windows-slave,platformName=windows-8.1-store/artifact/) 2

[GitHub] cordova-plugin-device pull request: Dummy Commit to test CI

2016-05-13 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-device/pull/52 Dummy Commit to test CI Dummy Commit to test CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-plugin

RE: help with "npm test" for cordova-lib

2016-04-29 Thread Vladimir Kotikov (Akvelon)
Done. Please see PR [1] and JIRA [2] This happens due to some caching issues with `getPlatformApi` method which doesn't respect symlinked paths. The reason why tests are not failing on Travis and Appveyor is that they run in environments, where the test directory isn't symlinked. However, on OS

RE: help with "npm test" for cordova-lib

2016-04-29 Thread Vladimir Kotikov (Akvelon)
Yeah, I was planning to look into this today. - Best regards, Vladimir -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Friday, April 29, 2016 3:50 AM To: dev@cordova.apache.org Subject: Re: help with "npm test" for cordova-lib Can someone help, perhaps Vl

Re: help with "npm test" for cordova-lib

2016-04-28 Thread Shazron
Can someone help, perhaps Vladimir who wrote the tests can shed some light on how to fix this issue? On Mon, Apr 25, 2016 at 10:57 AM, Carlos Santana <csantan...@gmail.com> wrote: > It's jasmine test that is failing [1] > > Does this means that jasmine tests are not running in

Re: help with "npm test" for cordova-lib

2016-04-25 Thread Carlos Santana
It's jasmine test that is failing [1] Does this means that jasmine tests are not running in a continuously? Any reason why are they not running in Travis? I can't figure out what is the test trying to test: it('should successfully add a plugin using relative path when running from subdir inside

Re: help with "npm test" for cordova-lib

2016-04-25 Thread Jesse
Travis is running this: - git clone https://github.com/apache/cordova-js --depth 10 - cd cordova-lib - npm link ../cordova-js - npm link ../cordova-common - npm link ../cordova-serve - npm install - "(cd ../cordova-common && npm test)" - "npm run ci" There are a lot of

Re: help with "npm test" for cordova-lib

2016-04-23 Thread Carlos Santana
I do't get it then, Travis is green, so Travis not running same test suite as "npm test"? On Fri, Apr 22, 2016 at 9:11 PM Shazron <shaz...@gmail.com> wrote: > I'm seeing the same. Using node 0.12.7 > > > On Fri, Apr 22, 2016 at 12:44 PM, Carlos Santana <csantan..

Re: help with "npm test" for cordova-lib

2016-04-22 Thread Shazron
I'm seeing the same. Using node 0.12.7 On Fri, Apr 22, 2016 at 12:44 PM, Carlos Santana <csantan...@gmail.com> wrote: > I'm seeing 2 test failures when I do "npm test" > > Anyone seeing the same? Wonder what I have setup wrong here: > > Here is a paste http://pas

help with "npm test" for cordova-lib

2016-04-22 Thread Carlos Santana
I'm seeing 2 test failures when I do "npm test" Anyone seeing the same? Wonder what I have setup wrong here: Here is a paste http://pastebin.com/4E4c40X5 of my output I thought it was node 5, but then swift to node 4 and the same. This is after making sure all npm links are correct

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212739167 Not exactly sure about that. I guess the iOS simulator had issues dealing with so many post calls and other platforms may be handled

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212679043 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/20 CB-11124 Fixing cordova-ios build failure due to unnecessary post cal… …ls to couchdb and adding handlers to xhr call You can merge this pull request into a Git

[GitHub] cordova-plugin-file pull request: CB-11115 android: Fixing test co...

2016-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: CB-11115 android: Fixing test co...

2016-04-20 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540628 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-file pull request: CB-11115 android: Fixing test co...

2016-04-20 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540487 @riknoll LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file pull request: CB-11115 android: Fixing test co...

2016-04-20 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212539984 @infil00p does this change seem reasonable to you? I tried to match the old behavior. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file pull request: CB-11115 android: Fixing test co...

2016-04-19 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-file/pull/178 CB-5 android: Fixing test content provider Seems like `FileDescriptor.toString()` changed in Android N and it broke three of our tests. This removes our dependency on the output

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-14 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/19#issuecomment-210012817 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-13 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/19 Add spec started/completed log This will help in debugging and provides a start/stop marker in native logs. You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

2016-04-04 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/137#issuecomment-205583342 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

2016-04-04 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/137#issuecomment-205565973 Now with fewer CI failures! I think this is [CB-10536](https://issues.apache.org/jira/browse/CB-10536). --- If your project is set up for it,

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

2016-04-04 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/137 Removing flaky test assertions about abort callback latency @nikhilkh @sarangan12 please review You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-test-framework pull request: CB-10876 Enable inerti...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file pull request: Fix file plugin test failure on ...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: Fix file plugin test failure on ...

2016-03-11 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/171 Fix file plugin test failure on WP 8.1 @riknoll please review I dislike JavaScript number objects... You can merge this pull request into a Git repository by running

Re: Test Plugin on npm

2016-03-04 Thread Carlos Santana
Thanks Shaz for keeping us legit #2legit2quit [1] [1]: https://www.youtube.com/watch?v=wiyYozeOoKs On Fri, Mar 4, 2016 at 4:49 PM Richard Knoll <rikn...@microsoft.com> wrote: > Great! I think I will actually put the source for the plugin into the > cordova-lib test folder to m

RE: Test Plugin on npm

2016-03-04 Thread Richard Knoll
Great! I think I will actually put the source for the plugin into the cordova-lib test folder to make it clear that it is only intended for testing. Thanks, Richard -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Friday, March 4, 2016 12:58 PM To: dev

Re: Test Plugin on npm

2016-03-04 Thread Shazron
Here are the guidelines: http://www.apache.org/dev/release.html#what In short, what others have said is correct. Test packages do not require a vote as long as they follow the (bolded) guidelines in the link I cited above. On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll <rikn...@microsoft.

Re: Test Plugin on npm

2016-03-04 Thread Carlos Santana
gt; >> Thoughts? >> >> -Steve >> >> On Fri, Mar 4, 2016 at 10:43 AM, Richard Knoll <rikn...@microsoft.com> >> wrote: >> >>> Yep, I would like to test with a plugin on npm to support the new version >>> selection feature I'm about to merge. &g

Re: Test Plugin on npm

2016-03-04 Thread Nikhil Khandelwal
testing, I >would say you don't have to vote on it. > >Thoughts? > >-Steve > >On Fri, Mar 4, 2016 at 10:43 AM, Richard Knoll <rikn...@microsoft.com> >wrote: > >> Yep, I would like to test with a plugin on npm to support the new version >> selection fe

Re: Test Plugin on npm

2016-03-04 Thread Steven Gill
ould like to test with a plugin on npm to support the new version > selection feature I'm about to merge. > > Thanks, > Richard > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Friday, March 4, 2016 10:41 AM > To: dev@cordova.apache.o

Re: Test Plugin on npm

2016-03-04 Thread Steven Gill
Hey Byoungro, We already test local plugins. I think the point of Richard asking is so we actually test our npm fetching and installing. Cheers, -Steve On Fri, Mar 4, 2016 at 10:37 AM, So, Byoungro <byoungro...@intel.com> wrote: > Hi Richard, > > Do you know you can add the p

Re: Test Plugin on npm

2016-03-04 Thread So, Byoungro
Hi Richard, Do you know you can add the plugin from your local disk path? “cordova plugin add ” might be easier for you than publishing your test plugin on the NPM registry and test using NPM. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation From: Richard Knoll <r

Re: Test Plugin on npm

2016-03-04 Thread Steven Gill
We all just your our own accounts to publish. Publish away On Fri, Mar 4, 2016 at 10:30 AM, Richard Knoll <rikn...@microsoft.com> wrote: > Hey all, > > I'd like to have some better end-to-end tests for "cordova plugin add" in > cordova-lib, so I wanted to publish a te

Test Plugin on npm

2016-03-04 Thread Richard Knoll
Hey all, I'd like to have some better end-to-end tests for "cordova plugin add" in cordova-lib, so I wanted to publish a test plugin to npm. The plugin itself will be empty besides a plugin.xml, I just need it to exist and have engine information I can test against. Do we have an of

[GitHub] cordova-plugin-test-framework pull request: CB-10636 Add JSHint fo...

2016-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

<    1   2   3   4   5   6   7   8   >