Re: Test suite blocking release

2010-03-21 Thread Jan Lehnardt
On 20 Mar 2010, at 20:06, Paul Davis wrote: On Sat, Mar 20, 2010 at 2:31 PM, Noah Slater nsla...@me.com wrote: I think faulty test case should block the release, if I am to have any future sanity preparing releases. I don't want to delay and longer, so if you guys are absolutely sure this is

Re: Test suite blocking release

2010-03-21 Thread Robert Dionne
On Mar 21, 2010, at 4:00 AM, Jan Lehnardt wrote: On 20 Mar 2010, at 20:06, Paul Davis wrote: On Sat, Mar 20, 2010 at 2:31 PM, Noah Slater nsla...@me.com wrote: I think faulty test case should block the release, if I am to have any future sanity preparing releases. I don't want to delay

Re: svn commit: r925497 - /couchdb/trunk/src/couchdb/couch_rep.erl

2010-03-21 Thread Filipe David Manana
Jan, It would also be a good idea to do the same with the filtered replication specific parameters (filter and query_params). The patch attached to this email does it. Also, don't forget the regression test attached to https://issues.apache.org/jira/browse/COUCHDB-703 cheers On Sat, Mar 20,

Re: svn commit: r925497 - /couchdb/trunk/src/couchdb/couch_rep.erl

2010-03-21 Thread Filipe David Manana
Jan, It would also be a good idea to do the same with the filtered replication specific parameters (filter and query_params). The patch attached to this email does it. Also, don't forget the regression test attached to https://issues.apache.org/jira/browse/COUCHDB-703 cheers On Sat, Mar 20,

Re: Test suite blocking release

2010-03-21 Thread Jan Lehnardt
On 21 Mar 2010, at 06:04, Robert Dionne wrote: On Mar 21, 2010, at 4:00 AM, Jan Lehnardt wrote: On 20 Mar 2010, at 20:06, Paul Davis wrote: On Sat, Mar 20, 2010 at 2:31 PM, Noah Slater nsla...@me.com wrote: I think faulty test case should block the release, if I am to have any future

Re: Test suite blocking release

2010-03-21 Thread Noah Slater
What are the CLI tests, if not the etap tests? Are they integrated into the build system? On 21 Mar 2010, at 17:05, Jan Lehnardt wrote: On 21 Mar 2010, at 06:04, Robert Dionne wrote: On Mar 21, 2010, at 4:00 AM, Jan Lehnardt wrote: On 20 Mar 2010, at 20:06, Paul Davis wrote: On

Re: Test suite blocking release

2010-03-21 Thread Jan Lehnardt
On 21 Mar 2010, at 12:10, Noah Slater wrote: What are the CLI tests, if not the etap tests? Are they integrated into the build system? The CLI tests are the same as the browser tests, just run through our couchjs binary that has custom HTTP extensions to make the xhr work. At this point I

Re: Test suite blocking release

2010-03-21 Thread Jan Lehnardt
On 21 Mar 2010, at 12:10, Noah Slater wrote: Are they integrated into the build system? No. Cheers Jan --

Re: Test suite blocking release

2010-03-21 Thread Robert Dionne
On Mar 21, 2010, at 1:16 PM, Jan Lehnardt wrote: On 21 Mar 2010, at 12:10, Noah Slater wrote: What are the CLI tests, if not the etap tests? Are they integrated into the build system? The CLI tests are the same as the browser tests, just run through our couchjs binary that has

Re: Test suite blocking release

2010-03-21 Thread Jan Lehnardt
On 21 Mar 2010, at 12:24, Robert Dionne wrote: On Mar 21, 2010, at 1:16 PM, Jan Lehnardt wrote: On 21 Mar 2010, at 12:10, Noah Slater wrote: What are the CLI tests, if not the etap tests? Are they integrated into the build system? The CLI tests are the same as the browser

Re: Test suite blocking release

2010-03-21 Thread Robert Dionne
Ok Noah, This is only a test case issue, and not in the changes code as I though. Jan found the issue and it works fine for me now in both FF and CLI. -- Bob On Mar 21, 2010, at 1:30 PM, Jan Lehnardt wrote: On 21 Mar 2010, at 12:24, Robert Dionne wrote: On Mar 21, 2010, at 1:16

Re: Test suite blocking release

2010-03-21 Thread Jan Lehnardt
On 21 Mar 2010, at 13:38, Robert Dionne wrote: Ok Noah, This is only a test case issue, and not in the changes code as I though. Jan found the issue and it works fine for me now in both FF and CLI. -- Bob As an added bonus, the test suite should now work 100% in WebKit (for me at least

Re: Test suite blocking release

2010-03-21 Thread Paul Davis
On Sun, Mar 21, 2010 at 1:16 PM, Jan Lehnardt j...@apache.org wrote: On 21 Mar 2010, at 12:10, Noah Slater wrote: Are they integrated into the build system? No. Just in case, to be specific, the CLI tests are just running the Futon tests from the command line. I added the few bits so that

Re: Test suite blocking release

2010-03-21 Thread Paul Davis
I don't have a dog in this fight (.ie. a paying customer) so this failure doesn't bother me. With respect to policy, given the various bogocities of browsers, I'd recommend something like these CLI tests plus the etaps ought to be the official  tests for vetting, and part of the build Not

[jira] Closed: (COUCHDB-703) doc_ids replicate always the same document list

2010-03-21 Thread Jan Lehnardt (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Lehnardt closed COUCHDB-703. Resolution: Fixed Applied in trunk (r925883) and 0.11.x (r925884). doc_ids replicate always

Re: svn commit: r925497 - /couchdb/trunk/src/couchdb/couch_rep.erl

2010-03-21 Thread Jan Lehnardt
Done and done. Thanks again Filipe. Cheers Jan -- On 21 Mar 2010, at 07:10, Filipe David Manana wrote: Jan, It would also be a good idea to do the same with the filtered replication specific parameters (filter and query_params). The patch attached to this email does it. Also, don't

Re: svn commit: r925497 - /couchdb/trunk/src/couchdb/couch_rep.erl

2010-03-21 Thread Nikolai Teofilov
Thanks Filipe! This is very nice and important contribution! Cheers Nikolai On 21.03.2010, at 21:21, Jan Lehnardt wrote: Done and done. Thanks again Filipe. Cheers Jan -- On 21 Mar 2010, at 07:10, Filipe David Manana wrote: Jan, It would also be a good idea to do the same

Re: svn commit: r925497 - /couchdb/trunk/src/couchdb/couch_rep.erl

2010-03-21 Thread Filipe David Manana
Thanks Nikolai for reporting the issue. That was a case that somehow didn't get properly tested when I implemented the feature. cheers On Sun, Mar 21, 2010 at 8:59 PM, Nikolai Teofilov n.teofi...@gmail.comwrote: Thanks Filipe! This is very nice and important contribution! Cheers Nikolai