Re: [PROPOSAL] Disable auto-renew of _session cookies

2018-12-20 Thread Nick Vatamaniuc
Good point regarding the replicator session refresh, Joan. I think it should continue to work, but there would be a slight performance loss. Each replication would make a new request to _session every 10 minutes or so (by default), when now it gets a new session cookie for "free" so to speak. To

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Nick Vatamaniuc
+1 Good call, Jay! On Thu, Dec 20, 2018 at 11:29 AM Alexander Shorin wrote: > On Thu, Dec 20, 2018 at 7:17 PM Joan Touzet wrote > >10:07 * In the 20.x series don't got below 20.3.8.11 There > was a nasty monitor > > related bug in Erlang that davisp fixed >

Re: [PROPOSAL] Disable auto-renew of _session cookies

2018-12-20 Thread Jan Lehnardt
Cookie persistence is separate from auto-renewing sessions. The former makes cookies survive the closing of a browser (window), the latter is the behaviour Mike outlined correctly in the original mail. That feature was introduced when _session was added in the 0.x days, so it’d be a big change.

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Alexander Shorin
On Thu, Dec 20, 2018 at 7:17 PM Joan Touzet wrote >10:07 * In the 20.x series don't got below 20.3.8.11 There was > a nasty monitor > related bug in Erlang that davisp fixed > https://github.com/erlang/otp/commit/bb3f1ed6945a8cca2efa1a571f26e831911944a1 > Oh...I

Re: [PROPOSAL] Disable auto-renew of _session cookies

2018-12-20 Thread Joan Touzet
Looks like the original code that introduced the option was done as part of this work: https://issues.apache.org/jira/browse/COUCHDB-1304 One serious concern on disabling this by default is what might happen to the replicator performance improvement introduced in 2.2.0:

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Joan Touzet
+1 And kxepal: 10:07 * In the 20.x series don't got below 20.3.8.11 There was a nasty monitor related bug in Erlang that davisp fixed https://github.com/erlang/otp/commit/bb3f1ed6945a8cca2efa1a571f26e831911944a1 -Joan - Original Message - From: "Alexander

Re: [PROPOSAL] Disable auto-renew of _session cookies

2018-12-20 Thread Jonathan Hall
The behavior you request is actually the default behavior. I ran into this when I was expressly seeking the behavior you're trying to disable, and made a feature request, only to learn that it is indeed configurable. See this issue: https://github.com/apache/couchdb/issues/1598 In short, I

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Alexander Shorin
+1 P.S. Though I would raise it even to 20. Move fast with the new features! -- ,,,^..^,,, On Thu, Dec 20, 2018 at 11:55 AM Jay Doane wrote: > > Currently, CouchDB requires at least OTP 17 or later to build and run > [1][2]. However, recent work undertaken to eliminate compiler warnings >

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Paul Davis
+1 On Thu, Dec 20, 2018 at 8:15 AM Eiri wrote: > > +1 > > > > On Dec 20, 2018, at 04:55, Jay Doane wrote: > > > > Currently, CouchDB requires at least OTP 17 or later to build and run > > [1][2]. However, recent work undertaken to eliminate compiler warnings > > [3][4] has highlighted the

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Eiri
+1 > On Dec 20, 2018, at 04:55, Jay Doane wrote: > > Currently, CouchDB requires at least OTP 17 or later to build and run > [1][2]. However, recent work undertaken to eliminate compiler warnings > [3][4] has highlighted the additional effort needed to continue to support > older Erlang

[PROPOSAL] Disable auto-renew of _session cookies

2018-12-20 Thread Mike Rhodes
Hi, Currently, _session cookies auto-renew. From what I can read of the code, I think this is via [1] calling into [2], which will put a Set-Cookie header on the response. What this means, I think, is that if I can retrieve your session cookie in some way, then ensure I keep making calls

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Jan Lehnardt
Good proposal, thanks Jay! In the past we looked at what distributions had which Erlang version available, but over the years this has become increasingly difficult, as a) distros would do weird things to the OTP distribution and b) would not update quite quickly. With our advent of binary

Re: [PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Robert Samuel Newson
+1 > On 20 Dec 2018, at 08:55, Jay Doane wrote: > > Currently, CouchDB requires at least OTP 17 or later to build and run > [1][2]. However, recent work undertaken to eliminate compiler warnings > [3][4] has highlighted the additional effort needed to continue to support > older Erlang

[PROPOSAL] Change the minimum supported Erlang version to OTP 19

2018-12-20 Thread Jay Doane
Currently, CouchDB requires at least OTP 17 or later to build and run [1][2]. However, recent work undertaken to eliminate compiler warnings [3][4] has highlighted the additional effort needed to continue to support older Erlang versions. Some of the issues that have come up are: 1. erlang:now/0