Re: [DISCUSS] erlfmt the 3.x branch

2021-11-18 Thread Nick Vatamaniuc
I gave it a try in https://github.com/apache/couchdb/pull/3837 There are two separate commits - tooling and actual formatting. The Erlang version check didn't seem too bad to implement. Hopefully soon we'll jump to 21+ and can clean that code up. >From the main branch I ported all the formatting

Re: [DISCUSS] erlfmt the 3.x branch

2021-11-18 Thread Nick Vatamaniuc
Hi Jay, I don't really agree with many of the choices erlfmt makes either. I personally like emilio's [1] syntax rules better. But, I think there is still a net benefit to having a standardized format that is automatically applied and enforced. The automated part helps when reviewing PRs / contrib

Re: [DISCUSS] erlfmt the 3.x branch

2021-11-18 Thread Jay Doane
Hi Nick, As with main, my objections to a mass reformatting of hundreds of files boils down to: 1. Making it more difficult to understand the logical changes of the code (via blame) after reformatting 2. I don't agree with all the opinions of the formatter, nor does my editor/mode Is this someth

[DISCUSS] erlfmt the 3.x branch

2021-11-17 Thread Nick Vatamaniuc
Hi all, I had noticed we had agreed to use erlfmt but only ran it on main and not 3.x. That makes it harder to port changes or diff-ing modules sometimes. Would there be any objections to a pull request reformatting 3.x? The only issue is that we may have to avoid running erlfmt if we detect Erla