Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-101317048
@hdiedrich Hey! Config support suddenly is needed by the following reasons:
- It saved us many times when security issue was found in some HTTP
handler. Th
Github user hdiedrich commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-101308611
Hi, I need to review what that over all situation for this is at this
point. Status is that there was a wish from Paul on how to better kick the
handlers in, wh
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-97832439
@hdiedrich: Any updates on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r23889246
--- Diff: src/chttpd_handler.erl ---
@@ -0,0 +1,202 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
+%% use
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-69365389
I'm happy with merge this. @rnewson @davisp @chewbranca what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65291589
> It's peripheral, I believe, but the output of the test could be helpful
to indicate, which endpoint breaks, rather than which test function breaks.
That's why I t
Github user hdiedrich commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65246798
It's peripheral, I believe, but the output of the test could be helpful to
indicate, which endpoint breaks, rather than which test function breaks. That's
why I
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65217771
@hdiedrich if you're looking for fixing eunit output take a look on how
formatters are done for it. For instance:
https://github.com/seancribbs/eunit_formatters . D
Github user hdiedrich commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65216944
I guess the NODEBUG proposal was a misunderstanding. I was looking for a
way to create readable test output, as created during the test. Not sure what
you actual
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21099269
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may no
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65088688
Yes, but better add `{erl_opts, [{d, NODEBUG}]}.` to rebar config
(setup_eunit?). This better have global wide.
---
If your project is set up for it, you can reply
Github user hdiedrich commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65087557
Ok, thanks! I can set NODEBUG at the top of the test module?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65086583
> however, do we need to have "httpd_handler_callback_test:206:" before
each output line?
That will save a lot of time if something will go wrong since it
Github user hdiedrich commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65084297
Thanks a lot for digging into it, I'll change accordingly, however, do we
need to have "httpd_handler_callback_test:206:" before each output line? I
don't know w
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-65078078
All cool, but seems your logging is still there. Try this trick:
```
diff --git a/test/chttpd_handler_callback_test.erl
b/test/chttpd_handler_callback_t
Github user hdiedrich commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21090978
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
m
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21087563
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21087513
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21087260
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user hdiedrich commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21086105
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
m
Github user hdiedrich commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21086072
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user hdiedrich commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21085971
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user hdiedrich commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21085948
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user hdiedrich commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21085923
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
m
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21059279
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21059280
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21059277
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21059267
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21059266
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21059264
--- Diff: test/chttpd_handler_callback_test.erl ---
@@ -0,0 +1,266 @@
+%% Licensed under the Apache License, Version 2.0 (the "License"); you
may
Github user hdiedrich commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-64922076
Note, I am adding less essential stuff, if unplanned for, in separate
commits, as requested.
---
If your project is set up for it, you can reply to this email
GitHub user hdiedrich opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/10
Dynamic endpoints handlers
chttpd hardcoded handlers are replaced with with dynamic url handlers,
which are functions in a dynamically created module, assembled from
priv/chttpd_hand
32 matches
Mail list logo
