Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/27#issuecomment-70506054
History is rewritten for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/27#issuecomment-70529641
\o/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/27#issuecomment-70430960
Ha! Plain and simple (: +1
@iilyak could you squash all your commits?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22413903
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir =
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/27#issuecomment-68520978
I'm confused. Why rename the directory if you're going to make the delete
async? It seems the entire fix is just to spawn a process to do the cleanup of
the
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22408655
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir =
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22409325
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir =
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22413779
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir =
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22416091
--- Diff: src/couch_file.erl ---
@@ -257,13 +257,43 @@ nuke_dir(RootDelDir, Dir) -
init_delete_dir(RootDir) -
Dir =
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/27#issuecomment-68396621
LGFM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/27
Modify init_delete_dir to be async
In the case when .delete directory contains lots of files.
The deletion of the directory leads to timeout in the supervisor.
Which in it's turn kills
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22121802
--- Diff: src/couch_file.erl ---
@@ -260,10 +260,19 @@ init_delete_dir(RootDir) -
% note: ensure_dir requires an actual filename companent,
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22122343
--- Diff: src/couch_file.erl ---
@@ -260,10 +260,19 @@ init_delete_dir(RootDir) -
% note: ensure_dir requires an actual filename companent,
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/27#discussion_r22132403
--- Diff: src/couch_file.erl ---
@@ -260,10 +260,19 @@ init_delete_dir(RootDir) -
% note: ensure_dir requires an actual filename companent,
15 matches
Mail list logo
