Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-75569421
Merged as 392dc52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-7100
+1. This is great work @benkeen. Merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-75491870
Commits squashed. The failing unit test was unrelated to this ticket. Let's
see what Travis says this time.
---
If your project is set up for it, you can reply
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74913629
k, here we go. Had to do a hack to get the error highlight blink to work,
but it was between two evils: using jQuery or plain CSS, so I vouched for the
latter.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74901031
All fixed except for the last React error you spotted. I'll fix that up
now. The code shouldn't allow adding the same item multiple times as it does
right now; I
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74832238
@benkeen this is looking better. Two components just need to be more self
contained. I also picked up some bugs while testing.
* Once I add a filter
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24886051
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,244 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885981
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,244 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885896
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,244 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885676
--- Diff: app/addons/documents/tests/changes.componentsSpec.react.jsx ---
@@ -0,0 +1,215 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885710
--- Diff: app/addons/documents/tests/changes.componentsSpec.react.jsx ---
@@ -0,0 +1,215 @@
+// Licensed under the Apache License, Version 2.0
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74738123
Thanks for all your help, @garrensmith! All updated.
- actions + store tests added
- form moved back to a single component
- dropped third unnecessary
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74579976
Hey @garrensmith, I confess I was getting a bit confused about some things
so I thought I'd just experiment a bit and organize things in what I regard as
a logic
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74534191
Thanks @garrensmith. I think the input field was all set up properly - I
just wasn't grabbing the current value from the store here. Updated.
---
If your proje
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74468883
@benkeen making good progress. As I mentioned in the previous comment, the
way the filter is added needs to be a controlled component.
---
If your project i
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24734807
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,238 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74310883
Alrighty! *This* time it's totally good to go. ;) All suggested changes
made.
---
If your project is set up for it, you can reply to this email and have your
re
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24685901
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24679844
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658385
--- Diff: app/addons/fauxton/stores.js ---
@@ -185,6 +185,7 @@ function(app, FauxtonAPI, ActionTypes) {
Stores.navBarStore = new Stores.Nav
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658378
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -20,6 +20,7 @@ define([
function(FauxtonAPI, React, Stores, Actions) {
var na
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658328
--- Diff: app/addons/documents/tests/changesHeader.componentsSpec.react.jsx
---
@@ -0,0 +1,138 @@
+// Licensed under the Apache License, Vers
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658263
--- Diff: app/addons/documents/changes/stores.js ---
@@ -0,0 +1,73 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658179
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24658101
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24657971
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24657816
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24656340
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (t
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24656033
--- Diff: app/addons/documents/changes/changes-header.react.jsx ---
@@ -0,0 +1,236 @@
+// Licensed under the Apache License, Version 2.0 (t
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74130532
Alrighty! Tests added. I think this is good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73994744
Thanks, @robertkowalski! Just working on the tests now & ran into some
trouble. I'll commit what I have, but I'll have questions tomorrow. Basically
I'm unable t
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73994457
@benkeen this looks a lot better, we will need tests to merge this,
examples:
- `ChangesHeader `: the element shows/removes the subcomponent
cond
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24515523
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -150,12 +151,133 @@ function(FauxtonAPI, React, Stores, Actions) {
});
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24515498
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -150,12 +151,133 @@ function(FauxtonAPI, React, Stores, Actions) {
});
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24515318
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -150,12 +151,133 @@ function(FauxtonAPI, React, Stores, Actions) {
});
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73864471
stopping here for now - @garrensmith will talk to you later
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73863175
When running the code I get:
```
Linting app/addons/documents/changes/changes-header.react.js ...ERROR
[L27:C8] W033: Missing semicolon.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73861608
looks promising!
- we will need tests in order to merge it, one test could be that adding a
filter adds it to the react wrapper component
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-73817956
Hey @robertkowalski, @garrensmith - my first foray into React. Woot!
I largely copied the structure etc. from the code that was already there,
but I'm su
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/265
Changes page Filters tab moved to React
This updates the Filter tab and filter on the Changes page
to use React. It also ports over Components.FilterView and
Components.FilterViewIte
41 matches
Mail list logo
