Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36782400
Testing this now and nothing is breaking for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10316437
--- Diff: src/fauxton/test/mocha/chai.js ---
@@ -27,10 +27,14 @@ function require(path, parent, orig) {
// perform real require()
--- End
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10316575
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -274,20 +338,31 @@ function(app, FauxtonAPI) {
Documents.AllDocs =
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36604411
@kxepal Can you explain what you mean by the 50 and 100 limits not working?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36609594
@garrensmith get it 100% reproduce:
- Navigate to any view
- Open Query Options
- Set Limit to lets say 20
- Query the view
- Collapse Query Options
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36609679
@deathbearbrown
The API URL button is what is going to show the URL for you to do curl
commands, not the fauxton url.
Yes, and I was talking about sharing
That sounds like the correct behaviour. You've constrained the result set to 20
docs, so a page size 20 isn't going to show more docs. The same would happen
if the DB only had 20 docs in.
On Tuesday, 4 March 2014 at 10:16, kxepal wrote:
Github user kxepal commented on the pull request:
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36612933
Simon:
I and @garrensmith just discussed this topic in IRC. TL;DR this is could be
correct behaviour for Fauxton, but 1) it's not oblivious 2) 90% users will
I think the right thing to do is have some kind of expecting more docs? Check
your advanced options message if the number of docs is less than the page
size, and advanced options are set.
The alternative is removing the limit option, which doesn't solve the problem
for other limiting
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/162
New pagination
This is a much pagination for Fauxton.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb paginate-api-options
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220050
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -274,20 +338,31 @@ function(app, FauxtonAPI) {
Documents.AllDocs =
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220227
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -170,9 +168,11 @@ function(app, FauxtonAPI, Documents, Databases) {
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36537099
Looks as a lot of work! But could you provide some summary what have
changed, what does it improved and...why?(:
---
If your project is set up for it, you can reply to
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36537234
Bug: Page sizes 50 and 100 for browsing views doesn't works. Actually, it
applies last selected page size or 20.
---
If your project is set up for it, you can reply to
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220337
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -345,14 +376,62 @@ function(app, FauxtonAPI, Documents, Databases) {
}));
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220399
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -345,14 +376,62 @@ function(app, FauxtonAPI, Documents, Databases) {
}));
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220446
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -170,9 +168,11 @@ function(app, FauxtonAPI, Documents, Databases) {
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220481
--- Diff:
src/fauxton/app/addons/documents/templates/advanced_options_menu.html ---
@@ -0,0 +1,46 @@
+!--
+Licensed under the Apache License,
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220493
--- Diff:
src/fauxton/app/addons/documents/templates/advanced_options_menu.html ---
@@ -0,0 +1,46 @@
+!--
+Licensed under the Apache License,
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220526
--- Diff: src/fauxton/app/addons/documents/templates/all_docs_number.html
---
@@ -11,13 +11,25 @@
License for the specific language governing
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220586
--- Diff: src/fauxton/app/addons/documents/views.js ---
@@ -477,17 +493,14 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb,
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36538145
Another moment: when paginates views, Fauxton adds `limit=N` argument to
the URL. It's awesome! But if I set `N` as 11, 15, 42, 100500, Fauxton accepts
the specified
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36538352
Also, if I set bad value for `limit` in URL like `limit=foo`, Fauxton will
show `Bad request` error popup and resets limit to 100 while default value is
20.
---
If
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220754
--- Diff: src/fauxton/test/mocha/chai.js ---
@@ -27,10 +27,14 @@ function require(path, parent, orig) {
// perform real require()
--- End
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36538603
Bug: Page sizes 50 and 100 for browsing views doesn't works. Actually, it
applies last selected page size or 20.
More notes: it only raises if `limit=N` is in
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36538662
@deathbearbrown hm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10220922
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -170,9 +168,11 @@ function(app, FauxtonAPI, Documents, Databases) {
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36538924
I think we want to move away from passing the limit parameters in the route
fragment.
---
If your project is set up for it, you can reply to this email and
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10221023
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -170,9 +168,11 @@ function(app, FauxtonAPI, Documents, Databases) {
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36538591
kxep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36539425
@deathbearbrown if so, than Fauxton shouldn't process them. However, I see
that you wanted to kill the feature: processing query params from route url
allows users to
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36539755
or another case: you configured query for specific view in Fauxton and know
wanted to make the same request via curl or whatever client. Just copypaste the
URL and
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/162#issuecomment-36539801
kxe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10244737
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -274,20 +338,31 @@ function(app, FauxtonAPI) {
Documents.AllDocs =
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10244755
--- Diff: src/fauxton/app/addons/documents/routes.js ---
@@ -170,9 +168,11 @@ function(app, FauxtonAPI, Documents, Databases) {
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/162#discussion_r10245597
--- Diff: src/fauxton/test/mocha/chai.js ---
@@ -27,10 +27,14 @@ function require(path, parent, orig) {
// perform real require()
--- End diff
37 matches
Mail list logo
