ottlinger commented on PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2093681175
> @ottlinger If you approve I can merge this. If you want more eyes on it,
lets's invite a few reviewers.
In the PR's main description you've created a check list - is that
ottlinger commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1589675326
##
src/changes/changes.xml:
##
@@ -72,6 +72,22 @@
https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd
-->
+
+
ottlinger commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1589675326
##
src/changes/changes.xml:
##
@@ -72,6 +72,22 @@
https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd
-->
+
+
ottlinger commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1589673093
##
apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java:
##
@@ -1,150 +1,150 @@
-/*
- * Licensed to the Apache Software
ottlinger commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1589669854
##
apache-rat-core/pom.xml:
##
@@ -126,5 +126,10 @@
assertj-core
test
+
Review Comment:
Thanks.
--
This is an automated message
Cool, good to know that everything works automatically!
Phil
Am 03.05.24 um 12:59 schrieb Claude Warren:
If the XML looks like:
"
The output as defined in the default.xslt would be:
A src/test/resources/elements/dummy.jar
MIT MITThe MIT License
AL
If the XML looks like:
"
The output as defined in the default.xslt would be:
A src/test/resources/elements/dummy.jar
MIT MITThe MIT License
AL AL Apache License Version 2.0
So all the enclosed licenses are reported for the jar itself. If
Hi Claude,
Am 03.05.24 um 07:26 schrieb Claude Warren:
"
This proposal would, in cases where licenses are discovered, add the
license entries as with STANDARD resource types. For example:
"
how would the report on System.out look like?
a) "exploded"
A Foo.jar
GPL3
