Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
Claudenw commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1590227519 ## spotbugs_ignore.xml: ## @@ -0,0 +1,26 @@ + + + + + + Review Comment: Should the commented code above be removed. If so should the file be removed?

Re: Web site contents

2024-05-05 Thread P. Ottlinger
Am 05.05.24 um 07:42 schrieb Claude Warren: I was only looking at a small part of the documentation. What I was hoping was that there was a tag in the apt or vm processing that would allow us to insert text. And then figure out how to load that text from the application itself. There are sever

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1590313941 ## spotbugs_ignore.xml: ## @@ -0,0 +1,26 @@ + + + + + + Review Comment: If the file is missing the build fails, therefore I had to introduce it in all

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1590314645 ## spotbugs_ignore.xml: ## @@ -0,0 +1,26 @@ + + + + + + Review Comment: The maven spotbugs integration allows either to run spotbugs:spotbugs to see th

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1590315467 ## spotbugs_ignore.xml: ## @@ -0,0 +1,26 @@ + + + + + + Review Comment: Unfortunately this is not what we would want to have :( The docs are not really

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1590317668 ## spotbugs_ignore.xml: ## @@ -0,0 +1,26 @@ + + + + + + Review Comment: The only available exclusion rule seems to relate to the severity https

[jira] [Commented] (RAT-369) Add SpotBugs and checkstyle to the pom files.

2024-05-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843568#comment-17843568 ] ASF subversion and git services commented on RAT-369: - Commit c807a4d0aa

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1590318136 ## spotbugs_ignore.xml: ## @@ -0,0 +1,26 @@ + + + + + + Review Comment: I assume mvn spotbugs:gui is the best way to work with the tool at the moment a

Re: [RAT][DISCUSS] document categorization.

2024-05-05 Thread P. Ottlinger
Hi, Am 05.05.24 um 08:52 schrieb Claude Warren: *Current state* We attempt to provide a default configuration that is ASF requirements based. We currently categorize documents into one of six categories: Generated, Unknown, Archive, Notice, Binary, Standard. - Standard documents get scann

Re: [PR] RAT-372: Create archive processor [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on code in PR #246: URL: https://github.com/apache/creadur-rat/pull/246#discussion_r1590322105 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -59,74 +65,166 @@ import org.apache.rat.walker.ArchiveWalker; import org.apache.rat.walker.Dire

Re: [PR] RAT-372: Create archive processor [creadur-rat]

2024-05-05 Thread via GitHub
Claudenw commented on code in PR #246: URL: https://github.com/apache/creadur-rat/pull/246#discussion_r1590328305 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -59,74 +65,166 @@ import org.apache.rat.walker.ArchiveWalker; import org.apache.rat.walker.Direc

[jira] [Commented] (RAT-150) RAT should use Apache Tika to simply guess ignored [application/X] file types and focus on the [text/Y] family as a sensible default

2024-05-05 Thread Chris Mattmann (Jira)
[ https://issues.apache.org/jira/browse/RAT-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843578#comment-17843578 ] Chris Mattmann commented on RAT-150: great work!!!  > RAT should use Apache Tika to sim

Re: [RAT][DISCUSS] document categorization.

2024-05-05 Thread Claude Warren
If there is a requirement that a NOTICE file exists then there are probably other projects that have requirements for other files to exist. Perhaps we need a way to specify that specific file patterns must exist. We could add: - --require-file-literal to exclude literal file name (e.g. "AUTHO

Re: [PR] RAT-372: Create archive processor [creadur-rat]

2024-05-05 Thread via GitHub
Claudenw commented on code in PR #246: URL: https://github.com/apache/creadur-rat/pull/246#discussion_r1590389356 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -59,74 +65,166 @@ import org.apache.rat.walker.ArchiveWalker; import org.apache.rat.walker.Direc

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2094927475 @Claudenw If you do not mind I would merge this one tomorrow :) Thanks for your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] RAT-369: Add checkstyle and spotbugs to build and generate a report [creadur-rat]

2024-05-05 Thread via GitHub
Claudenw commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2094935597 Sounds good to me On Sun 5 May 2024, 21:50 P. Ottlinger, ***@***.***> wrote: > @Claudenw If you do not mind I would merge > this one tomorr

[PR] Bump mavenPluginPluginVersion from 3.12.0 to 3.13.0 [creadur-rat]

2024-05-05 Thread via GitHub
dependabot[bot] opened a new pull request, #247: URL: https://github.com/apache/creadur-rat/pull/247 Bumps `mavenPluginPluginVersion` from 3.12.0 to 3.13.0. Updates `org.apache.maven.plugin-tools:maven-plugin-annotations` from 3.12.0 to 3.13.0 Commits https://github.com/apac

[PR] Bump mavenPluginPluginVersion from 3.12.0 to 3.13.0 [creadur-whisker]

2024-05-05 Thread via GitHub
dependabot[bot] opened a new pull request, #144: URL: https://github.com/apache/creadur-whisker/pull/144 Bumps `mavenPluginPluginVersion` from 3.12.0 to 3.13.0. Updates `org.apache.maven.plugin-tools:maven-plugin-annotations` from 3.12.0 to 3.13.0 Commits https://github.com/

[jira] [Created] (RAT-375) Add an archived deployment module

2024-05-05 Thread Claude Warren (Jira)
Claude Warren created RAT-375: - Summary: Add an archived deployment module Key: RAT-375 URL: https://issues.apache.org/jira/browse/RAT-375 Project: Apache Rat Issue Type: Improvement Co

[jira] [Comment Edited] (RAT-363) Introduce project description

2024-05-05 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843445#comment-17843445 ] Claude Warren edited comment on RAT-363 at 5/6/24 6:12 AM: --- DOAP s

Re: [PR] Bump mavenPluginPluginVersion from 3.12.0 to 3.13.0 [creadur-whisker]

2024-05-05 Thread via GitHub
ottlinger merged PR #144: URL: https://github.com/apache/creadur-whisker/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadu

[jira] [Created] (RAT-376) site:site does not produce a site with links to running rat topics

2024-05-05 Thread Claude Warren (Jira)
Claude Warren created RAT-376: - Summary: site:site does not produce a site with links to running rat topics Key: RAT-376 URL: https://issues.apache.org/jira/browse/RAT-376 Project: Apache Rat Is